From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] New command testspeed
Date: Sun, 29 Apr 2012 22:28:52 +0200 [thread overview]
Message-ID: <4F9DA484.501@gmail.com> (raw)
In-Reply-To: <4F9DA343.5000708@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On 29.04.2012 22:23, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 29.04.2012 22:09, Bean wrote:
>> Hi,
>>
>> Pls check out this one.
> In terms of decreasing code duplication it doesn't improve at all. The
> prefix-chosing code needs to be put into a separate function which would
> be used by both instances.
E.g.
#define GRUB_HUMAN_SIZE_MAX_LEN sizeof ("XXXXXXXXXXXXXXXXXXXX TiB")
void grub_huma_size_make_size (char *res, grub_disk_addr_t sz);
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2012-04-29 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 15:12 [PATCH] New command testspeed Bean
2012-04-29 15:36 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-29 20:09 ` Bean
2012-04-29 20:23 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-29 20:28 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9DA484.501@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.