From: Minchan Kim <minchan@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: akpm@linux-foundation.org, rohit.seth@intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix devision by 0 in percpu_pagelist_fraction
Date: Mon, 30 Apr 2012 11:30:23 +0900 [thread overview]
Message-ID: <4F9DF93F.30403@kernel.org> (raw)
In-Reply-To: <1335623131-15728-1-git-send-email-levinsasha928@gmail.com>
On 04/28/2012 11:25 PM, Sasha Levin wrote:
> percpu_pagelist_fraction_sysctl_handler() has only considered -EINVAL as a possible error
> from proc_dointvec_minmax(). If any other error is returned, it would proceed to divide by
> zero since percpu_pagelist_fraction wasn't getting initialized at any point. For example,
> writing 0 bytes into the proc file would trigger the issue.
>
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
Reviewed-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: akpm@linux-foundation.org, rohit.seth@intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix devision by 0 in percpu_pagelist_fraction
Date: Mon, 30 Apr 2012 11:30:23 +0900 [thread overview]
Message-ID: <4F9DF93F.30403@kernel.org> (raw)
In-Reply-To: <1335623131-15728-1-git-send-email-levinsasha928@gmail.com>
On 04/28/2012 11:25 PM, Sasha Levin wrote:
> percpu_pagelist_fraction_sysctl_handler() has only considered -EINVAL as a possible error
> from proc_dointvec_minmax(). If any other error is returned, it would proceed to divide by
> zero since percpu_pagelist_fraction wasn't getting initialized at any point. For example,
> writing 0 bytes into the proc file would trigger the issue.
>
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
Reviewed-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2012-04-30 2:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 14:25 [PATCH] mm: fix devision by 0 in percpu_pagelist_fraction Sasha Levin
2012-04-28 14:25 ` Sasha Levin
2012-04-30 2:30 ` Minchan Kim [this message]
2012-04-30 2:30 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9DF93F.30403@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rohit.seth@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.