From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, davej@redhat.com
Subject: Re: [PATCH] qemu: fix cpuid eax for kvm cpu
Date: Tue, 01 May 2012 15:38:43 +0300 [thread overview]
Message-ID: <4F9FD953.7070809@redhat.com> (raw)
In-Reply-To: <20120430144214.GA10237@redhat.com>
On 04/30/2012 05:42 PM, Michael S. Tsirkin wrote:
> cpuid eax should return the max leaf so that
> guests can find out the valid range.
> This matches Xen et al.
>
> Tested using -cpu kvm64.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> target-i386/kvm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index e74a9e4..c097248 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -379,7 +379,7 @@ int kvm_arch_init_vcpu(CPUX86State *env)
> c->function = KVM_CPUID_SIGNATURE;
> if (!hyperv_enabled()) {
> memcpy(signature, "KVMKVMKVM\0\0\0", 12);
> - c->eax = 0;
> + c->eax = KVM_CPUID_FEATURES;
> } else {
> memcpy(signature, "Microsoft Hv", 12);
> c->eax = HYPERV_CPUID_MIN;
Should only change for -M 1.1+?
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: davej@redhat.com, Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] qemu: fix cpuid eax for kvm cpu
Date: Tue, 01 May 2012 15:38:43 +0300 [thread overview]
Message-ID: <4F9FD953.7070809@redhat.com> (raw)
In-Reply-To: <20120430144214.GA10237@redhat.com>
On 04/30/2012 05:42 PM, Michael S. Tsirkin wrote:
> cpuid eax should return the max leaf so that
> guests can find out the valid range.
> This matches Xen et al.
>
> Tested using -cpu kvm64.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> target-i386/kvm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index e74a9e4..c097248 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -379,7 +379,7 @@ int kvm_arch_init_vcpu(CPUX86State *env)
> c->function = KVM_CPUID_SIGNATURE;
> if (!hyperv_enabled()) {
> memcpy(signature, "KVMKVMKVM\0\0\0", 12);
> - c->eax = 0;
> + c->eax = KVM_CPUID_FEATURES;
> } else {
> memcpy(signature, "Microsoft Hv", 12);
> c->eax = HYPERV_CPUID_MIN;
Should only change for -M 1.1+?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-05-01 12:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 14:42 [PATCH] qemu: fix cpuid eax for kvm cpu Michael S. Tsirkin
2012-05-01 12:38 ` Avi Kivity [this message]
2012-05-01 12:38 ` [Qemu-devel] " Avi Kivity
2012-05-01 12:49 ` Michael S. Tsirkin
2012-05-01 12:49 ` [Qemu-devel] " Michael S. Tsirkin
2012-05-01 13:02 ` Avi Kivity
2012-05-01 13:02 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9FD953.7070809@redhat.com \
--to=avi@redhat.com \
--cc=davej@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.