* [PATCH] xfs_repair: fix for fragmented multiblock dirs
@ 2012-05-02 3:54 Eric Sandeen
0 siblings, 0 replies; only message in thread
From: Eric Sandeen @ 2012-05-02 3:54 UTC (permalink / raw)
To: xfs-oss
blkmap_getn() was reallocating the bmap_ext_t *bmp array
for each extent in the loop, thereby losing previously
filled-in elements, and generally making a mess of things.
Allocating it only the first time through the loop
fixes this right up.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/repair/bmap.c b/repair/bmap.c
index 2f1c307..c43ca7f 100644
--- a/repair/bmap.c
+++ b/repair/bmap.c
@@ -168,7 +168,8 @@ blkmap_getn(
/*
* rare case - multiple extents for a single dir block
*/
- bmp = malloc(nb * sizeof(bmap_ext_t));
+ if (!bmp)
+ bmp = malloc(nb * sizeof(bmap_ext_t));
if (!bmp)
do_error(_("blkmap_getn malloc failed (%" PRIu64 " bytes)\n"),
nb * sizeof(bmap_ext_t));
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-05-02 3:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-02 3:54 [PATCH] xfs_repair: fix for fragmented multiblock dirs Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.