From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Markus Armbruster <armbru@redhat.com>
Cc: Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>,
qemu-devel <qemu-devel@nongnu.org>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] Fix geometry sector calculation
Date: Wed, 02 May 2012 12:25:35 +0200 [thread overview]
Message-ID: <4FA10B9F.9040909@redhat.com> (raw)
In-Reply-To: <4FA109F6.3090107@de.ibm.com>
Il 02/05/2012 12:18, Christian Borntraeger ha scritto:
> Maybe that really points to the problem that we are trying to solve here.
> For a dasd device, there is usually a 4096 byte block size and on the host
> these 4096 arereported via getss and getpbsz.
> The geometry reported by the device driver is usually 15 head and 12 sectors
> per track, but actually means 12 sectors of 4096 bytes size (a track ~ 48k).
>
> What I want to achieve is that the guest view is identical to the host view
> for cyls, heads, secs, and all block sizes.
I think what you want is _not_ to have the same view as the host. What
you want is simply to have a default that is consistent with what is
common on actual s390 disks.
Perhaps what we want here is to move the guessing of cyls/head/sector
count from -drive to -device, so that virtio-blk-s390 can apply a
different default (cyls=auto, head=15, sector=12, and also lbsz=pbsz=4096).
Markus, have you ever thought about that? I'm a bit torn because these
are media parameters rather than device parameters, on the other hand
the same applies to lbsz/pbsz at least.
Paolo
next prev parent reply other threads:[~2012-05-02 10:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1335448165-26174-1-git-send-email-borntraeger@de.ibm.com>
[not found] ` <1335448165-26174-2-git-send-email-borntraeger@de.ibm.com>
[not found] ` <4F9AC55F.5000101@redhat.com>
2012-05-02 10:18 ` [Qemu-devel] [PATCH 1/3] Fix geometry sector calculation Christian Borntraeger
2012-05-02 10:25 ` Paolo Bonzini [this message]
2012-05-02 10:50 ` Christian Borntraeger
2012-05-02 11:05 ` Paolo Bonzini
2012-05-02 11:07 ` Alexander Graf
2012-05-02 11:09 ` Paolo Bonzini
2012-05-02 11:10 ` Alexander Graf
2012-05-02 11:23 ` Paolo Bonzini
[not found] ` <1335448165-26174-3-git-send-email-borntraeger@de.ibm.com>
[not found] ` <4F9AC55D.3000904@redhat.com>
2012-05-02 10:27 ` [Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO Christian Borntraeger
2012-05-02 11:09 ` Alexander Graf
2012-05-02 11:26 ` Paolo Bonzini
2012-05-02 11:35 ` Alexander Graf
2012-05-02 11:38 ` Paolo Bonzini
2012-05-02 12:54 ` Alexander Graf
2012-05-02 14:27 ` Christian Borntraeger
2012-05-02 15:05 ` Alexander Graf
2012-05-02 18:49 ` Christian Borntraeger
2012-05-02 15:57 ` Stefan Weinhuber
2012-05-02 18:39 ` Alexander Graf
2012-05-02 11:56 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA10B9F.9040909@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=graalfs@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.