From: Alexander Graf <agraf@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Einar Lueck <elelueck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO
Date: Wed, 02 May 2012 13:35:34 +0200 [thread overview]
Message-ID: <4FA11C06.10400@suse.de> (raw)
In-Reply-To: <6715e896-3fdb-4223-a33b-cecbbf6785ac@zmail13.collab.prod.int.phx2.redhat.com>
On 05/02/2012 01:26 PM, Paolo Bonzini wrote:
>> and everyone should be happy :). I would really like to have as
>> little #ifdef TARGET_S390 code in QEMU. And #ifdef __s390__ is even worse,
>> as it means we won't be able to execise that code path on other
>> architectures.
> True, but how do you exercise that code path with DASD geometry
> on !__s390__?
If we make things a flag for the guessing code, it should work just as
well with image files, right?
Alex
next prev parent reply other threads:[~2012-05-02 11:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1335448165-26174-1-git-send-email-borntraeger@de.ibm.com>
[not found] ` <1335448165-26174-2-git-send-email-borntraeger@de.ibm.com>
[not found] ` <4F9AC55F.5000101@redhat.com>
2012-05-02 10:18 ` [Qemu-devel] [PATCH 1/3] Fix geometry sector calculation Christian Borntraeger
2012-05-02 10:25 ` Paolo Bonzini
2012-05-02 10:50 ` Christian Borntraeger
2012-05-02 11:05 ` Paolo Bonzini
2012-05-02 11:07 ` Alexander Graf
2012-05-02 11:09 ` Paolo Bonzini
2012-05-02 11:10 ` Alexander Graf
2012-05-02 11:23 ` Paolo Bonzini
[not found] ` <1335448165-26174-3-git-send-email-borntraeger@de.ibm.com>
[not found] ` <4F9AC55D.3000904@redhat.com>
2012-05-02 10:27 ` [Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO Christian Borntraeger
2012-05-02 11:09 ` Alexander Graf
2012-05-02 11:26 ` Paolo Bonzini
2012-05-02 11:35 ` Alexander Graf [this message]
2012-05-02 11:38 ` Paolo Bonzini
2012-05-02 12:54 ` Alexander Graf
2012-05-02 14:27 ` Christian Borntraeger
2012-05-02 15:05 ` Alexander Graf
2012-05-02 18:49 ` Christian Borntraeger
2012-05-02 15:57 ` Stefan Weinhuber
2012-05-02 18:39 ` Alexander Graf
2012-05-02 11:56 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA11C06.10400@suse.de \
--to=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=elelueck@de.ibm.com \
--cc=graalfs@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.