From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Kevin Hilman <khilman@ti.com>, Tony Lindgren <tony@atomide.com>,
"Cousson, Benoit" <b-cousson@ti.com>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()
Date: Thu, 03 May 2012 16:46:02 +0530 [thread overview]
Message-ID: <4FA268F2.5090301@ti.com> (raw)
In-Reply-To: <1335536018-16004-9-git-send-email-tarun.kanti@ti.com>
On Friday 27 April 2012 07:43 PM, Tarun Kanti DebBarma wrote:
> We do checking for bank->enabled_non_wakeup_gpios in order
> to skip redundant operations. Somehow, the check got missed
> while doing the cleanup series.
>
> Just to make sure that we do context restore correctly in
> *_runtime_resume(), the bank->workaround_enabled check is
> moved after context restore. Otherwise, it would prevent
> context restore when bank->enabled_non_wakeup_gpios is 0.
>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Cousson, Benoit <b-cousson@ti.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
> ---
Looks good.
Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend()
Date: Thu, 03 May 2012 16:46:02 +0530 [thread overview]
Message-ID: <4FA268F2.5090301@ti.com> (raw)
In-Reply-To: <1335536018-16004-9-git-send-email-tarun.kanti@ti.com>
On Friday 27 April 2012 07:43 PM, Tarun Kanti DebBarma wrote:
> We do checking for bank->enabled_non_wakeup_gpios in order
> to skip redundant operations. Somehow, the check got missed
> while doing the cleanup series.
>
> Just to make sure that we do context restore correctly in
> *_runtime_resume(), the bank->workaround_enabled check is
> moved after context restore. Otherwise, it would prevent
> context restore when bank->enabled_non_wakeup_gpios is 0.
>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Cousson, Benoit <b-cousson@ti.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
> ---
Looks good.
Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2012-05-03 11:16 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 14:13 [PATCH 0/8] gpio/omap: remaining cleanups and fix Tarun Kanti DebBarma
2012-04-27 14:13 ` Tarun Kanti DebBarma
2012-04-27 14:13 ` [PATCH 1/8] gpio/omap: remove virtual_irq_start variable Tarun Kanti DebBarma
2012-04-27 14:13 ` Tarun Kanti DebBarma
2012-05-03 11:13 ` Santosh Shilimkar
2012-05-03 11:13 ` Santosh Shilimkar
2012-04-27 14:13 ` [PATCH 2/8] gpio/omap: remove saved_fallingdetect, saved_risingdetect Tarun Kanti DebBarma
2012-04-27 14:13 ` Tarun Kanti DebBarma
2012-04-27 14:13 ` [PATCH 3/8] gpio/omap: remove suspend_wakeup field from struct gpio_bank Tarun Kanti DebBarma
2012-04-27 14:13 ` Tarun Kanti DebBarma
2012-04-27 14:13 ` [PATCH 4/8] gpio/omap: remove saved_wakeup " Tarun Kanti DebBarma
2012-04-27 14:13 ` Tarun Kanti DebBarma
2012-04-27 14:13 ` [PATCH 5/8] gpio/omap: remove retrigger variable in gpio_irq_handler Tarun Kanti DebBarma
2012-04-27 14:13 ` Tarun Kanti DebBarma
2012-04-27 14:13 ` [PATCH 6/8] gpio/omap: remove suspend/resume callbacks Tarun Kanti DebBarma
2012-04-27 14:13 ` Tarun Kanti DebBarma
2012-04-27 14:13 ` [PATCH 7/8] gpio/omap: remove cpu_is_omapxxxx() checks from *_runtime_resume() Tarun Kanti DebBarma
2012-04-27 14:13 ` Tarun Kanti DebBarma
2012-05-03 11:15 ` Santosh Shilimkar
2012-05-03 11:15 ` Santosh Shilimkar
2012-04-27 14:13 ` [PATCH 8/8] gpio/omap: fix missing check in *_runtime_suspend() Tarun Kanti DebBarma
2012-04-27 14:13 ` Tarun Kanti DebBarma
2012-05-03 11:16 ` Santosh Shilimkar [this message]
2012-05-03 11:16 ` Santosh Shilimkar
2012-05-17 22:21 ` Kevin Hilman
2012-05-17 22:21 ` Kevin Hilman
2012-05-17 23:12 ` Tony Lindgren
2012-05-17 23:12 ` Tony Lindgren
2012-05-17 23:56 ` Kevin Hilman
2012-05-17 23:56 ` Kevin Hilman
2012-05-18 0:10 ` Tony Lindgren
2012-05-18 0:10 ` Tony Lindgren
2012-05-18 4:48 ` DebBarma, Tarun Kanti
2012-05-18 4:48 ` DebBarma, Tarun Kanti
2012-05-18 6:22 ` Shilimkar, Santosh
2012-05-18 6:22 ` Shilimkar, Santosh
2012-05-17 23:27 ` Grant Likely
2012-05-17 23:27 ` Grant Likely
2012-05-18 14:03 ` Kevin Hilman
2012-05-18 14:03 ` Kevin Hilman
2012-05-18 5:12 ` DebBarma, Tarun Kanti
2012-05-18 5:12 ` DebBarma, Tarun Kanti
2012-05-18 8:46 ` DebBarma, Tarun Kanti
2012-05-18 8:46 ` DebBarma, Tarun Kanti
2012-04-27 19:07 ` [PATCH 0/8] gpio/omap: remaining cleanups and fix Grant Likely
2012-04-27 19:07 ` Grant Likely
2012-04-27 21:57 ` Kevin Hilman
2012-04-27 21:57 ` Kevin Hilman
2012-04-27 22:05 ` Grant Likely
2012-04-27 22:05 ` Grant Likely
2012-05-03 11:17 ` Santosh Shilimkar
2012-05-03 11:17 ` Santosh Shilimkar
2012-05-10 6:38 ` Raja, Govindraj
2012-05-10 6:38 ` Raja, Govindraj
2012-05-10 22:13 ` Kevin Hilman
2012-05-10 22:13 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA268F2.5090301@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=b-cousson@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.