From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: dave@gnu.org
Cc: util-linux@vger.kernel.org
Subject: Re: mkfs.minix -3 creates incorrect and limited filesystem
Date: Thu, 03 May 2012 14:18:55 +0200 [thread overview]
Message-ID: <4FA277AF.20902@gmail.com> (raw)
In-Reply-To: <1335970369.2734.17.camel@offbook>
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
On 02.05.2012 16:52, Davidlohr Bueso wrote:
> On Wed, 2012-05-02 at 16:15 +0200, Vladimir 'φ-coder/phcoder' Serbinenko
> wrote:
>> --- util-linux-2.20.1/disk-utils/mkfs.minix.c 2011-10-11 15:23:46.000000000 +0200
>> +++ util-linux-2.20.1-mod/disk-utils/mkfs.minix.c 2012-05-02 13:56:09.993347189 +0200
>> @@ -487,7 +487,7 @@ static void setup_tables(void) {
>>
>> if (fs_version == 3) {
>> Super3.s_log_zone_size = 0;
>> - Super3.s_blocksize = BLOCKS;
>> + Super3.s_blocksize = MINIX_BLOCK_SIZE;
>> }
>> else {
>> Super.s_log_zone_size = 0;
>> @@ -773,7 +773,7 @@ int main(int argc, char ** argv) {
>> if (fs_version == 3)
>> magic = MINIX3_SUPER_MAGIC;
>>
>> - if (fs_version == 2) {
>> + else if (fs_version == 2) {
>> if (namelen == 14)
>> magic = MINIX2_SUPER_MAGIC;
>> else
>>
> Correct, however this is already fixed in new versions.
Ok, sorry for noise then, I've used Debian version. I've discovered this
and few other Linux and tools bugs when writing automatic tests for GRUB
fs drivers.
> Thanks,
> Davidlohr
>
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2012-05-03 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 14:15 mkfs.minix -3 creates incorrect and limited filesystem Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-02 14:52 ` Davidlohr Bueso
2012-05-03 12:18 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA277AF.20902@gmail.com \
--to=phcoder@gmail.com \
--cc=dave@gnu.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.