* mkfs.minix -3 creates incorrect and limited filesystem
@ 2012-05-02 14:15 Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-02 14:52 ` Davidlohr Bueso
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2012-05-02 14:15 UTC (permalink / raw)
To: util-linux
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
--- util-linux-2.20.1/disk-utils/mkfs.minix.c 2011-10-11 15:23:46.000000000 +0200
+++ util-linux-2.20.1-mod/disk-utils/mkfs.minix.c 2012-05-02 13:56:09.993347189 +0200
@@ -487,7 +487,7 @@ static void setup_tables(void) {
if (fs_version == 3) {
Super3.s_log_zone_size = 0;
- Super3.s_blocksize = BLOCKS;
+ Super3.s_blocksize = MINIX_BLOCK_SIZE;
}
else {
Super.s_log_zone_size = 0;
@@ -773,7 +773,7 @@ int main(int argc, char ** argv) {
if (fs_version == 3)
magic = MINIX3_SUPER_MAGIC;
- if (fs_version == 2) {
+ else if (fs_version == 2) {
if (namelen == 14)
magic = MINIX2_SUPER_MAGIC;
else
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mkfs.minix -3 creates incorrect and limited filesystem
2012-05-02 14:15 mkfs.minix -3 creates incorrect and limited filesystem Vladimir 'φ-coder/phcoder' Serbinenko
@ 2012-05-02 14:52 ` Davidlohr Bueso
2012-05-03 12:18 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 3+ messages in thread
From: Davidlohr Bueso @ 2012-05-02 14:52 UTC (permalink / raw)
To: Vladimir 'φ-coder/phcoder' Serbinenko; +Cc: util-linux
On Wed, 2012-05-02 at 16:15 +0200, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> --- util-linux-2.20.1/disk-utils/mkfs.minix.c 2011-10-11 15:23:46.000000000 +0200
> +++ util-linux-2.20.1-mod/disk-utils/mkfs.minix.c 2012-05-02 13:56:09.993347189 +0200
> @@ -487,7 +487,7 @@ static void setup_tables(void) {
>
> if (fs_version == 3) {
> Super3.s_log_zone_size = 0;
> - Super3.s_blocksize = BLOCKS;
> + Super3.s_blocksize = MINIX_BLOCK_SIZE;
> }
> else {
> Super.s_log_zone_size = 0;
> @@ -773,7 +773,7 @@ int main(int argc, char ** argv) {
> if (fs_version == 3)
> magic = MINIX3_SUPER_MAGIC;
>
> - if (fs_version == 2) {
> + else if (fs_version == 2) {
> if (namelen == 14)
> magic = MINIX2_SUPER_MAGIC;
> else
>
Correct, however this is already fixed in new versions.
Thanks,
Davidlohr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mkfs.minix -3 creates incorrect and limited filesystem
2012-05-02 14:52 ` Davidlohr Bueso
@ 2012-05-03 12:18 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 0 replies; 3+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2012-05-03 12:18 UTC (permalink / raw)
To: dave; +Cc: util-linux
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
On 02.05.2012 16:52, Davidlohr Bueso wrote:
> On Wed, 2012-05-02 at 16:15 +0200, Vladimir 'φ-coder/phcoder' Serbinenko
> wrote:
>> --- util-linux-2.20.1/disk-utils/mkfs.minix.c 2011-10-11 15:23:46.000000000 +0200
>> +++ util-linux-2.20.1-mod/disk-utils/mkfs.minix.c 2012-05-02 13:56:09.993347189 +0200
>> @@ -487,7 +487,7 @@ static void setup_tables(void) {
>>
>> if (fs_version == 3) {
>> Super3.s_log_zone_size = 0;
>> - Super3.s_blocksize = BLOCKS;
>> + Super3.s_blocksize = MINIX_BLOCK_SIZE;
>> }
>> else {
>> Super.s_log_zone_size = 0;
>> @@ -773,7 +773,7 @@ int main(int argc, char ** argv) {
>> if (fs_version == 3)
>> magic = MINIX3_SUPER_MAGIC;
>>
>> - if (fs_version == 2) {
>> + else if (fs_version == 2) {
>> if (namelen == 14)
>> magic = MINIX2_SUPER_MAGIC;
>> else
>>
> Correct, however this is already fixed in new versions.
Ok, sorry for noise then, I've used Debian version. I've discovered this
and few other Linux and tools bugs when writing automatic tests for GRUB
fs drivers.
> Thanks,
> Davidlohr
>
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-03 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-02 14:15 mkfs.minix -3 creates incorrect and limited filesystem Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-02 14:52 ` Davidlohr Bueso
2012-05-03 12:18 ` Vladimir 'φ-coder/phcoder' Serbinenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.