From: Edward Shishkin <edward.shishkin@gmail.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: reiserfs-devel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/reiserfs/journal.c: add missing brelse
Date: Thu, 03 May 2012 14:45:20 +0000 [thread overview]
Message-ID: <4FA29A00.3040303@gmail.com> (raw)
In-Reply-To: <1336054373-13293-1-git-send-email-Julia.Lawall@lip6.fr>
On 05/03/2012 04:12 PM, Julia Lawall wrote:
> From: Julia Lawall<Julia.Lawall@lip6.fr>
>
> Brelse is called to put bhjh on every way out of the function except this one.
Yes, thanks.
Acked-by: Edward Shishkin <edward.shishkin@gmail.com>
>
> Signed-off-by: Julia Lawall<Julia.Lawall@lip6.fr>
>
> ---
> fs/reiserfs/journal.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index b1a0857..1ef9cbc 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -2757,8 +2757,10 @@ int journal_init(struct super_block *sb, const char *j_dev_name,
> le32_to_cpu(jh->jh_journal.jp_journal_max_commit_age);
> journal->j_max_trans_age = JOURNAL_MAX_TRANS_AGE;
>
> - if (check_advise_trans_params(sb, journal) != 0)
> + if (check_advise_trans_params(sb, journal) != 0) {
> + brelse(bhjh);
> goto free_and_return;
> + }
> journal->j_default_max_commit_age = journal->j_max_commit_age;
>
> if (commit_max_age != 0) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Edward Shishkin <edward.shishkin@gmail.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: reiserfs-devel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/reiserfs/journal.c: add missing brelse
Date: Thu, 03 May 2012 16:45:20 +0200 [thread overview]
Message-ID: <4FA29A00.3040303@gmail.com> (raw)
In-Reply-To: <1336054373-13293-1-git-send-email-Julia.Lawall@lip6.fr>
On 05/03/2012 04:12 PM, Julia Lawall wrote:
> From: Julia Lawall<Julia.Lawall@lip6.fr>
>
> Brelse is called to put bhjh on every way out of the function except this one.
Yes, thanks.
Acked-by: Edward Shishkin <edward.shishkin@gmail.com>
>
> Signed-off-by: Julia Lawall<Julia.Lawall@lip6.fr>
>
> ---
> fs/reiserfs/journal.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index b1a0857..1ef9cbc 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -2757,8 +2757,10 @@ int journal_init(struct super_block *sb, const char *j_dev_name,
> le32_to_cpu(jh->jh_journal.jp_journal_max_commit_age);
> journal->j_max_trans_age = JOURNAL_MAX_TRANS_AGE;
>
> - if (check_advise_trans_params(sb, journal) != 0)
> + if (check_advise_trans_params(sb, journal) != 0) {
> + brelse(bhjh);
> goto free_and_return;
> + }
> journal->j_default_max_commit_age = journal->j_max_commit_age;
>
> if (commit_max_age != 0) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-05-03 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 14:12 [PATCH] fs/reiserfs/journal.c: add missing brelse Julia Lawall
2012-05-03 14:12 ` Julia Lawall
2012-05-03 14:45 ` Edward Shishkin [this message]
2012-05-03 14:45 ` Edward Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA29A00.3040303@gmail.com \
--to=edward.shishkin@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.