From: Paolo Bonzini <pbonzini@redhat.com>
To: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs
Date: Fri, 04 May 2012 10:06:25 +0200 [thread overview]
Message-ID: <4FA38E01.1050301@redhat.com> (raw)
In-Reply-To: <1335248944-10765-2-git-send-email-ronniesahlberg@gmail.com>
Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto:
> + itask->bs->total_sectors = rc16->returned_lba *
> + rc16->block_length / BDRV_SECTOR_SIZE ;
Ronnie, does this need to be "(rc16->returned_lba + 1) * ..."?
READ CAPACITY returns the highest valid LBA, not the size.
Please send a patch to fix this up if that's the case.
Paolo
next parent reply other threads:[~2012-05-04 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1335248944-10765-1-git-send-email-ronniesahlberg@gmail.com>
[not found] ` <1335248944-10765-2-git-send-email-ronniesahlberg@gmail.com>
2012-05-04 8:06 ` Paolo Bonzini [this message]
2012-05-04 8:20 ` [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA38E01.1050301@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.