From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"joerg.roedel-5C7GfCeVMHo@public.gmane.org"
<joerg.roedel-5C7GfCeVMHo@public.gmane.org>,
"thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org"
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB
Date: Fri, 04 May 2012 10:51:42 -0600 [thread overview]
Message-ID: <4FA4091E.60508@wwwdotorg.org> (raw)
In-Reply-To: <20120504.093358.2098007825524274078.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 05/04/2012 12:33 AM, Hiroshi Doyu wrote:
> Stephen Warren wrote at Thu, 3 May 2012 19:48:25 +0200:
>> On 05/03/2012 10:05 AM, Hiroshi DOYU wrote:
>>> Use "tegra_ahb_enable_smmu()" to inform AHB that SMMU is
>>> ready, instead of directly aceessing AHB registers.
...
>>> @@ -911,14 +899,16 @@ static int tegra_smmu_probe(struct platform_device *pdev)
>>
>>> + smmu->ahb = of_parse_phandle(pdev->dev.of_node, "ahb", 0);
>>
>> Hmm, "ahb" should probably be "nvidia,ahb".
>
> Does this mean the following in dts?
>
> ahb: ahb@6000c004 {
> compatible = "nvidia,tegra30-ahb";
> reg = <0x6000c004 0x14c>; /* AHB Arbitration + Gizmo Controller */
> };
>
> smmu: smmu@7000f000 {
> nvidia,ahb = &ahb;
> }; ^^^^^^^^^^
>
Yes.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB
Date: Fri, 04 May 2012 10:51:42 -0600 [thread overview]
Message-ID: <4FA4091E.60508@wwwdotorg.org> (raw)
In-Reply-To: <20120504.093358.2098007825524274078.hdoyu@nvidia.com>
On 05/04/2012 12:33 AM, Hiroshi Doyu wrote:
> Stephen Warren wrote at Thu, 3 May 2012 19:48:25 +0200:
>> On 05/03/2012 10:05 AM, Hiroshi DOYU wrote:
>>> Use "tegra_ahb_enable_smmu()" to inform AHB that SMMU is
>>> ready, instead of directly aceessing AHB registers.
...
>>> @@ -911,14 +899,16 @@ static int tegra_smmu_probe(struct platform_device *pdev)
>>
>>> + smmu->ahb = of_parse_phandle(pdev->dev.of_node, "ahb", 0);
>>
>> Hmm, "ahb" should probably be "nvidia,ahb".
>
> Does this mean the following in dts?
>
> ahb: ahb at 6000c004 {
> compatible = "nvidia,tegra30-ahb";
> reg = <0x6000c004 0x14c>; /* AHB Arbitration + Gizmo Controller */
> };
>
> smmu: smmu at 7000f000 {
> nvidia,ahb = &ahb;
> }; ^^^^^^^^^^
>
Yes.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Hiroshi Doyu <hdoyu@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"joerg.roedel@amd.com" <joerg.roedel@amd.com>,
"thierry.reding@avionic-design.de"
<thierry.reding@avionic-design.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB
Date: Fri, 04 May 2012 10:51:42 -0600 [thread overview]
Message-ID: <4FA4091E.60508@wwwdotorg.org> (raw)
In-Reply-To: <20120504.093358.2098007825524274078.hdoyu@nvidia.com>
On 05/04/2012 12:33 AM, Hiroshi Doyu wrote:
> Stephen Warren wrote at Thu, 3 May 2012 19:48:25 +0200:
>> On 05/03/2012 10:05 AM, Hiroshi DOYU wrote:
>>> Use "tegra_ahb_enable_smmu()" to inform AHB that SMMU is
>>> ready, instead of directly aceessing AHB registers.
...
>>> @@ -911,14 +899,16 @@ static int tegra_smmu_probe(struct platform_device *pdev)
>>
>>> + smmu->ahb = of_parse_phandle(pdev->dev.of_node, "ahb", 0);
>>
>> Hmm, "ahb" should probably be "nvidia,ahb".
>
> Does this mean the following in dts?
>
> ahb: ahb@6000c004 {
> compatible = "nvidia,tegra30-ahb";
> reg = <0x6000c004 0x14c>; /* AHB Arbitration + Gizmo Controller */
> };
>
> smmu: smmu@7000f000 {
> nvidia,ahb = &ahb;
> }; ^^^^^^^^^^
>
Yes.
next prev parent reply other threads:[~2012-05-04 16:51 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 16:05 [PATCHv3 1/4] ARM: tegra: Add Tegra AHB driver Hiroshi DOYU
2012-05-03 16:05 ` Hiroshi DOYU
2012-05-03 16:05 ` Hiroshi DOYU
2012-05-03 16:05 ` [PATCHv3 2/4] ARM: tegra: Add SMMU enabler in AHB Hiroshi DOYU
2012-05-03 16:05 ` Hiroshi DOYU
[not found] ` <1336061147-10245-2-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-03 17:43 ` Stephen Warren
2012-05-03 17:43 ` Stephen Warren
2012-05-03 17:43 ` Stephen Warren
2012-05-03 16:05 ` [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB Hiroshi DOYU
2012-05-03 16:05 ` Hiroshi DOYU
[not found] ` <1336061147-10245-3-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-03 17:48 ` Stephen Warren
2012-05-03 17:48 ` Stephen Warren
2012-05-03 17:48 ` Stephen Warren
2012-05-03 17:58 ` Stephen Warren
2012-05-03 17:58 ` Stephen Warren
[not found] ` <4FA2C746.5080000-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-04 6:36 ` Hiroshi Doyu
2012-05-04 6:36 ` Hiroshi Doyu
2012-05-04 6:36 ` Hiroshi Doyu
[not found] ` <4FA2C4E9.2080509-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-03 17:54 ` Hiroshi Doyu
2012-05-03 17:54 ` Hiroshi Doyu
2012-05-03 17:54 ` Hiroshi Doyu
2012-05-04 6:33 ` Hiroshi Doyu
2012-05-04 6:33 ` Hiroshi Doyu
2012-05-04 6:33 ` Hiroshi Doyu
[not found] ` <20120504.093358.2098007825524274078.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-04 16:51 ` Stephen Warren [this message]
2012-05-04 16:51 ` Stephen Warren
2012-05-04 16:51 ` Stephen Warren
[not found] ` <1336061147-10245-1-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-03 16:05 ` [PATCHv3 4/4] ARM: dt: tegra: Add device tree support for AHB Hiroshi DOYU
2012-05-03 16:05 ` Hiroshi DOYU
2012-05-03 16:05 ` Hiroshi DOYU
[not found] ` <1336061147-10245-4-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-03 17:50 ` Stephen Warren
2012-05-03 17:50 ` Stephen Warren
2012-05-03 17:50 ` Stephen Warren
2012-05-03 17:41 ` [PATCHv3 1/4] ARM: tegra: Add Tegra AHB driver Stephen Warren
2012-05-03 17:41 ` Stephen Warren
2012-05-03 17:41 ` Stephen Warren
[not found] ` <4FA2C34F.5060406-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-04 6:17 ` Hiroshi Doyu
2012-05-04 6:17 ` Hiroshi Doyu
2012-05-04 6:17 ` Hiroshi Doyu
[not found] ` <20120504.091736.839941449020176796.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-04 16:48 ` Stephen Warren
2012-05-04 16:48 ` Stephen Warren
2012-05-04 16:48 ` Stephen Warren
[not found] ` <4FA40878.7070709-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-07 6:06 ` Hiroshi Doyu
2012-05-07 6:06 ` Hiroshi Doyu
2012-05-07 6:06 ` Hiroshi Doyu
2012-05-03 17:59 ` Stephen Warren
2012-05-03 17:59 ` Stephen Warren
2012-05-03 17:59 ` Stephen Warren
[not found] ` <4FA2C785.2080703-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-04 6:40 ` Hiroshi Doyu
2012-05-04 6:40 ` Hiroshi Doyu
2012-05-04 6:40 ` Hiroshi Doyu
2012-05-04 6:40 ` Hiroshi Doyu
[not found] ` <20120504.094030.1816474762821188264.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-04 8:40 ` Arnd Bergmann
2012-05-04 8:40 ` Arnd Bergmann
2012-05-04 8:40 ` Arnd Bergmann
2012-05-04 16:50 ` Stephen Warren
2012-05-04 16:50 ` Stephen Warren
2012-05-04 16:50 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA4091E.60508@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=joerg.roedel-5C7GfCeVMHo@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.