* [PATCH] ath6kl_sdio: Fix the EAPOL out of order issue @ 2012-05-02 9:25 Vivek Natarajan 2012-05-03 13:09 ` Lee, Youngsin 2012-05-04 18:50 ` Kalle Valo 0 siblings, 2 replies; 3+ messages in thread From: Vivek Natarajan @ 2012-05-02 9:25 UTC (permalink / raw) To: kvalo; +Cc: linux-wireless, ath6kl-devel Send the EAPOL and management frames in the same AC_VO queue. The issue happens when the AP supports QOS, the management frames are sent to AC_VO queue and EAP frame goes to AC_BE queue. Even though the EAP frame is queued before the DEAUTH management frame, as they are queued on different h/w queues, order of delivery between these frames cannot be controlled. This fixes the connection failure seen in P2P case. Signed-off-by: Vivek Natarajan <nataraja@qca.qualcomm.com> --- drivers/net/wireless/ath/ath6kl/wmi.c | 7 +++++++ drivers/net/wireless/ath/ath6kl/wmi.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index 102477d..ee8ec23 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -290,6 +290,13 @@ int ath6kl_wmi_implicit_create_pstream(struct wmi *wmi, u8 if_idx, layer2_priority); } else usr_pri = layer2_priority & 0x7; + + /* + * Queue the EAPOL frames in the same WMM_AC_VO queue + * as that of management frames. + */ + if (skb->protocol == cpu_to_be16(ETH_P_PAE)) + usr_pri = WMI_VOICE_USER_PRIORITY; } /* diff --git a/drivers/net/wireless/ath/ath6kl/wmi.h b/drivers/net/wireless/ath/ath6kl/wmi.h index 9966140..9076bec 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.h +++ b/drivers/net/wireless/ath/ath6kl/wmi.h @@ -106,6 +106,8 @@ struct wmi_data_sync_bufs { #define WMM_AC_VI 2 /* video */ #define WMM_AC_VO 3 /* voice */ +#define WMI_VOICE_USER_PRIORITY 0x7 + struct wmi { u16 stream_exist_for_ac[WMM_NUM_AC]; u8 fat_pipe_exist; -- 1.7.10 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] ath6kl_sdio: Fix the EAPOL out of order issue 2012-05-02 9:25 [PATCH] ath6kl_sdio: Fix the EAPOL out of order issue Vivek Natarajan @ 2012-05-03 13:09 ` Lee, Youngsin 2012-05-04 18:50 ` Kalle Valo 1 sibling, 0 replies; 3+ messages in thread From: Lee, Youngsin @ 2012-05-03 13:09 UTC (permalink / raw) To: Natarajan, Vivekanandan, Valo, Kalle, Kwak, Steven, Kim, Kyle, Byun, Matt, Lee, Ryan (QCA KR) Cc: linux-wireless@vger.kernel.org, ath6kl-devel, Kim, Sunny, Huang, Karen (Karen Huang_QCA TW), Lee, HG, Kim, Cj, Kim, Taek-Soo (Henry) + More folks. Steven, Please also check this patch for CR346620. Thanks a lot, Youngsin. -----Original Message----- From: Natarajan, Vivekanandan Sent: Wednesday, May 02, 2012 6:25 PM To: Valo, Kalle Cc: linux-wireless@vger.kernel.org; ath6kl-devel Subject: [PATCH] ath6kl_sdio: Fix the EAPOL out of order issue Send the EAPOL and management frames in the same AC_VO queue. The issue happens when the AP supports QOS, the management frames are sent to AC_VO queue and EAP frame goes to AC_BE queue. Even though the EAP frame is queued before the DEAUTH management frame, as they are queued on different h/w queues, order of delivery between these frames cannot be controlled. This fixes the connection failure seen in P2P case. Signed-off-by: Vivek Natarajan <nataraja@qca.qualcomm.com> --- drivers/net/wireless/ath/ath6kl/wmi.c | 7 +++++++ drivers/net/wireless/ath/ath6kl/wmi.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index 102477d..ee8ec23 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -290,6 +290,13 @@ int ath6kl_wmi_implicit_create_pstream(struct wmi *wmi, u8 if_idx, layer2_priority); } else usr_pri = layer2_priority & 0x7; + + /* + * Queue the EAPOL frames in the same WMM_AC_VO queue + * as that of management frames. + */ + if (skb->protocol == cpu_to_be16(ETH_P_PAE)) + usr_pri = WMI_VOICE_USER_PRIORITY; } /* diff --git a/drivers/net/wireless/ath/ath6kl/wmi.h b/drivers/net/wireless/ath/ath6kl/wmi.h index 9966140..9076bec 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.h +++ b/drivers/net/wireless/ath/ath6kl/wmi.h @@ -106,6 +106,8 @@ struct wmi_data_sync_bufs { #define WMM_AC_VI 2 /* video */ #define WMM_AC_VO 3 /* voice */ +#define WMI_VOICE_USER_PRIORITY 0x7 + struct wmi { u16 stream_exist_for_ac[WMM_NUM_AC]; u8 fat_pipe_exist; -- 1.7.10 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ath6kl_sdio: Fix the EAPOL out of order issue 2012-05-02 9:25 [PATCH] ath6kl_sdio: Fix the EAPOL out of order issue Vivek Natarajan 2012-05-03 13:09 ` Lee, Youngsin @ 2012-05-04 18:50 ` Kalle Valo 1 sibling, 0 replies; 3+ messages in thread From: Kalle Valo @ 2012-05-04 18:50 UTC (permalink / raw) To: Vivek Natarajan; +Cc: linux-wireless, ath6kl-devel On 05/02/2012 12:25 PM, Vivek Natarajan wrote: > Send the EAPOL and management frames in the same AC_VO queue. The issue > happens when the AP supports QOS, the management frames are sent to AC_VO > queue and EAP frame goes to AC_BE queue. Even though the EAP frame is > queued before the DEAUTH management frame, as they are queued on different > h/w queues, order of delivery between these frames cannot be controlled. > > This fixes the connection failure seen in P2P case. > > Signed-off-by: Vivek Natarajan <nataraja@qca.qualcomm.com> Thanks, applied. Kalle ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-04 18:51 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-05-02 9:25 [PATCH] ath6kl_sdio: Fix the EAPOL out of order issue Vivek Natarajan 2012-05-03 13:09 ` Lee, Youngsin 2012-05-04 18:50 ` Kalle Valo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.