Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 05/05/2012 10:34 AM, Hans Verkuil wrote:
> On Sat May 5 2012 09:43:01 Hans de Goede wrote:
>> Hi,
>>
>> I'm slowly working my way though this series today (both review, as well
>> as some tweaks and testing).
>
> Thanks for that!
>
> One note: I initialized the controls in sd_init. That's wrong, it should be
> sd_config. sd_init is also called on resume, so that would initialize the
> controls twice.

You cannot move the initializing of the controls to sd_config, since in many
cases the sensor probing is done in sd_init, and we need to know the sensor
type to init the controls. I suggest that instead you give the sd_init
function a resume parameter and only init the controls if the resume parameter
is false.

> I'm working on this as well today, together with finishing the stv06xx and
> mars conversion.

Cool!

Regards,

Hans