[PATCH 0/7][KERNEL] add usb and mei features

[PATCH 0/7][KERNEL] add usb and mei features

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

This adds a few new features, one each for usb/[xeou]hci-hcd and
another for amt/mei, and refactors existing config options into a new
usb/base, which are then used in crownbay.

v2: after suggestions from Bruce and Darren of a preference for a more
flattened feature tree structure, moved all the features into a single
usb/ feature dir.  I did however retain the common 'base' feature
because inlining that in each feature would mean that the same common
set would be repeated in multiple config fragments if more than one usb
feature was included in a BSP.

v3: include base.scc into each *hcd fragment again.

Please pull into linux-yocto-3.2.

Thanks,

Tom

The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
  Yang Shi (1):
        meta: Clean up BSPs kernel config

are available in the git repository at:

  git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
  http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features

Tom Zanussi (7):
  meta: add usb/base feature
  meta: add usb/xhci-hcd feature
  meta: add usb/ehci-hcd feature
  meta: add usb/ohci-hcd feature
  meta: add usb/uhci-hcd feature
  meta/crownbay: use usb features
  meta: add mei feature

 meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    6 ------
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    4 ++++
 meta/cfg/kernel-cache/features/amt/mei/mei.cfg  |    3 +++
 meta/cfg/kernel-cache/features/amt/mei/mei.scc  |    4 ++++
 meta/cfg/kernel-cache/features/usb/base.cfg     |    3 +++
 meta/cfg/kernel-cache/features/usb/base.scc     |    4 ++++
 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc |    6 ++++++
 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc |    6 ++++++
 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc |    6 ++++++
 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc |    6 ++++++
 14 files changed, 46 insertions(+), 6 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/base.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/base.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc

[PATCH 1/7][KERNEL] meta: add usb/base feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add a feature to enable 'base' support for USB.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/features/usb/base.cfg |    3 +++
 meta/cfg/kernel-cache/features/usb/base.scc |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/base.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/base.scc

diff --git a/meta/cfg/kernel-cache/features/usb/base.cfg b/meta/cfg/kernel-cache/features/usb/base.cfg
new file mode 100644
index 0000000..dec6a47
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/base.cfg
@@ -0,0 +1,3 @@
+CONFIG_USB_SUPPORT=y
+CONFIG_USB=y
+
diff --git a/meta/cfg/kernel-cache/features/usb/base.scc b/meta/cfg/kernel-cache/features/usb/base.scc
new file mode 100644
index 0000000..3c93475
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/base.scc
@@ -0,0 +1,4 @@
+define KFEATURE_DESCRIPTION "Enable core options for USB support"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware base.cfg
-- 
1.7.0.4

[PATCH 2/7][KERNEL] meta: add usb/xhci-hcd feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add an 'xhci-hcd' feature that turns on the kernel options required to
support xhci (USB 3.0).

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc

diff --git a/meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg b/meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
new file mode 100644
index 0000000..ae4294b
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
@@ -0,0 +1 @@
+CONFIG_USB_XHCI_HCD=y
diff --git a/meta/cfg/kernel-cache/features/usb/xhci-hcd.scc b/meta/cfg/kernel-cache/features/usb/xhci-hcd.scc
new file mode 100644
index 0000000..f559ce7
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/xhci-hcd.scc
@@ -0,0 +1,6 @@
+define KFEATURE_DESCRIPTION "Enable options for xhci (USB 3.0)"
+define KFEATURE_COMPATIBILITY board
+
+include base.scc
+
+kconf hardware xhci-hcd.cfg
-- 
1.7.0.4

[PATCH 3/7][KERNEL] meta: add usb/ehci-hcd feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add an 'ehci-hcd' feature that turns on the kernel options required to
support ehci (USB 2.0).

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc

diff --git a/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg b/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
new file mode 100644
index 0000000..7322dc2
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
@@ -0,0 +1 @@
+CONFIG_USB_EHCI_HCD=y
diff --git a/meta/cfg/kernel-cache/features/usb/ehci-hcd.scc b/meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
new file mode 100644
index 0000000..ec2b06c
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
@@ -0,0 +1,6 @@
+define KFEATURE_DESCRIPTION "Enable options for ehci (USB 2.0)"
+define KFEATURE_COMPATIBILITY board
+
+include base.scc
+
+kconf hardware ehci-hcd.cfg
-- 
1.7.0.4

[PATCH 4/7][KERNEL] meta: add usb/ohci-hcd feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add an 'ohci-hcd' feature that turns on the kernel options required to
support ohci (USB 1.x).

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc

diff --git a/meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg b/meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
new file mode 100644
index 0000000..59f6d5f
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
@@ -0,0 +1 @@
+CONFIG_USB_OHCI_HCD=y
diff --git a/meta/cfg/kernel-cache/features/usb/ohci-hcd.scc b/meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
new file mode 100644
index 0000000..cadcbdf
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
@@ -0,0 +1,6 @@
+define KFEATURE_DESCRIPTION "Enable options for ohci (USB 1.x)"
+define KFEATURE_COMPATIBILITY board
+
+include base.scc
+
+kconf hardware ohci-hcd.cfg
-- 
1.7.0.4

[PATCH 5/7][KERNEL] meta: add usb/uhci-hcd feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add a 'uhci-hcd' feature that turns on the kernel options required to
support uhci (USB 1.x).

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc

diff --git a/meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg b/meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
new file mode 100644
index 0000000..9c9d8c2
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
@@ -0,0 +1 @@
+CONFIG_USB_UHCI_HCD=y
diff --git a/meta/cfg/kernel-cache/features/usb/uhci-hcd.scc b/meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
new file mode 100644
index 0000000..aaf3c2b
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
@@ -0,0 +1,6 @@
+define KFEATURE_DESCRIPTION "Enable options for uhci (USB 1.x)"
+define KFEATURE_COMPATIBILITY board
+
+include base.scc
+
+kconf hardware uhci-hcd.cfg
-- 
1.7.0.4

[PATCH 6/7][KERNEL] meta/crownbay: use usb features

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Use the available usb features and remove the associated config
settings from the top-level crownbay feature.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    6 ------
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    4 ++++
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
index b101419..7d1362b 100644
--- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
+++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
@@ -10,17 +10,11 @@ CONFIG_ATA_SFF=y
 CONFIG_PCI=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
-CONFIG_USB_SUPPORT=y
-CONFIG_USB=y
-CONFIG_USB_ARCH_HAS_EHCI=y
 CONFIG_R8169=y
 CONFIG_PATA_SCH=y
 CONFIG_MMC_SDHCI_PCI=y
-CONFIG_USB_EHCI_HCD=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_NET=y
-CONFIG_USB_UHCI_HCD=y
-CONFIG_USB_OHCI_HCD=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_SG=y
 CONFIG_SOUND=y
diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
index 0ff6ac6..d4299a9 100644
--- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
+++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
@@ -16,3 +16,7 @@ include features/logbuf/size-normal.scc
 
 include features/latencytop/latencytop.scc
 include features/profiling/profiling.scc
+
+include features/usb/ehci-hcd.scc
+include features/usb/ohci-hcd.scc
+include features/usb/uhci-hcd.scc
-- 
1.7.0.4

[PATCH 7/7][KERNEL] meta: add mei feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add an 'mei' feature that turns on the kernel options required to
support the Intel Management Engine Interface.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/features/amt/mei/mei.cfg |    3 +++
 meta/cfg/kernel-cache/features/amt/mei/mei.scc |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc

diff --git a/meta/cfg/kernel-cache/features/amt/mei/mei.cfg b/meta/cfg/kernel-cache/features/amt/mei/mei.cfg
new file mode 100644
index 0000000..c1c2ace
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/amt/mei/mei.cfg
@@ -0,0 +1,3 @@
+CONFIG_STAGING=y
+CONFIG_WATCHDOG_CORE=y
+CONFIG_INTEL_MEI=y
diff --git a/meta/cfg/kernel-cache/features/amt/mei/mei.scc b/meta/cfg/kernel-cache/features/amt/mei/mei.scc
new file mode 100644
index 0000000..c506a04
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/amt/mei/mei.scc
@@ -0,0 +1,4 @@
+define KFEATURE_DESCRIPTION "Enable options for the Intel Management Engine Interface"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware mei.cfg
-- 
1.7.0.4

Re: [PATCH 0/7][KERNEL] add usb and mei features

[Bruce Ashfield]

On 12-05-06 12:53 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi<tom.zanussi@intel.com>
>
> This adds a few new features, one each for usb/[xeou]hci-hcd and
> another for amt/mei, and refactors existing config options into a new
> usb/base, which are then used in crownbay.
>
> v2: after suggestions from Bruce and Darren of a preference for a more
> flattened feature tree structure, moved all the features into a single
> usb/ feature dir.  I did however retain the common 'base' feature
> because inlining that in each feature would mean that the same common
> set would be repeated in multiple config fragments if more than one usb
> feature was included in a BSP.
>
> v3: include base.scc into each *hcd fragment again.
>
> Please pull into linux-yocto-3.2.


Looks good. I reset my old merge and this is now in place. I'll push
the trees in the morning.

Cheers,

Bruce

>
> Thanks,
>
> Tom
>
> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
>    Yang Shi (1):
>          meta: Clean up BSPs kernel config
>
> are available in the git repository at:
>
>    git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
>    http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
>
> Tom Zanussi (7):
>    meta: add usb/base feature
>    meta: add usb/xhci-hcd feature
>    meta: add usb/ehci-hcd feature
>    meta: add usb/ohci-hcd feature
>    meta: add usb/uhci-hcd feature
>    meta/crownbay: use usb features
>    meta: add mei feature
>
>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    6 ------
>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    4 ++++
>   meta/cfg/kernel-cache/features/amt/mei/mei.cfg  |    3 +++
>   meta/cfg/kernel-cache/features/amt/mei/mei.scc  |    4 ++++
>   meta/cfg/kernel-cache/features/usb/base.cfg     |    3 +++
>   meta/cfg/kernel-cache/features/usb/base.scc     |    4 ++++
>   meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
>   meta/cfg/kernel-cache/features/usb/ehci-hcd.scc |    6 ++++++
>   meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg |    1 +
>   meta/cfg/kernel-cache/features/usb/ohci-hcd.scc |    6 ++++++
>   meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg |    1 +
>   meta/cfg/kernel-cache/features/usb/uhci-hcd.scc |    6 ++++++
>   meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg |    1 +
>   meta/cfg/kernel-cache/features/usb/xhci-hcd.scc |    6 ++++++
>   14 files changed, 46 insertions(+), 6 deletions(-)
>   create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
>   create mode 100644 meta/cfg/kernel-cache/features/usb/base.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/usb/base.scc
>   create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
>   create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
>   create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
>   create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
>   create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc
>

Re: [PATCH 0/7][KERNEL] add usb and mei features

[Bruce Ashfield]

On 12-05-06 11:48 PM, Bruce Ashfield wrote:
> On 12-05-06 12:53 PM, tom.zanussi@intel.com wrote:
>> From: Tom Zanussi<tom.zanussi@intel.com>
>>
>> This adds a few new features, one each for usb/[xeou]hci-hcd and
>> another for amt/mei, and refactors existing config options into a new
>> usb/base, which are then used in crownbay.
>>
>> v2: after suggestions from Bruce and Darren of a preference for a more
>> flattened feature tree structure, moved all the features into a single
>> usb/ feature dir. I did however retain the common 'base' feature
>> because inlining that in each feature would mean that the same common
>> set would be repeated in multiple config fragments if more than one usb
>> feature was included in a BSP.
>>
>> v3: include base.scc into each *hcd fragment again.
>>
>> Please pull into linux-yocto-3.2.
>
>
> Looks good. I reset my old merge and this is now in place. I'll push
> the trees in the morning.


pushed. all my builds worked over night. I'll have a pull request
out for SRCREV bump shortly, but you don't need that :)

Cheers,

Bruce

>
> Cheers,
>
> Bruce
>
>>
>> Thanks,
>>
>> Tom
>>
>> The following changes since commit
>> b14a08f5c7b469a5077c10942f4e1aec171faa9d:
>> Yang Shi (1):
>> meta: Clean up BSPs kernel config
>>
>> are available in the git repository at:
>>
>> git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git
>> tzanussi/xhcd-mei-features
>> http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
>>
>> Tom Zanussi (7):
>> meta: add usb/base feature
>> meta: add usb/xhci-hcd feature
>> meta: add usb/ehci-hcd feature
>> meta: add usb/ohci-hcd feature
>> meta: add usb/uhci-hcd feature
>> meta/crownbay: use usb features
>> meta: add mei feature
>>
>> meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg | 6 ------
>> meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc | 4 ++++
>> meta/cfg/kernel-cache/features/amt/mei/mei.cfg | 3 +++
>> meta/cfg/kernel-cache/features/amt/mei/mei.scc | 4 ++++
>> meta/cfg/kernel-cache/features/usb/base.cfg | 3 +++
>> meta/cfg/kernel-cache/features/usb/base.scc | 4 ++++
>> meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg | 1 +
>> meta/cfg/kernel-cache/features/usb/ehci-hcd.scc | 6 ++++++
>> meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg | 1 +
>> meta/cfg/kernel-cache/features/usb/ohci-hcd.scc | 6 ++++++
>> meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg | 1 +
>> meta/cfg/kernel-cache/features/usb/uhci-hcd.scc | 6 ++++++
>> meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg | 1 +
>> meta/cfg/kernel-cache/features/usb/xhci-hcd.scc | 6 ++++++
>> 14 files changed, 46 insertions(+), 6 deletions(-)
>> create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
>> create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
>> create mode 100644 meta/cfg/kernel-cache/features/usb/base.cfg
>> create mode 100644 meta/cfg/kernel-cache/features/usb/base.scc
>> create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
>> create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
>> create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
>> create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
>> create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
>> create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
>> create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
>> create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc
>>
>
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

[PATCH 0/7][KERNEL] add usb and mei features

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

This adds a few new features, one each for usb/[xeou]hci-hcd and
another for amt/mei, and refactors existing config options into a new
usb/base, which are then used in crownbay.

v2: after suggestions from Bruce and Darren of a preference for a more
flattened feature tree structure, moved all the features into a single
usb/ feature dir.  I did however retain the common 'base' feature
because inlining that in each feature would mean that the same common
set would be repeated in multiple config fragments if more than one usb
feature was included in a BSP.

Please pull into linux-yocto-3.2.

Thanks,

Tom

The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
  Yang Shi (1):
        meta: Clean up BSPs kernel config

are available in the git repository at:

  git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
  http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features

Tom Zanussi (7):
  meta: add usb/base feature
  meta: add usb/xhci-hcd feature
  meta: add usb/ehci-hcd feature
  meta: add usb/ohci-hcd feature
  meta: add usb/uhci-hcd feature
  meta/crownbay: use usb features
  meta: add mei feature

 meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    6 ------
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    5 +++++
 meta/cfg/kernel-cache/features/amt/mei/mei.cfg  |    3 +++
 meta/cfg/kernel-cache/features/amt/mei/mei.scc  |    4 ++++
 meta/cfg/kernel-cache/features/usb/base.cfg     |    3 +++
 meta/cfg/kernel-cache/features/usb/base.scc     |    4 ++++
 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc |    4 ++++
 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc |    4 ++++
 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc |    4 ++++
 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg |    1 +
 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc |    4 ++++
 14 files changed, 39 insertions(+), 6 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/base.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/base.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc

Re: [PATCH 0/7][KERNEL] add usb and mei features

[Darren Hart]

On 05/04/2012 03:07 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> This adds a few new features, one each for usb/[xeou]hci-hcd and
> another for amt/mei, and refactors existing config options into a new
> usb/base, which are then used in crownbay.
> 
> v2: after suggestions from Bruce and Darren of a preference for a more
> flattened feature tree structure, moved all the features into a single
> usb/ feature dir.  I did however retain the common 'base' feature
> because inlining that in each feature would mean that the same common
> set would be repeated in multiple config fragments if more than one usb
> feature was included in a BSP.

As things stand now, a BSP would have to include both the base and the
*hcd right?

include usb/base.scc
include ehci-hcd.scc

Seems to me we should manage the dependencies wherever we can. When I've
created fragments I've been including their requirements as well to make
it easier on the integrator. Since you've put the dependencies in their
own fragment, why not include the fragment in the *hcd.scc files?

+++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
@@ -0,0 +1,4 @@
+define KFEATURE_DESCRIPTION "Enable options for ehci (USB 2.0)"
+define KFEATURE_COMPATIBILITY board
+
+ include base.scc
+kconf hardware ehci-hcd.cfg

Now if someone need only include the one line for the *hcd. Since it's
only a total of 3 lines of CONFIG settings we're packaging up here, it
seems to me we should be able to enable it with only 1 line of meta data.

--
Darren

> 
> Please pull into linux-yocto-3.2.
> 
> Thanks,
> 
> Tom
> 
> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
>   Yang Shi (1):
>         meta: Clean up BSPs kernel config
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
>   http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
> 
> Tom Zanussi (7):
>   meta: add usb/base feature
>   meta: add usb/xhci-hcd feature
>   meta: add usb/ehci-hcd feature
>   meta: add usb/ohci-hcd feature
>   meta: add usb/uhci-hcd feature
>   meta/crownbay: use usb features
>   meta: add mei feature
> 
>  meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    6 ------
>  meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    5 +++++
>  meta/cfg/kernel-cache/features/amt/mei/mei.cfg  |    3 +++
>  meta/cfg/kernel-cache/features/amt/mei/mei.scc  |    4 ++++
>  meta/cfg/kernel-cache/features/usb/base.cfg     |    3 +++
>  meta/cfg/kernel-cache/features/usb/base.scc     |    4 ++++
>  meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
>  meta/cfg/kernel-cache/features/usb/ehci-hcd.scc |    4 ++++
>  meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg |    1 +
>  meta/cfg/kernel-cache/features/usb/ohci-hcd.scc |    4 ++++
>  meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg |    1 +
>  meta/cfg/kernel-cache/features/usb/uhci-hcd.scc |    4 ++++
>  meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg |    1 +
>  meta/cfg/kernel-cache/features/usb/xhci-hcd.scc |    4 ++++
>  14 files changed, 39 insertions(+), 6 deletions(-)
>  create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
>  create mode 100644 meta/cfg/kernel-cache/features/usb/base.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/usb/base.scc
>  create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
>  create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
>  create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
>  create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 0/7][KERNEL] add usb and mei features

[Tom Zanussi]

On Fri, 2012-05-04 at 16:04 -0700, Darren Hart wrote:
> 
> On 05/04/2012 03:07 PM, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > This adds a few new features, one each for usb/[xeou]hci-hcd and
> > another for amt/mei, and refactors existing config options into a new
> > usb/base, which are then used in crownbay.
> > 
> > v2: after suggestions from Bruce and Darren of a preference for a more
> > flattened feature tree structure, moved all the features into a single
> > usb/ feature dir.  I did however retain the common 'base' feature
> > because inlining that in each feature would mean that the same common
> > set would be repeated in multiple config fragments if more than one usb
> > feature was included in a BSP.
> 
> As things stand now, a BSP would have to include both the base and the
> *hcd right?
> 
> include usb/base.scc
> include ehci-hcd.scc
> 
> Seems to me we should manage the dependencies wherever we can. When I've
> created fragments I've been including their requirements as well to make
> it easier on the integrator. Since you've put the dependencies in their
> own fragment, why not include the fragment in the *hcd.scc files?
> 
> +++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
> @@ -0,0 +1,4 @@
> +define KFEATURE_DESCRIPTION "Enable options for ehci (USB 2.0)"
> +define KFEATURE_COMPATIBILITY board
> +
> + include base.scc
> +kconf hardware ehci-hcd.cfg
> 
> Now if someone need only include the one line for the *hcd. Since it's
> only a total of 3 lines of CONFIG settings we're packaging up here, it
> seems to me we should be able to enable it with only 1 line of meta data.
> 

Yes, this is exactly what I did in the previous patchset.

The problem is that if we do this for each of the *hcd fragments, we end
up with the options in base.cfg repeated for each, which may or may not
produce a config-check warning.

To avoid that, we need to be able to add the base.cfg items once
followed by the individual *hcd items as I did with the crownbay
example:

+include features/usb/base.scc
+include features/usb/ehci-hcd.scc
+include features/usb/ohci-hcd.scc
+include features/usb/uhci-hcd.scc


Tom

> --
> Darren
> 
> > 
> > Please pull into linux-yocto-3.2.
> > 
> > Thanks,
> > 
> > Tom
> > 
> > The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
> >   Yang Shi (1):
> >         meta: Clean up BSPs kernel config
> > 
> > are available in the git repository at:
> > 
> >   git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
> >   http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
> > 
> > Tom Zanussi (7):
> >   meta: add usb/base feature
> >   meta: add usb/xhci-hcd feature
> >   meta: add usb/ehci-hcd feature
> >   meta: add usb/ohci-hcd feature
> >   meta: add usb/uhci-hcd feature
> >   meta/crownbay: use usb features
> >   meta: add mei feature
> > 
> >  meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    6 ------
> >  meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    5 +++++
> >  meta/cfg/kernel-cache/features/amt/mei/mei.cfg  |    3 +++
> >  meta/cfg/kernel-cache/features/amt/mei/mei.scc  |    4 ++++
> >  meta/cfg/kernel-cache/features/usb/base.cfg     |    3 +++
> >  meta/cfg/kernel-cache/features/usb/base.scc     |    4 ++++
> >  meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
> >  meta/cfg/kernel-cache/features/usb/ehci-hcd.scc |    4 ++++
> >  meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg |    1 +
> >  meta/cfg/kernel-cache/features/usb/ohci-hcd.scc |    4 ++++
> >  meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg |    1 +
> >  meta/cfg/kernel-cache/features/usb/uhci-hcd.scc |    4 ++++
> >  meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg |    1 +
> >  meta/cfg/kernel-cache/features/usb/xhci-hcd.scc |    4 ++++
> >  14 files changed, 39 insertions(+), 6 deletions(-)
> >  create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
> >  create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/base.cfg
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/base.scc
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
> >  create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc
> > 
> 

Re: [PATCH 0/7][KERNEL] add usb and mei features

[Darren Hart]

On 05/04/2012 05:06 PM, Tom Zanussi wrote:
> On Fri, 2012-05-04 at 16:04 -0700, Darren Hart wrote:
>>
>> On 05/04/2012 03:07 PM, tom.zanussi@intel.com wrote:
>>> From: Tom Zanussi <tom.zanussi@intel.com>
>>>
>>> This adds a few new features, one each for usb/[xeou]hci-hcd and
>>> another for amt/mei, and refactors existing config options into a new
>>> usb/base, which are then used in crownbay.
>>>
>>> v2: after suggestions from Bruce and Darren of a preference for a more
>>> flattened feature tree structure, moved all the features into a single
>>> usb/ feature dir.  I did however retain the common 'base' feature
>>> because inlining that in each feature would mean that the same common
>>> set would be repeated in multiple config fragments if more than one usb
>>> feature was included in a BSP.
>>
>> As things stand now, a BSP would have to include both the base and the
>> *hcd right?
>>
>> include usb/base.scc
>> include ehci-hcd.scc
>>
>> Seems to me we should manage the dependencies wherever we can. When I've
>> created fragments I've been including their requirements as well to make
>> it easier on the integrator. Since you've put the dependencies in their
>> own fragment, why not include the fragment in the *hcd.scc files?
>>
>> +++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
>> @@ -0,0 +1,4 @@
>> +define KFEATURE_DESCRIPTION "Enable options for ehci (USB 2.0)"
>> +define KFEATURE_COMPATIBILITY board
>> +
>> + include base.scc
>> +kconf hardware ehci-hcd.cfg
>>
>> Now if someone need only include the one line for the *hcd. Since it's
>> only a total of 3 lines of CONFIG settings we're packaging up here, it
>> seems to me we should be able to enable it with only 1 line of meta data.
>>
> 
> Yes, this is exactly what I did in the previous patchset.
> 
> The problem is that if we do this for each of the *hcd fragments, we end
> up with the options in base.cfg repeated for each, which may or may not
> produce a config-check warning.

"May or may not"? If our tools complain about setting a config to the
same value, I would prefer to address that in the tools.

Bruce, any comment on the intended behavior of the tools?

--
Darren

> 
> To avoid that, we need to be able to add the base.cfg items once
> followed by the individual *hcd items as I did with the crownbay
> example:
> 
> +include features/usb/base.scc
> +include features/usb/ehci-hcd.scc
> +include features/usb/ohci-hcd.scc
> +include features/usb/uhci-hcd.scc
> 
> 
> Tom
> 
>> --
>> Darren
>>
>>>
>>> Please pull into linux-yocto-3.2.
>>>
>>> Thanks,
>>>
>>> Tom
>>>
>>> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
>>>   Yang Shi (1):
>>>         meta: Clean up BSPs kernel config
>>>
>>> are available in the git repository at:
>>>
>>>   git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
>>>   http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
>>>
>>> Tom Zanussi (7):
>>>   meta: add usb/base feature
>>>   meta: add usb/xhci-hcd feature
>>>   meta: add usb/ehci-hcd feature
>>>   meta: add usb/ohci-hcd feature
>>>   meta: add usb/uhci-hcd feature
>>>   meta/crownbay: use usb features
>>>   meta: add mei feature
>>>
>>>  meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    6 ------
>>>  meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    5 +++++
>>>  meta/cfg/kernel-cache/features/amt/mei/mei.cfg  |    3 +++
>>>  meta/cfg/kernel-cache/features/amt/mei/mei.scc  |    4 ++++
>>>  meta/cfg/kernel-cache/features/usb/base.cfg     |    3 +++
>>>  meta/cfg/kernel-cache/features/usb/base.scc     |    4 ++++
>>>  meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
>>>  meta/cfg/kernel-cache/features/usb/ehci-hcd.scc |    4 ++++
>>>  meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg |    1 +
>>>  meta/cfg/kernel-cache/features/usb/ohci-hcd.scc |    4 ++++
>>>  meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg |    1 +
>>>  meta/cfg/kernel-cache/features/usb/uhci-hcd.scc |    4 ++++
>>>  meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg |    1 +
>>>  meta/cfg/kernel-cache/features/usb/xhci-hcd.scc |    4 ++++
>>>  14 files changed, 39 insertions(+), 6 deletions(-)
>>>  create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
>>>  create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/base.cfg
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/base.scc
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
>>>  create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc
>>>
>>
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 0/7][KERNEL] add usb and mei features

[Tom Zanussi]

On Fri, 2012-05-04 at 18:00 -0700, Darren Hart wrote:
> 
> On 05/04/2012 05:06 PM, Tom Zanussi wrote:
> > On Fri, 2012-05-04 at 16:04 -0700, Darren Hart wrote:
> >>
> >> On 05/04/2012 03:07 PM, tom.zanussi@intel.com wrote:
> >>> From: Tom Zanussi <tom.zanussi@intel.com>
> >>>
> >>> This adds a few new features, one each for usb/[xeou]hci-hcd and
> >>> another for amt/mei, and refactors existing config options into a new
> >>> usb/base, which are then used in crownbay.
> >>>
> >>> v2: after suggestions from Bruce and Darren of a preference for a more
> >>> flattened feature tree structure, moved all the features into a single
> >>> usb/ feature dir.  I did however retain the common 'base' feature
> >>> because inlining that in each feature would mean that the same common
> >>> set would be repeated in multiple config fragments if more than one usb
> >>> feature was included in a BSP.
> >>
> >> As things stand now, a BSP would have to include both the base and the
> >> *hcd right?
> >>
> >> include usb/base.scc
> >> include ehci-hcd.scc
> >>
> >> Seems to me we should manage the dependencies wherever we can. When I've
> >> created fragments I've been including their requirements as well to make
> >> it easier on the integrator. Since you've put the dependencies in their
> >> own fragment, why not include the fragment in the *hcd.scc files?
> >>
> >> +++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
> >> @@ -0,0 +1,4 @@
> >> +define KFEATURE_DESCRIPTION "Enable options for ehci (USB 2.0)"
> >> +define KFEATURE_COMPATIBILITY board
> >> +
> >> + include base.scc
> >> +kconf hardware ehci-hcd.cfg
> >>
> >> Now if someone need only include the one line for the *hcd. Since it's
> >> only a total of 3 lines of CONFIG settings we're packaging up here, it
> >> seems to me we should be able to enable it with only 1 line of meta data.
> >>
> > 
> > Yes, this is exactly what I did in the previous patchset.
> > 
> > The problem is that if we do this for each of the *hcd fragments, we end
> > up with the options in base.cfg repeated for each, which may or may not
> > produce a config-check warning.
> 
> "May or may not"? If our tools complain about setting a config to the
> same value, I would prefer to address that in the tools.
> 

Well, there is this in the tools:

# Egads. People are listing the same thing multiple times within a fragment.
#  An evil sin that deserves its own category (and insults).
KCONF_FRAG_ERRS=$KCONF_DIR/fragment_errors.txt

Tongue-in-cheek obviously, but is pointing out bad form regardless.

Anyway, the right way to solve this would be to implement fragment
dependencies, where each of the *hcd fragments would contain something
like

 depends-on base.scc
 kconf hardware ehci-hcd.cfg

and the tools would make sure only one instance of the base.scc options
was included.

Obviously we don't have that or anything like that planned (which would
probably be an upstreamable project, not something I wanted to address
with this relatively (I thought) minor cleanup).

Tom

> 
> 
> Bruce, any comment on the intended behavior of the tools?
> 
> --
> Darren
> 
> > 
> > To avoid that, we need to be able to add the base.cfg items once
> > followed by the individual *hcd items as I did with the crownbay
> > example:
> > 
> > +include features/usb/base.scc
> > +include features/usb/ehci-hcd.scc
> > +include features/usb/ohci-hcd.scc
> > +include features/usb/uhci-hcd.scc
> > 
> > 
> > Tom
> > 
> >> --
> >> Darren
> >>
> >>>
> >>> Please pull into linux-yocto-3.2.
> >>>
> >>> Thanks,
> >>>
> >>> Tom
> >>>
> >>> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
> >>>   Yang Shi (1):
> >>>         meta: Clean up BSPs kernel config
> >>>
> >>> are available in the git repository at:
> >>>
> >>>   git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
> >>>   http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
> >>>
> >>> Tom Zanussi (7):
> >>>   meta: add usb/base feature
> >>>   meta: add usb/xhci-hcd feature
> >>>   meta: add usb/ehci-hcd feature
> >>>   meta: add usb/ohci-hcd feature
> >>>   meta: add usb/uhci-hcd feature
> >>>   meta/crownbay: use usb features
> >>>   meta: add mei feature
> >>>
> >>>  meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    6 ------
> >>>  meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    5 +++++
> >>>  meta/cfg/kernel-cache/features/amt/mei/mei.cfg  |    3 +++
> >>>  meta/cfg/kernel-cache/features/amt/mei/mei.scc  |    4 ++++
> >>>  meta/cfg/kernel-cache/features/usb/base.cfg     |    3 +++
> >>>  meta/cfg/kernel-cache/features/usb/base.scc     |    4 ++++
> >>>  meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
> >>>  meta/cfg/kernel-cache/features/usb/ehci-hcd.scc |    4 ++++
> >>>  meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg |    1 +
> >>>  meta/cfg/kernel-cache/features/usb/ohci-hcd.scc |    4 ++++
> >>>  meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg |    1 +
> >>>  meta/cfg/kernel-cache/features/usb/uhci-hcd.scc |    4 ++++
> >>>  meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg |    1 +
> >>>  meta/cfg/kernel-cache/features/usb/xhci-hcd.scc |    4 ++++
> >>>  14 files changed, 39 insertions(+), 6 deletions(-)
> >>>  create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
> >>>  create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
> >>>  create mode 100644 meta/cfg/kernel-cache/features/usb/base.cfg
> >>>  create mode 100644 meta/cfg/kernel-cache/features/usb/base.scc
> >>>  create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
> >>>  create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
> >>>  create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
> >>>  create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
> >>>  create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
> >>>  create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
> >>>  create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
> >>>  create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc
> >>>
> >>
> > 
> > 
> 

Re: [PATCH 0/7][KERNEL] add usb and mei features

[Bruce Ashfield]

On 12-05-04 9:00 PM, Darren Hart wrote:
>
>
> On 05/04/2012 05:06 PM, Tom Zanussi wrote:
>> On Fri, 2012-05-04 at 16:04 -0700, Darren Hart wrote:
>>>
>>> On 05/04/2012 03:07 PM, tom.zanussi@intel.com wrote:
>>>> From: Tom Zanussi<tom.zanussi@intel.com>
>>>>
>>>> This adds a few new features, one each for usb/[xeou]hci-hcd and
>>>> another for amt/mei, and refactors existing config options into a new
>>>> usb/base, which are then used in crownbay.
>>>>
>>>> v2: after suggestions from Bruce and Darren of a preference for a more
>>>> flattened feature tree structure, moved all the features into a single
>>>> usb/ feature dir.  I did however retain the common 'base' feature
>>>> because inlining that in each feature would mean that the same common
>>>> set would be repeated in multiple config fragments if more than one usb
>>>> feature was included in a BSP.
>>>
>>> As things stand now, a BSP would have to include both the base and the
>>> *hcd right?
>>>
>>> include usb/base.scc
>>> include ehci-hcd.scc
>>>
>>> Seems to me we should manage the dependencies wherever we can. When I've
>>> created fragments I've been including their requirements as well to make
>>> it easier on the integrator. Since you've put the dependencies in their
>>> own fragment, why not include the fragment in the *hcd.scc files?
>>>
>>> +++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
>>> @@ -0,0 +1,4 @@
>>> +define KFEATURE_DESCRIPTION "Enable options for ehci (USB 2.0)"
>>> +define KFEATURE_COMPATIBILITY board
>>> +
>>> + include base.scc
>>> +kconf hardware ehci-hcd.cfg
>>>
>>> Now if someone need only include the one line for the *hcd. Since it's
>>> only a total of 3 lines of CONFIG settings we're packaging up here, it
>>> seems to me we should be able to enable it with only 1 line of meta data.
>>>
>>
>> Yes, this is exactly what I did in the previous patchset.
>>
>> The problem is that if we do this for each of the *hcd fragments, we end
>> up with the options in base.cfg repeated for each, which may or may not
>> produce a config-check warning.
>
> "May or may not"? If our tools complain about setting a config to the
> same value, I would prefer to address that in the tools.
>
> Bruce, any comment on the intended behavior of the tools?

That warning is supposed to only trigger if you literally are in the
same fragment. The switch to a new fragment should allow the duplication.

There is a secondary warning that yells if an option is redefined by
ANY fragment. That mode is to support a configuration scheme that says
all fragments should be exclusive and additive. I made that into a
flag some time ago.

That being said, the switch to merge_config (the upstream script), caused
a few things to be more difficult. This is one of them. I have some
changes to this already queued, and I'm not seeing anything like this
in my tests. I've got something that allows the multiple includes to
work fine (and stops short of a new keyword (although that it tempting
to reduce complexity)).

I'll run some configuration tests here when I merge the series, and see
if a regression snuck in.

Cheers,

Bruce

>
> --
> Darren
>
>>
>> To avoid that, we need to be able to add the base.cfg items once
>> followed by the individual *hcd items as I did with the crownbay
>> example:
>>
>> +include features/usb/base.scc
>> +include features/usb/ehci-hcd.scc
>> +include features/usb/ohci-hcd.scc
>> +include features/usb/uhci-hcd.scc
>>
>>
>> Tom
>>
>>> --
>>> Darren
>>>
>>>>
>>>> Please pull into linux-yocto-3.2.
>>>>
>>>> Thanks,
>>>>
>>>> Tom
>>>>
>>>> The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
>>>>    Yang Shi (1):
>>>>          meta: Clean up BSPs kernel config
>>>>
>>>> are available in the git repository at:
>>>>
>>>>    git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
>>>>    http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
>>>>
>>>> Tom Zanussi (7):
>>>>    meta: add usb/base feature
>>>>    meta: add usb/xhci-hcd feature
>>>>    meta: add usb/ehci-hcd feature
>>>>    meta: add usb/ohci-hcd feature
>>>>    meta: add usb/uhci-hcd feature
>>>>    meta/crownbay: use usb features
>>>>    meta: add mei feature
>>>>
>>>>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    6 ------
>>>>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    5 +++++
>>>>   meta/cfg/kernel-cache/features/amt/mei/mei.cfg  |    3 +++
>>>>   meta/cfg/kernel-cache/features/amt/mei/mei.scc  |    4 ++++
>>>>   meta/cfg/kernel-cache/features/usb/base.cfg     |    3 +++
>>>>   meta/cfg/kernel-cache/features/usb/base.scc     |    4 ++++
>>>>   meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
>>>>   meta/cfg/kernel-cache/features/usb/ehci-hcd.scc |    4 ++++
>>>>   meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg |    1 +
>>>>   meta/cfg/kernel-cache/features/usb/ohci-hcd.scc |    4 ++++
>>>>   meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg |    1 +
>>>>   meta/cfg/kernel-cache/features/usb/uhci-hcd.scc |    4 ++++
>>>>   meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg |    1 +
>>>>   meta/cfg/kernel-cache/features/usb/xhci-hcd.scc |    4 ++++
>>>>   14 files changed, 39 insertions(+), 6 deletions(-)
>>>>   create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
>>>>   create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
>>>>   create mode 100644 meta/cfg/kernel-cache/features/usb/base.cfg
>>>>   create mode 100644 meta/cfg/kernel-cache/features/usb/base.scc
>>>>   create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
>>>>   create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd.scc
>>>>   create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.cfg
>>>>   create mode 100644 meta/cfg/kernel-cache/features/usb/ohci-hcd.scc
>>>>   create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.cfg
>>>>   create mode 100644 meta/cfg/kernel-cache/features/usb/uhci-hcd.scc
>>>>   create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.cfg
>>>>   create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd.scc
>>>>
>>>
>>
>>
>