From: George Dunlap <george.dunlap@eu.citrix.com>
To: David Vrabel <dvrabel@cantab.net>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 0 of 4] Add commands to automatically prep devices for pass-through
Date: Wed, 9 May 2012 12:11:56 +0100 [thread overview]
Message-ID: <4FAA50FC.60105@eu.citrix.com> (raw)
In-Reply-To: <4FAA4D4F.9070804@cantab.net>
On 09/05/12 11:56, David Vrabel wrote:
> pci_assignable_add: Make a device assignable to guests. This involves
> unbinding the device from its old driver, creating a slot for it in
> pciback (if necessary), and binding it to pciback.
>
> pci_assignable_list: List devices assignable to guests. Just renamed
> from pci_list_assignable.
> You use underscores here (and elsewhere in the commit message) but the
> code uses dashes. Suggest updating the commit messages with the format
> for the commands.
I used underscores in the patch to libxl, because the libxl functions
have undescores, and dashes in the xl patch, because the xl commands use
dashes. :-)
-George
prev parent reply other threads:[~2012-05-09 11:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 10:28 [PATCH 0 of 4] Add commands to automatically prep devices for pass-through George Dunlap
2012-05-09 10:28 ` [PATCH 1 of 4] libxl: Make a helper function write a BDF to a sysfs path George Dunlap
2012-05-10 10:40 ` Ian Campbell
2012-05-09 10:28 ` [PATCH 2 of 4] libxl: Rename pci_list_assignable to pci_assignable_list George Dunlap
2012-05-10 10:43 ` Ian Campbell
2012-05-10 10:54 ` George Dunlap
2012-05-09 10:28 ` [PATCH 3 of 4] libxl: Introduce pci_assignable_add and pci_assignable_remove George Dunlap
2012-05-10 11:19 ` Ian Campbell
2012-05-10 14:55 ` George Dunlap
2012-05-10 15:04 ` Ian Campbell
2012-05-10 16:29 ` George Dunlap
2012-05-10 16:45 ` Ian Campbell
2012-05-09 10:28 ` [PATCH 4 of 4] xl: Add pci_assignable_add and remove commands George Dunlap
2012-05-10 11:31 ` Ian Campbell
2012-05-11 11:13 ` George Dunlap
2012-05-11 11:19 ` Ian Campbell
2012-05-11 12:50 ` George Dunlap
2012-05-11 12:58 ` Ian Campbell
2012-05-09 10:49 ` [PATCH 0 of 4] Add commands to automatically prep devices for pass-through Ian Campbell
2012-05-09 11:03 ` George Dunlap
2012-05-09 11:59 ` Ian Campbell
2012-05-09 13:45 ` George Dunlap
2012-05-10 10:17 ` George Dunlap
2012-05-10 10:38 ` Ian Campbell
2012-05-10 14:12 ` Sander Eikelenboom
2012-05-10 14:16 ` Ian Campbell
2012-05-10 16:15 ` Konrad Rzeszutek Wilk
2012-05-09 10:56 ` David Vrabel
2012-05-09 11:11 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAA50FC.60105@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=dvrabel@cantab.net \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.