From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'amit kachhap' <amit.kachhap@gmail.com>,
'Rob Lee' <rob.lee@linaro.org>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-dev@lists.linaro.org, patches@linaro.org
Subject: Re: [PATCH] ARM: exynos: Adapt to cpuidle core time keeping and irq enable
Date: Wed, 09 May 2012 14:09:12 +0200 [thread overview]
Message-ID: <4FAA5E68.1060204@linaro.org> (raw)
In-Reply-To: <019801cd2dda$5dbbc680$19335380$%kim@samsung.com>
On 05/09/2012 01:53 PM, Kukjin Kim wrote:
> amit kachhap wrote:
>>
>> Hi Mr Kukjin,
>>
>> Any comment or update about this patch?
>>
> I'm not sure we don't need to check the idle_time?
> Others, looks ok to me.
Hi,
may be I misunderstood your question but the behavior is not changed
here, just the code is refactored and using a common routine where the
time is computed.
The idle_time computation is done by the cpuidle core now if the
en_core_tk_irqen flag is enabled. That allows to remove a lot of
duplicated code across the cpuidle drivers.
Thanks
-- Daniel
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: exynos: Adapt to cpuidle core time keeping and irq enable
Date: Wed, 09 May 2012 14:09:12 +0200 [thread overview]
Message-ID: <4FAA5E68.1060204@linaro.org> (raw)
In-Reply-To: <019801cd2dda$5dbbc680$19335380$%kim@samsung.com>
On 05/09/2012 01:53 PM, Kukjin Kim wrote:
> amit kachhap wrote:
>>
>> Hi Mr Kukjin,
>>
>> Any comment or update about this patch?
>>
> I'm not sure we don't need to check the idle_time?
> Others, looks ok to me.
Hi,
may be I misunderstood your question but the behavior is not changed
here, just the code is refactored and using a common routine where the
time is computed.
The idle_time computation is done by the cpuidle core now if the
en_core_tk_irqen flag is enabled. That allows to remove a lot of
duplicated code across the cpuidle drivers.
Thanks
-- Daniel
next prev parent reply other threads:[~2012-05-09 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 12:11 [PATCH] ARM: exynos: Adapt to cpuidle core time keeping and irq enable Amit Daniel Kachhap
2012-04-25 12:11 ` Amit Daniel Kachhap
2012-04-25 14:44 ` Daniel Lezcano
2012-04-25 14:44 ` Daniel Lezcano
2012-04-30 16:43 ` Rob Lee
2012-04-30 16:43 ` Rob Lee
2012-05-08 4:01 ` amit kachhap
2012-05-08 4:01 ` amit kachhap
2012-05-09 11:53 ` Kukjin Kim
2012-05-09 11:53 ` Kukjin Kim
2012-05-09 12:09 ` Daniel Lezcano [this message]
2012-05-09 12:09 ` Daniel Lezcano
2012-05-09 12:18 ` Kukjin Kim
2012-05-09 12:18 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAA5E68.1060204@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rob.lee@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.