Re: [PATCH v4] vsmp: Fix number of CPUs when vsmp is disabled

["H. Peter Anvin" <hpa@zytor.com>]

On 05/09/2012 08:44 AM, Ingo Molnar wrote:
> 
> * Ido Yariv <ido@wizery.com> wrote:
> 
>> +static void __init vsmp_cap_cpus(void)
>> +{
>> +	void __iomem *address;
>> +	unsigned int cfg, topology, node_shift, maxcpus;
>> +
>> +#ifdef CONFIG_X86_VSMP
>> +	/* VSMP is enabled, no need to cap cpus */
>> +	return;
>> +#elif defined(CONFIG_SMP)
>> +	/*
>> +	 * CONFIG_X86_VSMP is not configured, so limit the number CPUs to the
> 
> I suspect this will throw compiler warnings in the 
> CONFIG_X86_VSMP && !CONFIG_SMP case.
> 

What on Earth is the point of allowing that combination?  Why not make
X86_VSMP depend on SMP and reduce the testing matrix?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.