All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Ido Yariv <ido@wizery.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	shai@scalemp.com, wfg@linux.intel.com, ido@wizery.com,
	tglx@linutronix.de
Subject: [tip:x86/platform] x86/vsmp: Fix linker error when CONFIG_PROC_FS is not set
Date: Fri, 15 Jun 2012 07:22:19 -0700	[thread overview]
Message-ID: <tip-d48daf37a3d2e2b28a61e615c0fc538301edb0dd@git.kernel.org> (raw)
In-Reply-To: <1339688588-12674-1-git-send-email-ido@wizery.com>

Commit-ID:  d48daf37a3d2e2b28a61e615c0fc538301edb0dd
Gitweb:     http://git.kernel.org/tip/d48daf37a3d2e2b28a61e615c0fc538301edb0dd
Author:     Ido Yariv <ido@wizery.com>
AuthorDate: Thu, 14 Jun 2012 18:43:08 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 15 Jun 2012 13:54:11 +0200

x86/vsmp: Fix linker error when CONFIG_PROC_FS is not set

set_vsmp_pv_ops() references no_irq_affinity which is undeclared
if CONFIG_PROC_FS isn't set. Fix this by adding an #ifdef around
this variable's access.

Reported-by: Fengguang Wu <wfg@linux.intel.com>
Signed-off-by: Ido Yariv <ido@wizery.com>
Acked-by: Shai Fultheim <shai@scalemp.com>
Link: http://lkml.kernel.org/r/1339688588-12674-1-git-send-email-ido@wizery.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/vsmp_64.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/vsmp_64.c b/arch/x86/kernel/vsmp_64.c
index 6b96a73..3f0285a 100644
--- a/arch/x86/kernel/vsmp_64.c
+++ b/arch/x86/kernel/vsmp_64.c
@@ -101,7 +101,10 @@ static void __init set_vsmp_pv_ops(void)
 #ifdef CONFIG_SMP
 	if (cap & ctl & BIT(8)) {
 		ctl &= ~BIT(8);
+#ifdef CONFIG_PROC_FS
+		/* Don't let users change irq affinity via procfs */
 		no_irq_affinity = 1;
+#endif
 	}
 #endif
 

  reply	other threads:[~2012-06-15 14:22 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-06 12:39 [PATCH 1/2] vsmp: Fix number of CPUs when vsmp is disabled Ido Yariv
2012-04-06 12:39 ` [PATCH 2/2] vsmp: Ignore IOAPIC IRQ affinity if possible Ido Yariv
2012-04-16  7:39   ` [PATCH v2 1/2] vsmp: Fix number of CPUs when vsmp is disabled Ido Yariv
2012-04-16  7:39     ` [PATCH v2 2/2] vsmp: Ignore IOAPIC IRQ affinity if possible Ido Yariv
2012-05-07 13:19       ` Ingo Molnar
2012-05-08  0:53         ` Shai Fultheim (Shai@ScaleMP.com)
2012-05-09  9:18           ` Ingo Molnar
2012-05-09 21:21             ` Ido Yariv
2012-06-02 22:11               ` [PATCH 1/2] x86: Introduce apic post-initialization callback Ido Yariv
2012-06-02 22:11                 ` [PATCH v3 2/2] vsmp: Ignore IOAPIC IRQ affinity if possible Ido Yariv
2012-06-06 15:02                   ` [tip:x86/platform] x86/vsmp: " tip-bot for Ravikiran Thirumalai
2012-06-08  8:52                     ` Ingo Molnar
2012-06-08 15:43                       ` Ido Yariv
2012-06-11  8:58                         ` Ingo Molnar
2012-06-11 19:41                           ` Ido Yariv
2012-06-14 10:51                             ` Ingo Molnar
2012-06-14 15:43                               ` [PATCH] x86/vsmp: Fix linker error when CONFIG_PROC_FS is not set Ido Yariv
2012-06-15 14:22                                 ` tip-bot for Ido Yariv [this message]
2012-06-06 15:01                 ` [tip:x86/platform] x86/platform: Introduce APIC post-initialization callback tip-bot for Ido Yariv
2012-06-14 17:34                   ` H. Peter Anvin
2012-06-15 14:33                     ` Ido Yariv
2012-04-28 21:33     ` [PATCH v2 1/2] vsmp: Fix number of CPUs when vsmp is disabled Ido Yariv
2012-04-29  3:05       ` Shai Fultheim (Shai@ScaleMP.com)
2012-05-07 13:24     ` Ingo Molnar
2012-05-08  7:34       ` [PATCH v3] " Ido Yariv
2012-05-08 10:05         ` [tip:x86/platform] " tip-bot for Shai Fultheim
2012-05-08 12:25           ` Ingo Molnar
2012-05-09  8:03             ` Ido Yariv
2012-05-09  8:22               ` Ido Yariv
2012-05-09  8:28                 ` [PATCH v4] " Ido Yariv
2012-05-09 15:44                   ` Ingo Molnar
2012-05-09 15:55                     ` H. Peter Anvin
2012-05-11 19:26                       ` Ido Yariv
2012-05-12  1:20                         ` Shai Fultheim (Shai@ScaleMP.com)
2012-05-09  9:12               ` [tip:x86/platform] " Ingo Molnar
2012-05-09 15:27                 ` Shai Fultheim (Shai@ScaleMP.com)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-d48daf37a3d2e2b28a61e615c0fc538301edb0dd@git.kernel.org \
    --to=ido@wizery.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=shai@scalemp.com \
    --cc=tglx@linutronix.de \
    --cc=wfg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.