From: Mike Christie <michaelc@cs.wisc.edu>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
Linux-Netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>, Neil Brown <neilb@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Eric B Munson <emunson@mgebm.net>
Subject: Re: [PATCH 00/17] Swap-over-NBD without deadlocking V10
Date: Thu, 10 May 2012 12:17:01 -0500 [thread overview]
Message-ID: <4FABF80D.3040803@cs.wisc.edu> (raw)
In-Reply-To: <1336657510-24378-1-git-send-email-mgorman@suse.de>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
On 05/10/2012 08:44 AM, Mel Gorman wrote:
> When a user or administrator requires swap for their application, they
> create a swap partition and file, format it with mkswap and activate it
> with swapon. Swap over the network is considered as an option in diskless
> systems. The two likely scenarios are when blade servers are used as part
> of a cluster where the form factor or maintenance costs do not allow the
> use of disks and thin clients.
Thank you for working on this. I made the attached patch for software
iscsi which has the same issue as nbd.
I tested the patch here and did not notice any performance regressions
or any other bugs.
[-- Attachment #2: 0001-iscsi-Set-SOCK_MEMALLOC-for-access-to-PFMEMALLOC-res.patch --]
[-- Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michaelc@cs.wisc.edu>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
Linux-Netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>, Neil Brown <neilb@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Eric B Munson <emunson@mgebm.net>
Subject: Re: [PATCH 00/17] Swap-over-NBD without deadlocking V10
Date: Thu, 10 May 2012 12:17:01 -0500 [thread overview]
Message-ID: <4FABF80D.3040803@cs.wisc.edu> (raw)
In-Reply-To: <1336657510-24378-1-git-send-email-mgorman@suse.de>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
On 05/10/2012 08:44 AM, Mel Gorman wrote:
> When a user or administrator requires swap for their application, they
> create a swap partition and file, format it with mkswap and activate it
> with swapon. Swap over the network is considered as an option in diskless
> systems. The two likely scenarios are when blade servers are used as part
> of a cluster where the form factor or maintenance costs do not allow the
> use of disks and thin clients.
Thank you for working on this. I made the attached patch for software
iscsi which has the same issue as nbd.
I tested the patch here and did not notice any performance regressions
or any other bugs.
[-- Attachment #2: 0001-iscsi-Set-SOCK_MEMALLOC-for-access-to-PFMEMALLOC-res.patch --]
[-- Type: text/plain, Size: 1585 bytes --]
>From 917d53f16d1e26b12e90e5e15df76a7a8bee35e8 Mon Sep 17 00:00:00 2001
From: Mike Christie <michaelc@cs.wisc.edu>
Date: Thu, 3 May 2012 12:36:18 -0500
Subject: [PATCH 1/1] iscsi: Set SOCK_MEMALLOC for access to PFMEMALLOC
reserves
Set SOCK_MEMALLOC on the iscsi socket to allow access to PFMEMALLOC
reserves to prevent deadlock.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
drivers/scsi/iscsi_tcp.c | 18 +++++++++++++-----
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 453a740..7360f4c 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -370,17 +370,24 @@ static inline int iscsi_sw_tcp_xmit_qlen(struct iscsi_conn *conn)
static int iscsi_sw_tcp_pdu_xmit(struct iscsi_task *task)
{
struct iscsi_conn *conn = task->conn;
- int rc;
+ unsigned long pflags = current->flags;
+ int rc = 0;
+
+ current->flags |= PF_MEMALLOC;
while (iscsi_sw_tcp_xmit_qlen(conn)) {
rc = iscsi_sw_tcp_xmit(conn);
- if (rc == 0)
- return -EAGAIN;
+ if (rc == 0) {
+ rc = -EAGAIN;
+ break;
+ }
if (rc < 0)
- return rc;
+ break;
+ rc = 0;
}
- return 0;
+ tsk_restore_flags(current, pflags, PF_MEMALLOC);
+ return rc;
}
/*
@@ -665,6 +672,7 @@ iscsi_sw_tcp_conn_bind(struct iscsi_cls_session *cls_session,
sk->sk_reuse = 1;
sk->sk_sndtimeo = 15 * HZ; /* FIXME: make it configurable */
sk->sk_allocation = GFP_ATOMIC;
+ sk_set_memalloc(sk);
iscsi_sw_tcp_conn_set_callbacks(conn);
tcp_sw_conn->sendpage = tcp_sw_conn->sock->ops->sendpage;
--
1.7.7.6
next prev parent reply other threads:[~2012-05-10 17:17 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 13:44 [PATCH 00/17] Swap-over-NBD without deadlocking V10 Mel Gorman
2012-05-10 13:44 ` Mel Gorman
2012-05-10 13:44 ` [PATCH 01/17] mm: Serialize access to min_free_kbytes Mel Gorman
2012-05-10 13:44 ` Mel Gorman
2012-05-10 13:44 ` [PATCH 02/17] mm: sl[au]b: Add knowledge of PFMEMALLOC reserve pages Mel Gorman
2012-05-10 13:44 ` Mel Gorman
2012-05-10 13:44 ` [PATCH 03/17] mm: slub: Optimise the SLUB fast path to avoid pfmemalloc checks Mel Gorman
2012-05-10 13:44 ` Mel Gorman
2012-05-10 13:44 ` [PATCH 04/17] mm: Introduce __GFP_MEMALLOC to allow access to emergency reserves Mel Gorman
2012-05-10 13:44 ` Mel Gorman
2012-05-10 13:44 ` [PATCH 05/17] mm: allow PF_MEMALLOC from softirq context Mel Gorman
2012-05-10 13:44 ` Mel Gorman
2012-05-11 4:39 ` David Miller
2012-05-11 4:39 ` David Miller
2012-05-14 10:02 ` Mel Gorman
2012-05-14 10:02 ` Mel Gorman
2012-05-15 13:07 ` Mel Gorman
2012-05-15 13:07 ` Mel Gorman
2012-05-10 13:44 ` [PATCH 06/17] mm: Only set page->pfmemalloc when ALLOC_NO_WATERMARKS was used Mel Gorman
2012-05-10 13:44 ` Mel Gorman
2012-05-10 13:45 ` [PATCH 07/17] mm: Ignore mempolicies when using ALLOC_NO_WATERMARK Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-10 13:45 ` [PATCH 08/17] net: Introduce sk_allocation() to allow addition of GFP flags depending on the individual socket Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-11 4:49 ` David Miller
2012-05-11 4:49 ` David Miller
2012-05-11 14:12 ` Mel Gorman
2012-05-11 14:12 ` Mel Gorman
2012-05-10 13:45 ` [PATCH 09/17] netvm: Allow the use of __GFP_MEMALLOC by specific sockets Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-11 4:50 ` David Miller
2012-05-11 4:50 ` David Miller
2012-05-10 13:45 ` [PATCH 10/17] netvm: Allow skb allocation to use PFMEMALLOC reserves Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-11 4:57 ` David Miller
2012-05-11 4:57 ` David Miller
2012-05-11 14:32 ` Mel Gorman
2012-05-11 14:32 ` Mel Gorman
2012-05-11 14:42 ` Peter Zijlstra
2012-05-11 14:42 ` Peter Zijlstra
2012-05-11 15:07 ` Mel Gorman
2012-05-11 15:07 ` Mel Gorman
2012-05-11 21:17 ` David Miller
2012-05-11 21:17 ` David Miller
2012-05-10 13:45 ` [PATCH 11/17] netvm: Propagate page->pfmemalloc to skb Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-10 13:45 ` [PATCH 12/17] netvm: Propagate page->pfmemalloc from netdev_alloc_page " Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-11 5:01 ` David Miller
2012-05-11 5:01 ` David Miller
2012-05-11 14:46 ` Mel Gorman
2012-05-11 14:46 ` Mel Gorman
2012-05-10 13:45 ` [PATCH 13/17] netvm: Set PF_MEMALLOC as appropriate during SKB processing Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-11 5:03 ` David Miller
2012-05-11 5:03 ` David Miller
2012-05-10 13:45 ` [PATCH 14/17] mm: Micro-optimise slab to avoid a function call Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-10 13:45 ` [PATCH 15/17] nbd: Set SOCK_MEMALLOC for access to PFMEMALLOC reserves Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-10 13:45 ` [PATCH 16/17] mm: Throttle direct reclaimers if PF_MEMALLOC reserves are low and swap is backed by network storage Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-10 13:45 ` [PATCH 17/17] mm: Account for the number of times direct reclaimers get throttled Mel Gorman
2012-05-10 13:45 ` Mel Gorman
2012-05-10 17:17 ` Mike Christie [this message]
2012-05-10 17:17 ` [PATCH 00/17] Swap-over-NBD without deadlocking V10 Mike Christie
2012-05-11 5:04 ` David Miller
2012-05-11 5:04 ` David Miller
2012-05-11 15:45 ` Mel Gorman
2012-05-11 15:45 ` Mel Gorman
2012-05-11 21:23 ` David Miller
2012-05-11 21:23 ` David Miller
2012-05-11 21:29 ` Andrew Morton
2012-05-11 21:29 ` Andrew Morton
2012-05-14 11:10 ` Mel Gorman
2012-05-14 11:10 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FABF80D.3040803@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=emunson@mgebm.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.