Re: [PATCH v2 1/4] can: c_can: fix an interrupt thrash issue with c_can driver

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

05/10/2012 01:34 PM, AnilKumar Ch wrote:
> This patch fixes an interrupt thrash issue with c_can driver.
> 
> In c_can_isr() function interrupts are disabled and enabled only in
> c_can_poll() function. c_can_isr() & c_can_poll() both read the
> irqstatus flag. However, irqstatus is always read as 0 in c_can_poll()
> because all C_CAN interrupts are disabled in c_can_isr(). This causes
> all interrupts to be re-enabled in c_can_poll() which in turn causes
> another interrupt since the event is not really handled. This keeps
> happening causing a flood of interrupts.
> 
> To fix this, read the irqstatus register in isr and use the same cached
> value in the poll function.
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>

Can you or someone else please test this patch on c_can hardware, and
add her/his Tested-by? This patch is a stable candidate, isn't it?

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

cheers, Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]