Re: [PATCH v2 2/4] can: c_can: fix: enable CAN HW interrupts after napi_enable()

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]

On 05/10/2012 01:34 PM, AnilKumar Ch wrote:
> Fix the issue of C_CAN interrupts getting disabled forever even though
> we do can configuration multiple times using can utils. According to
> NAPI usage we disable all the hardware interrupts in ISR and re-enable
> them in poll(). Current implementation calls napi_enable() after hardware
> interrupts are enabled. If we get any interrupts between these two steps
> then we do not process those interrupts because napi is not enabled. Mostly
> these interrupts come because of STATUS is not 0x7 or ERROR interrupts. If
> napi_enable() happens before hardware interrupts enabled then c_can_poll()
> function will be called eventual re-enabling of interrupts will happen.
> 
> This patch moves the napi_enable() call before interrupts enabled.
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>

Please test on c_can, also this is a stable candidate. What about add
the term "race condition" to the subject?

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]