From: Minchan Kim <minchan@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: raise MemFree by reverting percpu_pagelist_fraction to 0
Date: Fri, 11 May 2012 17:38:37 +0900 [thread overview]
Message-ID: <4FACD00D.4060003@kernel.org> (raw)
In-Reply-To: <CA+1xoqcChazS=TRt6-7GjJAzQNFLFXmO623rWwjRkdD5x3k=iw@mail.gmail.com>
On 05/11/2012 05:30 PM, Sasha Levin wrote:
> On Fri, May 11, 2012 at 10:00 AM, Hugh Dickins <hughd@google.com> wrote:
>> Commit 93278814d359 "mm: fix division by 0 in percpu_pagelist_fraction()"
>> mistakenly initialized percpu_pagelist_fraction to the sysctl's minimum 8,
>> which leaves 1/8th of memory on percpu lists (on each cpu??); but most of
>> us expect it to be left unset at 0 (and it's not then used as a divisor).
>
> I'm a bit confused about this, does it mean that once you set
> percpu_pagelist_fraction to a value above the minimum, you can no
> longer set it back to being 0?
Unfortunately, Yes. :(
It's rather awkward and need fix.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: raise MemFree by reverting percpu_pagelist_fraction to 0
Date: Fri, 11 May 2012 17:38:37 +0900 [thread overview]
Message-ID: <4FACD00D.4060003@kernel.org> (raw)
In-Reply-To: <CA+1xoqcChazS=TRt6-7GjJAzQNFLFXmO623rWwjRkdD5x3k=iw@mail.gmail.com>
On 05/11/2012 05:30 PM, Sasha Levin wrote:
> On Fri, May 11, 2012 at 10:00 AM, Hugh Dickins <hughd@google.com> wrote:
>> Commit 93278814d359 "mm: fix division by 0 in percpu_pagelist_fraction()"
>> mistakenly initialized percpu_pagelist_fraction to the sysctl's minimum 8,
>> which leaves 1/8th of memory on percpu lists (on each cpu??); but most of
>> us expect it to be left unset at 0 (and it's not then used as a divisor).
>
> I'm a bit confused about this, does it mean that once you set
> percpu_pagelist_fraction to a value above the minimum, you can no
> longer set it back to being 0?
Unfortunately, Yes. :(
It's rather awkward and need fix.
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2012-05-11 8:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 8:00 [PATCH] mm: raise MemFree by reverting percpu_pagelist_fraction to 0 Hugh Dickins
2012-05-11 8:00 ` Hugh Dickins
2012-05-11 8:30 ` Sasha Levin
2012-05-11 8:30 ` Sasha Levin
2012-05-11 8:38 ` Minchan Kim [this message]
2012-05-11 8:38 ` Minchan Kim
2012-05-11 9:01 ` Minchan Kim
2012-05-11 9:01 ` Minchan Kim
2012-05-11 16:27 ` Linus Torvalds
2012-05-11 16:27 ` Linus Torvalds
2012-05-11 16:35 ` Sasha Levin
2012-05-11 16:35 ` Sasha Levin
2012-05-11 16:54 ` Linus Torvalds
2012-05-11 16:54 ` Linus Torvalds
2012-05-14 8:51 ` Cong Wang
2012-05-14 8:51 ` Cong Wang
2012-05-11 14:10 ` Hugh Dickins
2012-05-11 14:10 ` Hugh Dickins
2012-05-14 1:51 ` Minchan Kim
2012-05-14 1:51 ` Minchan Kim
2012-05-11 16:26 ` Linus Torvalds
2012-05-11 16:26 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FACD00D.4060003@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.