From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/3] staging:iio:dac: Remove unused dac.h includes
Date: Sat, 12 May 2012 19:20:50 +0100 [thread overview]
Message-ID: <4FAEAA02.7060500@kernel.org> (raw)
In-Reply-To: <1336755862-24184-1-git-send-email-lars@metafoo.de>
On 05/11/2012 06:04 PM, Lars-Peter Clausen wrote:
> None of these drivers use anything from dac.h, so remove the include.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/staging/iio/dac/ad5064.c | 1 -
> drivers/staging/iio/dac/ad5360.c | 1 -
> drivers/staging/iio/dac/ad5380.c | 2 --
> drivers/staging/iio/dac/ad5421.c | 1 -
> drivers/staging/iio/dac/ad5446.c | 1 -
> drivers/staging/iio/dac/ad5504.c | 2 +-
> drivers/staging/iio/dac/ad5624r_spi.c | 2 +-
> drivers/staging/iio/dac/ad5686.c | 1 -
> drivers/staging/iio/dac/ad5764.c | 1 -
> drivers/staging/iio/dac/ad5791.c | 2 +-
> 10 files changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/iio/dac/ad5064.c b/drivers/staging/iio/dac/ad5064.c
> index 2394f05..276af02 100644
> --- a/drivers/staging/iio/dac/ad5064.c
> +++ b/drivers/staging/iio/dac/ad5064.c
> @@ -18,7 +18,6 @@
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dac.h"
>
> #define AD5064_MAX_DAC_CHANNELS 8
> #define AD5064_MAX_VREFS 4
> diff --git a/drivers/staging/iio/dac/ad5360.c b/drivers/staging/iio/dac/ad5360.c
> index 26cac42..0304079 100644
> --- a/drivers/staging/iio/dac/ad5360.c
> +++ b/drivers/staging/iio/dac/ad5360.c
> @@ -18,7 +18,6 @@
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dac.h"
>
> #define AD5360_CMD(x) ((x) << 22)
> #define AD5360_ADDR(x) ((x) << 16)
> diff --git a/drivers/staging/iio/dac/ad5380.c b/drivers/staging/iio/dac/ad5380.c
> index 7a35cc6..5dfb445 100644
> --- a/drivers/staging/iio/dac/ad5380.c
> +++ b/drivers/staging/iio/dac/ad5380.c
> @@ -20,8 +20,6 @@
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dac.h"
> -
>
> #define AD5380_REG_DATA(x) (((x) << 2) | 3)
> #define AD5380_REG_OFFSET(x) (((x) << 2) | 2)
> diff --git a/drivers/staging/iio/dac/ad5421.c b/drivers/staging/iio/dac/ad5421.c
> index ffbd4c2..ea2f83b 100644
> --- a/drivers/staging/iio/dac/ad5421.c
> +++ b/drivers/staging/iio/dac/ad5421.c
> @@ -19,7 +19,6 @@
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> #include <linux/iio/events.h>
> -#include "dac.h"
> #include "ad5421.h"
>
>
> diff --git a/drivers/staging/iio/dac/ad5446.c b/drivers/staging/iio/dac/ad5446.c
> index b6b7eec..f769b74 100644
> --- a/drivers/staging/iio/dac/ad5446.c
> +++ b/drivers/staging/iio/dac/ad5446.c
> @@ -20,7 +20,6 @@
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dac.h"
>
> #include "ad5446.h"
>
> diff --git a/drivers/staging/iio/dac/ad5504.c b/drivers/staging/iio/dac/ad5504.c
> index 19e65e1..07b31f4 100644
> --- a/drivers/staging/iio/dac/ad5504.c
> +++ b/drivers/staging/iio/dac/ad5504.c
> @@ -19,7 +19,7 @@
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> #include <linux/iio/events.h>
> -#include "dac.h"
> +
> #include "ad5504.h"
>
> static int ad5504_spi_write(struct spi_device *spi, u8 addr, u16 val)
> diff --git a/drivers/staging/iio/dac/ad5624r_spi.c b/drivers/staging/iio/dac/ad5624r_spi.c
> index 2ce0544..ef6a320 100644
> --- a/drivers/staging/iio/dac/ad5624r_spi.c
> +++ b/drivers/staging/iio/dac/ad5624r_spi.c
> @@ -18,7 +18,7 @@
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dac.h"
> +
> #include "ad5624r.h"
>
> static int ad5624r_spi_write(struct spi_device *spi,
> diff --git a/drivers/staging/iio/dac/ad5686.c b/drivers/staging/iio/dac/ad5686.c
> index a3881d7..cf833c9 100644
> --- a/drivers/staging/iio/dac/ad5686.c
> +++ b/drivers/staging/iio/dac/ad5686.c
> @@ -18,7 +18,6 @@
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dac.h"
>
> #define AD5686_DAC_CHANNELS 4
>
> diff --git a/drivers/staging/iio/dac/ad5764.c b/drivers/staging/iio/dac/ad5764.c
> index 03dbd93..ffce304 100644
> --- a/drivers/staging/iio/dac/ad5764.c
> +++ b/drivers/staging/iio/dac/ad5764.c
> @@ -18,7 +18,6 @@
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dac.h"
>
> #define AD5764_REG_SF_NOP 0x0
> #define AD5764_REG_SF_CONFIG 0x1
> diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c
> index ad33725..4e955ed 100644
> --- a/drivers/staging/iio/dac/ad5791.c
> +++ b/drivers/staging/iio/dac/ad5791.c
> @@ -19,7 +19,7 @@
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dac.h"
> +
> #include "ad5791.h"
>
> static int ad5791_spi_write(struct spi_device *spi, u8 addr, u32 val)
prev parent reply other threads:[~2012-05-12 18:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 17:04 [PATCH 1/3] staging:iio:dac: Remove unused dac.h includes Lars-Peter Clausen
2012-05-11 17:04 ` [PATCH 2/3] staging:iio:dac:max517: Convert to channel spec Lars-Peter Clausen
2012-05-12 18:51 ` Jonathan Cameron
2012-05-12 21:44 ` Roland Stigge
2012-05-13 7:25 ` Lars-Peter Clausen
2012-05-13 9:06 ` Roland Stigge
2012-05-13 9:20 ` Lars-Peter Clausen
2012-05-13 9:41 ` Roland Stigge
2012-05-13 15:03 ` Lars-Peter Clausen
2012-05-14 14:31 ` Lars-Peter Clausen
2012-05-14 14:39 ` Jonathan Cameron
2012-05-11 17:04 ` [PATCH 3/3] staging:iio:dac: Remove dac.h Lars-Peter Clausen
2012-05-12 18:52 ` Jonathan Cameron
2012-05-12 18:20 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAEAA02.7060500@kernel.org \
--to=jic23@kernel.org \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.