All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/3] staging:iio:dac:max517: Convert to channel spec
Date: Sat, 12 May 2012 23:44:13 +0200	[thread overview]
Message-ID: <4FAED9AD.4020803@antcom.de> (raw)
In-Reply-To: <4FAEB14A.8020408@kernel.org>

Hi,

On 12/05/12 20:51, Jonathan Cameron wrote:
> On 05/11/2012 06:04 PM, Lars-Peter Clausen wrote:
>> Convert the max517 driver to channel spec. As part of the conversion the
>> "out_voltage_1&2_raw" property, which updates both channel 1 and 2
>> simultaneously with the same value, is lost, since this is not really covered by
>> the IIO spec.
> We'll have to introduce a buffered option for output at somepoint to
> cover the equivalent of that out_voltage_1&2_raw attribute.
> 
> Roland, how vital was that to you?

I'm generally fine with the proposed changes and can ack it. However, we
should provide a replacement for the old "1&2" attribute. It supports a
certain hardware feature of this chip. No need to sacrifice it.

Thanks,

Roland

  reply	other threads:[~2012-05-12 21:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 17:04 [PATCH 1/3] staging:iio:dac: Remove unused dac.h includes Lars-Peter Clausen
2012-05-11 17:04 ` [PATCH 2/3] staging:iio:dac:max517: Convert to channel spec Lars-Peter Clausen
2012-05-12 18:51   ` Jonathan Cameron
2012-05-12 21:44     ` Roland Stigge [this message]
2012-05-13  7:25       ` Lars-Peter Clausen
2012-05-13  9:06         ` Roland Stigge
2012-05-13  9:20           ` Lars-Peter Clausen
2012-05-13  9:41             ` Roland Stigge
2012-05-13 15:03               ` Lars-Peter Clausen
2012-05-14 14:31     ` Lars-Peter Clausen
2012-05-14 14:39       ` Jonathan Cameron
2012-05-11 17:04 ` [PATCH 3/3] staging:iio:dac: Remove dac.h Lars-Peter Clausen
2012-05-12 18:52   ` Jonathan Cameron
2012-05-12 18:20 ` [PATCH 1/3] staging:iio:dac: Remove unused dac.h includes Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAED9AD.4020803@antcom.de \
    --to=stigge@antcom.de \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.