* [PATCH] unaligned.h fix for M68000 core [not found] <68000 unaligned.h> @ 2012-05-13 16:39 ` Luis Alves 2012-05-13 16:40 ` Luis Alves [not found] ` <1336927182-3505-1-git-send-email-ljalvs@gmail.com> 2 siblings, 0 replies; 3+ messages in thread From: Luis Alves @ 2012-05-13 16:39 UTC (permalink / raw) To: linux-m68k, uclinux-dev; +Cc: gerg, Luis Alves Hi all, This patch fixes unaligned memory access for the 68000 core based cpu's. Some time ago, my cpu (68000) was raising address/bus error's when mounting cifs shares (didn't bother to debug it at the time). After developing the MMC/SD card driver I was having the same issue when mounting the vfat fs. I've traced the issue down to the 'unaligned.h' file. (I guess nobody has ever used unaligned.h back in the 68328 'era'. Regards, Luis Alves Signed-off-by: Luis Alves <ljalvs@gmail.com> --- arch/m68k/include/asm/unaligned.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/m68k/include/asm/unaligned.h b/arch/m68k/include/asm/unaligned.h index 019caa7..f4043ae 100644 --- a/arch/m68k/include/asm/unaligned.h +++ b/arch/m68k/include/asm/unaligned.h @@ -2,7 +2,7 @@ #define _ASM_M68K_UNALIGNED_H -#ifdef CONFIG_COLDFIRE +#if defined(CONFIG_COLDFIRE) || defined(CONFIG_M68000) #include <linux/unaligned/be_struct.h> #include <linux/unaligned/le_byteshift.h> #include <linux/unaligned/generic.h> -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] unaligned.h fix for M68000 core [not found] <68000 unaligned.h> 2012-05-13 16:39 ` [PATCH] unaligned.h fix for M68000 core Luis Alves @ 2012-05-13 16:40 ` Luis Alves [not found] ` <1336927182-3505-1-git-send-email-ljalvs@gmail.com> 2 siblings, 0 replies; 3+ messages in thread From: Luis Alves @ 2012-05-13 16:40 UTC (permalink / raw) To: linux-m68k; +Cc: Luis Alves Hi all, This patch fixes unaligned memory access for the 68000 core based cpu's. Some time ago, my cpu (68000) was raising address/bus error's when mounting cifs shares (didn't bother to debug it at the time). After developing the MMC/SD card driver I was having the same issue when mounting the vfat fs. I've traced the issue down to the 'unaligned.h' file. (I guess nobody has ever used unaligned.h back in the 68328 'era'. Regards, Luis Alves Signed-off-by: Luis Alves <ljalvs@gmail.com> --- arch/m68k/include/asm/unaligned.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/m68k/include/asm/unaligned.h b/arch/m68k/include/asm/unaligned.h index 019caa7..f4043ae 100644 --- a/arch/m68k/include/asm/unaligned.h +++ b/arch/m68k/include/asm/unaligned.h @@ -2,7 +2,7 @@ #define _ASM_M68K_UNALIGNED_H -#ifdef CONFIG_COLDFIRE +#if defined(CONFIG_COLDFIRE) || defined(CONFIG_M68000) #include <linux/unaligned/be_struct.h> #include <linux/unaligned/le_byteshift.h> #include <linux/unaligned/generic.h> -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1336927182-3505-1-git-send-email-ljalvs@gmail.com>]
* Re: [PATCH] unaligned.h fix for M68000 core [not found] ` <1336927182-3505-1-git-send-email-ljalvs@gmail.com> @ 2012-05-14 1:10 ` Greg Ungerer 0 siblings, 0 replies; 3+ messages in thread From: Greg Ungerer @ 2012-05-14 1:10 UTC (permalink / raw) To: Luis Alves; +Cc: linux-m68k, uclinux-dev Hi Luis, On 14/05/12 02:39, Luis Alves wrote: > This patch fixes unaligned memory access for the 68000 core based cpu's. > > Some time ago, my cpu (68000) was raising address/bus error's when mounting cifs shares (didn't bother to debug it at the time). > After developing the MMC/SD card driver I was having the same issue when mounting the vfat fs. > > I've traced the issue down to the 'unaligned.h' file. (I guess nobody has ever used unaligned.h back in the 68328 'era'. Looks good, thanks. I'll apply it to the m68knommu git tree. Regards Greg > Signed-off-by: Luis Alves<ljalvs@gmail.com> > --- > arch/m68k/include/asm/unaligned.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/m68k/include/asm/unaligned.h b/arch/m68k/include/asm/unaligned.h > index 019caa7..f4043ae 100644 > --- a/arch/m68k/include/asm/unaligned.h > +++ b/arch/m68k/include/asm/unaligned.h > @@ -2,7 +2,7 @@ > #define _ASM_M68K_UNALIGNED_H > > > -#ifdef CONFIG_COLDFIRE > +#if defined(CONFIG_COLDFIRE) || defined(CONFIG_M68000) > #include<linux/unaligned/be_struct.h> > #include<linux/unaligned/le_byteshift.h> > #include<linux/unaligned/generic.h> -- ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-14 1:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <68000 unaligned.h>
2012-05-13 16:39 ` [PATCH] unaligned.h fix for M68000 core Luis Alves
2012-05-13 16:40 ` Luis Alves
[not found] ` <1336927182-3505-1-git-send-email-ljalvs@gmail.com>
2012-05-14 1:10 ` Greg Ungerer
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.