Re: [PATCH v6] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller

[Josh Wu <josh.wu@atmel.com>]

Hi, Artem

On 5/11/2012 8:11 PM, Artem Bityutskiy wrote:
> On Wed, 2012-05-09 at 19:00 +0800, Josh Wu wrote:
>> The Programmable Multibit ECC (PMECC) controller is a programmable binary
>> BCH(Bose, Chaudhuri and Hocquenghem) encoder and decoder. This controller
>> can be used to support both SLC and MLC NAND Flash devices. It supports to
>> generate ECC to correct 2, 4, 8, 12 or 24 bits of error per sector of data.
>>
>> To use this driver, the user needs to pass in the correction capability and
>> the sector size.
>>
>> This driver has been tested on AT91SAM9X5-EK and AT91SAM9N12-EK with JFFS2,
>> YAFFS2, UBIFS and mtd-utils.
>>
>> Signed-off-by: Hong Xu<hong.xu@atmel.com>
>> Signed-off-by: Josh Wu<josh.wu@atmel.com>
> The patch is really big - please, split it on more smaller patches.

OK, I can spit to more patches.

> Besides, it does not compile for me:
>
> ERROR: "of_flat_dt_is_compatible" [drivers/mtd/nand/atmel_nand.ko] undefined!
> ERROR: "of_get_flat_dt_root" [drivers/mtd/nand/atmel_nand.ko] undefined!
> make[2]: *** [__modpost] Error 1

This function will depend on CONFIG_OF_FLATTREE and 
CONFIG_OF_EARLY_FLATTREE.

Would it be possible that CONFIG_OF is defined, but above two config 
options are not defined? Can I see you .config file go get more details?


Best Regards,
Josh Wu