All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bluez version 4.99 is required.
@ 2012-05-14 19:52 Marko Saukko
  2012-05-14 20:03 ` Marcel Holtmann
  0 siblings, 1 reply; 3+ messages in thread
From: Marko Saukko @ 2012-05-14 19:52 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

bluez 4.99 introduced key_size to bt_security struct that is used in
ofono, thus the requirement needs to be higher.

Signed-off-by: Marko Saukko <marko.saukko@gmail.com>
---
 configure.ac |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 251a726..9f77a3c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -177,8 +177,8 @@ AC_ARG_ENABLE(bluetooth, AC_HELP_STRING([--disable-bluetooth],
 				[disable Bluetooth modem support]),
 					[enable_bluetooth=${enableval}])
 if (test "${enable_bluetooth}" != "no"); then
-	PKG_CHECK_MODULES(BLUEZ, bluez >= 4.30, dummy=yes,
-			AC_MSG_ERROR(Bluetooth library >= 4.30 is required))
+	PKG_CHECK_MODULES(BLUEZ, bluez >= 4.99, dummy=yes,
+			AC_MSG_ERROR(Bluetooth library >= 4.99 is required))
 fi
 AC_SUBST(BLUEZ_CFLAGS)
 AC_SUBST(BLUEZ_LIBS)
-- 
1.7.7


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] bluez version 4.99 is required.
  2012-05-14 19:52 [PATCH] bluez version 4.99 is required Marko Saukko
@ 2012-05-14 20:03 ` Marcel Holtmann
  2012-05-14 20:11   ` Marko Saukko
  0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2012-05-14 20:03 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

Hi Marko,

> bluez 4.99 introduced key_size to bt_security struct that is used in
> ofono, thus the requirement needs to be higher.
> 
> Signed-off-by: Marko Saukko <marko.saukko@gmail.com>
> ---
>  configure.ac |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

patch has been applied.

However keep in mind no Signed-off-by line here. I fixed that up for you
now. Next time, it is your job.

Regards

Marcel



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] bluez version 4.99 is required.
  2012-05-14 20:03 ` Marcel Holtmann
@ 2012-05-14 20:11   ` Marko Saukko
  0 siblings, 0 replies; 3+ messages in thread
From: Marko Saukko @ 2012-05-14 20:11 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

On 14.05.2012 23:03, Marcel Holtmann wrote:
> Hi Marko,
>
>> bluez 4.99 introduced key_size to bt_security struct that is used in
>> ofono, thus the requirement needs to be higher.
>>
>> Signed-off-by: Marko Saukko<marko.saukko@gmail.com>
>> ---
>>   configure.ac |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> patch has been applied.
>
> However keep in mind no Signed-off-by line here. I fixed that up for you
> now. Next time, it is your job.
>
> Regards
>
> Marcel
>
>

Ah, that was my bad and declining the patch would have been ok as well. 
It is easier to learn when you do it yourself IMO. :)

Regards,
Marko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-05-14 20:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-14 19:52 [PATCH] bluez version 4.99 is required Marko Saukko
2012-05-14 20:03 ` Marcel Holtmann
2012-05-14 20:11   ` Marko Saukko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.