Re: [Qemu-devel] Posting a patch?

[Erik Rull <spamfolder@rdsoftware.de>]

Stefan Weil wrote:
> Am 14.05.2012 22:12, schrieb Erik Rull:
>> Hi all,
>>
>> is there a guideline or manual how to send a patch to the qemu mailing
>> list? It seems as if this can be done somehow automagically using the
>> local git repository, but I didn't find a tool to do that.
>>
>> Thanks!
>>
>> Best regards,
>>
>> Erik
>
> Hi Erik,
>
> if you use git for sending, you don't risk that your mailer destroys the
> format of your patch.
> I usually use these commands to send a single patch from the QEMU source
> directory:
>
> # Create the patch file (name depends on the subject line of your patch).
> git format-patch HEAD^
> # Check the patch (fix any issues which were found).
> scripts/checkpatch.pl 0001-*
> # Get the maintainer who is responsible (there is not always one).
> scripts/get_maintainer.pl 0001-*
> # Send the patch.
> git send-email --to qemu-devel@nongnu.org --to "n.n <address@domain>" 0001-*
>
> Please read also http://wiki.qemu.org/Contribute/SubmitAPatch.
>
> Regards,
>
> Stefan W.
>

Thanks!

So I started a git pull to get the latest master and as well a git reset 
--hard to assert that there are no modifications remaining.

Then I modified the file ui/x_keymap.c and called then the
git format-patch HEAD^

But I get 3 patches that are definitively not related to my changes:
erik@debian:~/qemu-test/qemu$ git format-patch HEAD^
0001-coroutine-Fix-setup-of-sigaltstack-coroutines.patch
0002-qcow2-Don-t-ignore-failure-to-clear-autoclear-flags.patch
0003-qemu-img-Fix-segmentation-fault.patch
erik@debian:~/qemu-test/qemu$

Using git diff shows my real changes...

So I created a patch file called keymap.patch but git format-patch HEAD^ 
just ignores it..

Maybe I missed something important...

Best regards,

Erik