From: Stefan Weil <sw@weilnetz.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Erik Rull <erik.rull@rdsoftware.de>
Subject: Re: [Qemu-devel] Posting a patch?
Date: Mon, 14 May 2012 23:08:01 +0200 [thread overview]
Message-ID: <4FB17431.5020209@weilnetz.de> (raw)
In-Reply-To: <4FB17210.4030609@codemonkey.ws>
Am 14.05.2012 22:58, schrieb Anthony Liguori:
> On 05/14/2012 03:53 PM, Peter Maydell wrote:
>> On 14 May 2012 21:30, Stefan Weil<sw@weilnetz.de> wrote:
>>> if you use git for sending, you don't risk that your mailer destroys
>>> the
>>> format of your patch.
>>> I usually use these commands to send a single patch from the QEMU
>>> source
>>> directory:
>>>
>>> # Create the patch file (name depends on the subject line of
>>> your patch).
>>> git format-patch HEAD^
>>> # Check the patch (fix any issues which were found).
>>> scripts/checkpatch.pl 0001-*
>>> # Get the maintainer who is responsible (there is not always one).
>>> scripts/get_maintainer.pl 0001-*
>>> # Send the patch.
>>> git send-email --to qemu-devel@nongnu.org --to
>>> "n.n<address@domain>"
>>> 0001-*
>>
>> If you do this more than once in the same git tree you'll regret it :-)
>> ("git send-email 0001-*" will happily retransmit all the old 0001-foo
>> patches along with the new one...) I use git-format-patch's -o option to
>> put my sent patches in a separate directory so they don't clutter up the
>> working tree.
>
> You can also do:
>
> git send-email --to=qemu-devel@nongnu.org HEAD~1
>
> Which avoids any clutter.
... and also avoids nasty messages from checkpatch.pl :-)
But as this method tends to add clutter to the qemu code
or to the mailing list, it should be avoided.
>
> Regards,
>
> Anthony Liguori
Cheers,
Stefan W.
next prev parent reply other threads:[~2012-05-14 21:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 20:12 [Qemu-devel] Posting a patch? Erik Rull
2012-05-14 20:30 ` Stefan Weil
2012-05-14 20:53 ` Peter Maydell
2012-05-14 20:58 ` Anthony Liguori
2012-05-14 21:04 ` Eric Blake
2012-05-14 21:10 ` Erik Rull
2012-05-14 21:20 ` Stefan Weil
2012-05-14 21:29 ` Erik Rull
2012-05-14 21:08 ` Stefan Weil [this message]
2012-05-14 21:14 ` Stefan Weil
2012-05-15 10:18 ` Peter Maydell
2012-05-14 21:06 ` Erik Rull
2012-05-14 21:11 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB17431.5020209@weilnetz.de \
--to=sw@weilnetz.de \
--cc=anthony@codemonkey.ws \
--cc=erik.rull@rdsoftware.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.