All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jordan Uggla <jordan.uggla@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Boot immediately after GRUB_HIDDEN_TIMEOUT
Date: Thu, 17 May 2012 18:21:47 -0700	[thread overview]
Message-ID: <4FB5A42B.5000208@gmail.com> (raw)
In-Reply-To: <4F9D9328.9080303@kiilerich.com>

On 04/29/2012 12:14 PM, Mads Kiilerich wrote:
>        * util/grub.d/00_header.in: Boot immediately after
>        GRUB_HIDDEN_TIMEOUT. Documentation said: "If no key is pressed
>        during that time, boot immediately."
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel

I don't see anything wrong with the current handling of
GRUB_HIDDEN_TIMEOUT and GRUB_TIMEOUT in grub-mkconfig other than it
contradicting the documentation. I would rather fix the documentation
and avoid any possible issues with grub's behavior changing for
existing configurations with regard to these variables upon upgrading
to grub 2.00. 

Below is a patch which fixes the documentation in grub.texi.

-- 
Jordan Uggla (Jordan_U on irc.freenode.net)

=== modified file 'ChangeLog'
--- ChangeLog   2012-05-15 15:17:06 +0000
+++ ChangeLog   2012-05-18 01:07:20 +0000
@@ -1,3 +1,10 @@
+2012-05-17  Jordan Uggla  <jordan.uggla@gmail.com>
+
+       * docs/grub.texi Fix documentation of GRUB_HIDDEN_TIMOUNT to match the
+       actual implementation. Specifically, clarify that the grub menu will
+       be displayed for GRUB_TIMOUT seconds after the hidden timeout has
+       passed.
+
 2012-05-15  Vladimir Serbinenko  <phcoder@gmail.com>
 
        * grub-core/fs/ntfs.c (read_data): Prevent overflow.

=== modified file 'docs/grub.texi'
--- docs/grub.texi      2012-05-03 22:28:53 +0000
+++ docs/grub.texi      2012-05-18 00:49:41 +0000
@@ -1135,7 +1135,11 @@
 
 @item GRUB_HIDDEN_TIMEOUT
 Wait this many seconds for a key to be pressed before displaying the menu.
-If no key is pressed during that time, boot immediately.  Unset by default.
+If no key is pressed during that time, display the menu for the number of
+seconds specified in GRUB_TIMEOUT before booting the default entry. We expect
+that most people who use GRUB_HIDDEN_TIMEOUT will want to have GRUB_TIMEOUT set 
+to @samp{0} so that the menu is not displayed at all unless a key is pressed.
+Unset by default.
 
 @item GRUB_HIDDEN_TIMEOUT_QUIET
 In conjunction with @samp{GRUB_HIDDEN_TIMEOUT}, set this to @samp{true} to


      reply	other threads:[~2012-05-18  1:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-29 19:14 [PATCH] Boot immediately after GRUB_HIDDEN_TIMEOUT Mads Kiilerich
2012-05-18  1:21 ` Jordan Uggla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB5A42B.5000208@gmail.com \
    --to=jordan.uggla@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.