[-next] DRM_CIRRUS_QEMU breaks build

[-next] DRM_CIRRUS_QEMU breaks build

[Jiri Slaby]

Hi,

when that option is selected to be Y, I'm getting linking errors like:
    (.text+0xefd8d): undefined reference to `ttm_tt_init'
    drivers/built-in.o: In function `cirrus_mm_init':
and many others, like undefined sys_fillrect.

You perhaps have a patch on your queue already and I need not to turn
this into a patch, right :):

--- a/drivers/gpu/drm/cirrus/Kconfig
+++ b/drivers/gpu/drm/cirrus/Kconfig
@@ -1,10 +1,11 @@
 config DRM_CIRRUS_QEMU
        tristate "Cirrus driver for QEMU emulated device"
        depends on DRM && PCI && EXPERIMENTAL
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
+       select FB_SYS_FILLRECT
+       select FB_SYS_COPYAREA
+       select FB_SYS_IMAGEBLIT
        select DRM_KMS_HELPER
+       select DRM_TTM
        help
         This is a KMS driver for emulated cirrus device in qemu.
         It is *NOT* intended for real cirrus devices. This requires

regards,
-- 
js
suse labs

[-next] DRM_CIRRUS_QEMU breaks build

[Jiri Slaby]

Hi,

when that option is selected to be Y, I'm getting linking errors like:
    (.text+0xefd8d): undefined reference to `ttm_tt_init'
    drivers/built-in.o: In function `cirrus_mm_init':
and many others, like undefined sys_fillrect.

You perhaps have a patch on your queue already and I need not to turn
this into a patch, right :):

--- a/drivers/gpu/drm/cirrus/Kconfig
+++ b/drivers/gpu/drm/cirrus/Kconfig
@@ -1,10 +1,11 @@
 config DRM_CIRRUS_QEMU
        tristate "Cirrus driver for QEMU emulated device"
        depends on DRM && PCI && EXPERIMENTAL
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
+       select FB_SYS_FILLRECT
+       select FB_SYS_COPYAREA
+       select FB_SYS_IMAGEBLIT
        select DRM_KMS_HELPER
+       select DRM_TTM
        help
         This is a KMS driver for emulated cirrus device in qemu.
         It is *NOT* intended for real cirrus devices. This requires

regards,
-- 
js
suse labs