All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "lrg@ti.com" <lrg@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: core: use correct device for device supply lookup
Date: Sun, 20 May 2012 17:40:03 +0530	[thread overview]
Message-ID: <4FB8DF1B.5080206@nvidia.com> (raw)
In-Reply-To: <20120520090112.GE16590@opensource.wolfsonmicro.com>

On Sunday 20 May 2012 02:31 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Sun, May 20, 2012 at 01:04:05PM +0530, Laxman Dewangan wrote:
>
>>          ldo2_reg: ldo2 {
>>              ::::::::
>>              /** regulatr entry */
>>              ::::::::::::
>>              ldo2-supply =<&ldo1_reg>; /* So ldo1 supply the ldo2. */
> This mapping should be moved up to the chip top level; this is just like
> any other supply for the chip.
>

Ok, After moving this mapping (ldo2-supply = <&ldo1_reg>;) to top level 
under tps65911,  then it worked without core driver changes.
Becasue at this time, the ldo2->desc->supply_name = "ldo2" get find on 
the chip level node and then it return the regulator node properly.


>> ldo1 registration went fine.
>> During ldo2 registration, I passed the regulator_desc->supply_name as ldo2.
> I'd be somewhat surprised if this is what the pin is actually called,
> idiomatically the supply name should be whatever the pin is named on the
> chip.
Yes, I need to add the code in tps65911-regulator.c to use the proper 
pin name as per datasheet for looking for input supply. Like "vcc3" is 
the pin name for ldo6,ldo7 and ldo8 supply and hence look for 
"vcc3-supply" in the chip level rather than "ldo6-supply" or 
"ldo7-supply" etc.
I will post the patch for these changes.

  parent reply	other threads:[~2012-05-20 12:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-19 14:14 [PATCH] regulator: core: use correct device for device supply lookup Laxman Dewangan
2012-05-19 16:41 ` Mark Brown
2012-05-19 17:14   ` Laxman Dewangan
2012-05-19 17:20     ` Laxman Dewangan
2012-05-19 17:40       ` Mark Brown
2012-05-19 17:56         ` Laxman Dewangan
2012-05-19 18:26           ` Mark Brown
2012-05-19 19:03             ` Laxman Dewangan
2012-05-19 20:50               ` Mark Brown
2012-05-19 21:13                 ` Laxman Dewangan
2012-05-19 23:13                   ` Mark Brown
2012-05-20  7:34                     ` Laxman Dewangan
2012-05-20  9:01                       ` Mark Brown
     [not found]                         ` <4FB8C9EF.7010400@nvidia.com>
2012-05-20 12:06                           ` Mark Brown
2012-05-20 12:14                             ` Laxman Dewangan
2012-05-20 12:10                         ` Laxman Dewangan [this message]
2012-05-19 17:28     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB8DF1B.5080206@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.