All of lore.kernel.org
 help / color / mirror / Atom feed
From: hs@denx.de (Heiko Schocher)
To: linux-arm-kernel@lists.infradead.org
Subject: usb, davinci: usb 2.0 problem on an am1808 based board
Date: Mon, 21 May 2012 08:10:33 +0200	[thread overview]
Message-ID: <4FB9DC59.6050300@denx.de> (raw)
In-Reply-To: <A73F36158E33644199EB82C5EC81C7BC3E97C9C1@DBDE01.ent.ti.com>

Hello Manjunathappa,

Manjunathappa, Prakash wrote:
> Hi Heiko,
> 
> I do not know how putting delay helped MSC device detection.
> Can you please check if MUSB is coming up in "b_idle" state(by
> $cat /sys/devices/platform/musb-da8xx/musb-hdrc/mode)?
> State should move to b_peripheral on connecting gadget cable.

We have connected the USB0_ID pin to ground -> host only mode, so
I could not try this.

> If you connect MSC device via mini-A connector, state should change to "a_host".
> OTG timer is responsible for above state changes, can you please check if below
> changes are present?
> diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c index 4da7492..a1a692e 100644
> --- a/drivers/usb/musb/da8xx.c
> +++ b/drivers/usb/musb/da8xx.c
> @@ -76,6 +76,7 @@
>  #define DA8XX_INTR_TX_SHIFT    0
>  #define DA8XX_INTR_TX_MASK     (DA8XX_USB_TX_EP_MASK << DA8XX_INTR_TX_SHIFT)
> 
> +#define A_WAIT_BCON_TIMEOUT     1100            /* in ms */
>  #define DA8XX_MENTOR_CORE_OFFSET 0x400
> 
>  #define CFGCHIP2       IO_ADDRESS(DA8XX_SYSCFG0_BASE + DA8XX_CFGCHIP2_REG)
> @@ -443,6 +444,7 @@ static int da8xx_musb_init(struct musb *musb)
>                  rev, __raw_readl(CFGCHIP2),
>                  musb_readb(reg_base, DA8XX_USB_CTRL_REG));
> 
> +       musb->a_wait_bcon = A_WAIT_BCON_TIMEOUT;
>         musb->isr = da8xx_musb_interrupt;
>         return 0;
>  fail:

No, this change is not in current mainline ...

Added this patch, and I get:

$ make -s uImage
drivers/usb/musb/da8xx.c: In function 'da8xx_musb_init':
drivers/usb/musb/da8xx.c:448:22: error: 'A_WAIT_BCON_TIMEOUT' undeclared (first use in this function)
drivers/usb/musb/da8xx.c:448:22: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [drivers/usb/musb/da8xx.o] Error 1
make[2]: *** [drivers/usb/musb] Error 2
make[1]: *** [drivers/usb] Error 2
make: *** [drivers] Error 2
$

Do you mean

musb->a_wait_bcon = OTG_TIME_A_WAIT_BCON;

? This is setup in musb_core.c::allocate_instance() as Sergei Shtylyov
already commented ... nevertheless tried with this define your patch,
and my USB stick gets detected too...

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

  parent reply	other threads:[~2012-05-21  6:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4EBC9DF1.90604@denx.de>
     [not found] ` <20111111091912.GB19090@legolas.emea.dhcp.ti.com>
     [not found]   ` <4EBEB29E.50705@mvista.com>
     [not found]     ` <4EC0F87B.4010104@denx.de>
2012-05-04 10:10       ` usb, davinci: usb 2.0 problem on an am1808 based board Heiko Schocher
2012-05-17  6:37         ` Heiko Schocher
2012-05-18 10:07           ` Manjunathappa, Prakash
2012-05-18 11:27             ` Sergei Shtylyov
2012-05-21 10:12               ` Manjunathappa, Prakash
2012-05-21  6:10             ` Heiko Schocher [this message]
2012-05-21 10:18               ` Manjunathappa, Prakash
2012-05-22  7:22                 ` Heiko Schocher
2012-05-29 14:22                   ` Heiko Schocher
2012-06-27  4:36                     ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB9DC59.6050300@denx.de \
    --to=hs@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.