From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Colin Cross <ccross@android.com>
Cc: Kevin Hilman <khilman@ti.com>, Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org,
Amit Kucheria <amit.kucheria@linaro.org>,
linux-pm@lists.linux-foundation.org,
Arjan van de Ven <arjan@linux.intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] bug fixes for coupled cpuidle
Date: Mon, 21 May 2012 12:14:49 +0530 [thread overview]
Message-ID: <4FB9E461.9060405@ti.com> (raw)
In-Reply-To: <1337364324-12171-1-git-send-email-ccross@android.com>
On Friday 18 May 2012 11:35 PM, Colin Cross wrote:
> The last modifications made to the coupled cpuidle patches introduced
> two bugs that I missed during testing. The online count was never
> initialized, causing coupled idle to always wait and never enter the
> ready loop. That hid the second bug, the ready count could never be
> decremented after exiting idle.
>
> Len, these two patches could be squashed into patch 3 of the original
> set. If you do squash them, you could also add Rafael's tags to the
> set (Reviewed-by on 1 and 2, acked-by on 3). Or I can reupload the
> whole stack as v5 if you prefer.
I confirm that these two fixes are needed to get couple idle
v4 series working.
Regards
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] bug fixes for coupled cpuidle
Date: Mon, 21 May 2012 12:14:49 +0530 [thread overview]
Message-ID: <4FB9E461.9060405@ti.com> (raw)
In-Reply-To: <1337364324-12171-1-git-send-email-ccross@android.com>
On Friday 18 May 2012 11:35 PM, Colin Cross wrote:
> The last modifications made to the coupled cpuidle patches introduced
> two bugs that I missed during testing. The online count was never
> initialized, causing coupled idle to always wait and never enter the
> ready loop. That hid the second bug, the ready count could never be
> decremented after exiting idle.
>
> Len, these two patches could be squashed into patch 3 of the original
> set. If you do squash them, you could also add Rafael's tags to the
> set (Reviewed-by on 1 and 2, acked-by on 3). Or I can reupload the
> whole stack as v5 if you prefer.
I confirm that these two fixes are needed to get couple idle
v4 series working.
Regards
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Colin Cross <ccross@android.com>
Cc: Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-pm@lists.linux-foundation.org,
Kevin Hilman <khilman@ti.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Deepthi Dharwar <deepthi@linux.vnet.ibm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH 0/2] bug fixes for coupled cpuidle
Date: Mon, 21 May 2012 12:14:49 +0530 [thread overview]
Message-ID: <4FB9E461.9060405@ti.com> (raw)
In-Reply-To: <1337364324-12171-1-git-send-email-ccross@android.com>
On Friday 18 May 2012 11:35 PM, Colin Cross wrote:
> The last modifications made to the coupled cpuidle patches introduced
> two bugs that I missed during testing. The online count was never
> initialized, causing coupled idle to always wait and never enter the
> ready loop. That hid the second bug, the ready count could never be
> decremented after exiting idle.
>
> Len, these two patches could be squashed into patch 3 of the original
> set. If you do squash them, you could also add Rafael's tags to the
> set (Reviewed-by on 1 and 2, acked-by on 3). Or I can reupload the
> whole stack as v5 if you prefer.
I confirm that these two fixes are needed to get couple idle
v4 series working.
Regards
Santosh
next prev parent reply other threads:[~2012-05-21 6:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 18:05 [PATCH 0/2] bug fixes for coupled cpuidle Colin Cross
2012-05-18 18:05 ` Colin Cross
2012-05-18 18:05 ` Colin Cross
2012-05-18 18:05 ` [PATCH 1/2] cpuidle: coupled: fix count of online cpus Colin Cross
2012-05-18 18:05 ` Colin Cross
2012-05-18 18:05 ` Colin Cross
2012-05-18 18:05 ` [PATCH 2/2] cpuidle: coupled: fix decrementing ready count Colin Cross
2012-05-18 18:05 ` Colin Cross
2012-05-18 18:05 ` Colin Cross
2012-05-21 6:44 ` Santosh Shilimkar [this message]
2012-05-21 6:44 ` [PATCH 0/2] bug fixes for coupled cpuidle Santosh Shilimkar
2012-05-21 6:44 ` Santosh Shilimkar
2012-05-25 22:38 ` [linux-pm] " Kevin Hilman
2012-05-25 22:38 ` Kevin Hilman
2012-06-02 5:50 ` Len Brown
2012-06-02 5:50 ` [linux-pm] " Len Brown
2012-06-02 5:50 ` Len Brown
2012-06-02 6:41 ` Colin Cross
2012-06-05 18:12 ` [linux-pm] " Kevin Hilman
2012-06-05 18:12 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB9E461.9060405@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=amit.kucheria@linaro.org \
--cc=arjan@linux.intel.com \
--cc=ccross@android.com \
--cc=khilman@ti.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.