All of lore.kernel.org
 help / color / mirror / Atom feed
From: frq09524 <ludovic.barre@stericsson.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Michal Simek <monstr@monstr.eu>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Brian Swetland <swetland@google.com>,
	Iliyan Malchev <malchev@google.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Grant Likely <grant.likely@secretlab.ca>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Mark Grosen <mgrosen@ti.com>,
	John Williams <john.williams@petalogix.com>,
	Loic PALLARDY <loic.pallardy@stericsson.com>,
	Omar Ramirez Luna <omar.luna@linaro.org>,
	Guzman Lugo Fernando <fernando.lugo@ti.com>,
	Anna Suman <s-anna@ti.com>, Clark Rob <rob@ti.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Saravana Kannan <skannan@codeaurora.org>,
	David Brown <davidb@codeaurora.org>,
	Kieran Bingham <kieranbingham@gmail.com>,
	Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 1/7] remoteproc: resource table overhaul
Date: Tue, 22 May 2012 14:51:23 +0200	[thread overview]
Message-ID: <4FBB8BCB.3010802@stericsson.com> (raw)
In-Reply-To: <CAK=WgbYKMh8oifeC-A9LYq8GV_Nb7L8wc198YZujGEsp9mmvsw@mail.gmail.com>

hi Ohad

In my previous patch, to find the correct subdevice that match with 
physical memory, I used pa member of rproc_mem_entry.
but today in these 2 resources: fw_rsc_trace, fw_rsc_vdev_vring, pa 
menber has been removed.

for fw_rsc_trace it's not a problem, because use rproc_da_to_va and 
carveout feature.

but for fw_rsc_vdev_vring, I think use da member, like this.

dev = rproc_dma_find_dev(rproc, (phys_addr_t) vring->da);
va = dma_alloc_coherent(dev, size, &dma, GFP_KERNEL);
if (!va) {
	dev_err(dev, "dma_alloc_coherent failed\n");
	return -EINVAL;
}

are you OK ?

/BR
Ludovic Barré

On 05/22/2012 11:22 AM, Ohad Ben-Cohen wrote:
> Hi Ludovic,
>
> On Tue, May 22, 2012 at 12:14 PM, frq09524<ludovic.barre@stericsson.com>  wrote:
>> Ohad, for alignment I can take the latest branch of kernel.org (remoteproc)
>> branch for-next?
>
> Sure, it's pretty much updated sans a few simple changes.
>
> Thanks,
> Ohad.

WARNING: multiple messages have this Message-ID (diff)
From: ludovic.barre@stericsson.com (frq09524)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] remoteproc: resource table overhaul
Date: Tue, 22 May 2012 14:51:23 +0200	[thread overview]
Message-ID: <4FBB8BCB.3010802@stericsson.com> (raw)
In-Reply-To: <CAK=WgbYKMh8oifeC-A9LYq8GV_Nb7L8wc198YZujGEsp9mmvsw@mail.gmail.com>

hi Ohad

In my previous patch, to find the correct subdevice that match with 
physical memory, I used pa member of rproc_mem_entry.
but today in these 2 resources: fw_rsc_trace, fw_rsc_vdev_vring, pa 
menber has been removed.

for fw_rsc_trace it's not a problem, because use rproc_da_to_va and 
carveout feature.

but for fw_rsc_vdev_vring, I think use da member, like this.

dev = rproc_dma_find_dev(rproc, (phys_addr_t) vring->da);
va = dma_alloc_coherent(dev, size, &dma, GFP_KERNEL);
if (!va) {
	dev_err(dev, "dma_alloc_coherent failed\n");
	return -EINVAL;
}

are you OK ?

/BR
Ludovic Barr?

On 05/22/2012 11:22 AM, Ohad Ben-Cohen wrote:
> Hi Ludovic,
>
> On Tue, May 22, 2012 at 12:14 PM, frq09524<ludovic.barre@stericsson.com>  wrote:
>> Ohad, for alignment I can take the latest branch of kernel.org (remoteproc)
>> branch for-next?
>
> Sure, it's pretty much updated sans a few simple changes.
>
> Thanks,
> Ohad.

  reply	other threads:[~2012-05-22 12:51 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-01  8:11 [PATCH 0/7] remoteproc: additional virtio support Ohad Ben-Cohen
2012-03-01  8:11 ` Ohad Ben-Cohen
2012-03-01  8:11 ` Ohad Ben-Cohen
2012-03-01  8:11 ` [PATCH 1/7] remoteproc: resource table overhaul Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-16 14:57   ` Michal Simek
2012-03-16 14:57     ` Michal Simek
2012-03-17  6:39     ` Ohad Ben-Cohen
2012-03-17  6:39       ` Ohad Ben-Cohen
2012-03-19  7:07       ` Michal Simek
2012-03-19  7:07         ` Michal Simek
2012-05-17 18:45       ` Ohad Ben-Cohen
2012-05-17 18:45         ` Ohad Ben-Cohen
2012-05-21 13:02         ` Michal Simek
2012-05-21 13:02           ` Michal Simek
2012-05-21 14:00           ` Ohad Ben-Cohen
2012-05-21 14:00             ` Ohad Ben-Cohen
2012-05-22  5:51             ` Michal Simek
2012-05-22  5:51               ` Michal Simek
2012-05-22  8:02               ` Ohad Ben-Cohen
2012-05-22  8:02                 ` Ohad Ben-Cohen
2012-05-22  8:02                 ` Ohad Ben-Cohen
2012-05-22  8:18                 ` Michal Simek
2012-05-22  8:18                   ` Michal Simek
2012-05-22  9:14               ` frq09524
2012-05-22  9:14                 ` frq09524
2012-05-22  9:22                 ` Ohad Ben-Cohen
2012-05-22  9:22                   ` Ohad Ben-Cohen
2012-05-22 12:51                   ` frq09524 [this message]
2012-05-22 12:51                     ` frq09524
2012-05-23 12:41                     ` Ohad Ben-Cohen
2012-05-23 12:41                       ` Ohad Ben-Cohen
2012-03-01  8:11 ` [PATCH 2/7] remoteproc: remoteproc_rpmsg -> remoteproc_virtio Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11 ` [PATCH 3/7] remoteproc: safer boot/shutdown order Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11 ` [PATCH 4/7] remoteproc: remove the single rpmsg vdev limitation Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11 ` [PATCH 5/7] remoteproc/omap: remove the mbox_callback limitation Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11 ` [PATCH 6/7] remoteproc: remove the hardcoded vring alignment Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11 ` [PATCH 7/7] remoteproc: cleanup resource table parsing paths Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen
2012-03-01  8:11   ` Ohad Ben-Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBB8BCB.3010802@stericsson.com \
    --to=ludovic.barre@stericsson.com \
    --cc=arnd@arndb.de \
    --cc=davidb@codeaurora.org \
    --cc=fernando.lugo@ti.com \
    --cc=grant.likely@secretlab.ca \
    --cc=john.williams@petalogix.com \
    --cc=kieranbingham@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=loic.pallardy@stericsson.com \
    --cc=malchev@google.com \
    --cc=mgrosen@ti.com \
    --cc=monstr@monstr.eu \
    --cc=ohad@wizery.com \
    --cc=omar.luna@linaro.org \
    --cc=rob@ti.com \
    --cc=rusty@rustcorp.com.au \
    --cc=s-anna@ti.com \
    --cc=sboyd@codeaurora.org \
    --cc=skannan@codeaurora.org \
    --cc=swetland@google.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.