From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC v2 2/2] pinctrl: add pinctrl gpio binding support
Date: Tue, 22 May 2012 11:12:32 -0600 [thread overview]
Message-ID: <4FBBC900.2070003@wwwdotorg.org> (raw)
In-Reply-To: <20120522033501.GB27055@shlinux2.ap.freescale.net>
On 05/21/2012 09:35 PM, Dong Aisheng wrote:
> On Sat, May 19, 2012 at 04:05:46AM +0800, Stephen Warren wrote:
> ...
>>> + np_gpio = of_find_node_by_phandle(phandle);
>>> + if (!np_gpio) {
>>> + dev_err(pctldev->dev,
>>> + "failed to find gpio node(%s)\n",
>>> + np_gpio->name);
>>
>> Perhaps devm_kfree(ranges) here so that if this is called multiple times
>> due to deferred probe, the allocations from the failed attempts don't
>> accumulate. Same for other error paths.
>
> I checked a bit more, it seems the resource will be removed first if there's
> a deffer probe error.
Oh yes of course - that makes sense.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Dong Aisheng <aisheng.dong@freescale.com>
Cc: Dong Aisheng-B29396 <B29396@freescale.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linus.walleij@stericsson.com" <linus.walleij@stericsson.com>
Subject: Re: [PATCH RFC v2 2/2] pinctrl: add pinctrl gpio binding support
Date: Tue, 22 May 2012 11:12:32 -0600 [thread overview]
Message-ID: <4FBBC900.2070003@wwwdotorg.org> (raw)
In-Reply-To: <20120522033501.GB27055@shlinux2.ap.freescale.net>
On 05/21/2012 09:35 PM, Dong Aisheng wrote:
> On Sat, May 19, 2012 at 04:05:46AM +0800, Stephen Warren wrote:
> ...
>>> + np_gpio = of_find_node_by_phandle(phandle);
>>> + if (!np_gpio) {
>>> + dev_err(pctldev->dev,
>>> + "failed to find gpio node(%s)\n",
>>> + np_gpio->name);
>>
>> Perhaps devm_kfree(ranges) here so that if this is called multiple times
>> due to deferred probe, the allocations from the failed attempts don't
>> accumulate. Same for other error paths.
>
> I checked a bit more, it seems the resource will be removed first if there's
> a deffer probe error.
Oh yes of course - that makes sense.
next prev parent reply other threads:[~2012-05-22 17:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 13:12 [PATCH RFC v2 1/2] pinctrl: add pinctrl_add_gpio_ranges function Dong Aisheng
2012-05-18 13:12 ` Dong Aisheng
2012-05-18 13:12 ` [PATCH RFC v2 2/2] pinctrl: add pinctrl gpio binding support Dong Aisheng
2012-05-18 13:12 ` Dong Aisheng
2012-05-18 20:05 ` Stephen Warren
2012-05-18 20:05 ` Stephen Warren
2012-05-21 12:39 ` Dong Aisheng
2012-05-21 12:39 ` Dong Aisheng
2012-05-21 17:09 ` Stephen Warren
2012-05-21 17:09 ` Stephen Warren
2012-05-22 1:00 ` Dong Aisheng
2012-05-22 1:00 ` Dong Aisheng
2012-05-21 17:11 ` Stephen Warren
2012-05-21 17:11 ` Stephen Warren
2012-05-22 1:12 ` Dong Aisheng
2012-05-22 1:12 ` Dong Aisheng
2012-05-22 3:35 ` Dong Aisheng
2012-05-22 3:35 ` Dong Aisheng
2012-05-22 17:12 ` Stephen Warren [this message]
2012-05-22 17:12 ` Stephen Warren
2012-05-18 19:51 ` [PATCH RFC v2 1/2] pinctrl: add pinctrl_add_gpio_ranges function Stephen Warren
2012-05-18 19:51 ` Stephen Warren
2012-05-24 14:29 ` Linus Walleij
2012-05-24 14:29 ` Linus Walleij
2012-05-24 14:55 ` Linus Walleij
2012-05-24 14:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBBC900.2070003@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.