From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH 2/2 v2] zram: clean up handle
Date: Wed, 23 May 2012 15:09:38 -0500 [thread overview]
Message-ID: <4FBD4402.7060509@linux.vnet.ibm.com> (raw)
In-Reply-To: <1337737402-16543-2-git-send-email-minchan@kernel.org>
On 05/22/2012 08:43 PM, Minchan Kim wrote:
> zram's handle variable can store handle of zsmalloc in case of
> compressing efficiently. Otherwise, it stores point of page descriptor.
> This patch clean up the mess by union struct.
>
> changelog
> * from v1
> - none(new add in v2)
>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Not sure if the BUILD_BUG is completely needed since it's pretty well
assumed that sizeof(unsigned long) == sizeof(void *) but it does provide
some safety is someone tries to change the type of handle.
Acked-by: <sjenning@linux.vnet.ibm.com>
Thanks,
Seth
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH 2/2 v2] zram: clean up handle
Date: Wed, 23 May 2012 15:09:38 -0500 [thread overview]
Message-ID: <4FBD4402.7060509@linux.vnet.ibm.com> (raw)
In-Reply-To: <1337737402-16543-2-git-send-email-minchan@kernel.org>
On 05/22/2012 08:43 PM, Minchan Kim wrote:
> zram's handle variable can store handle of zsmalloc in case of
> compressing efficiently. Otherwise, it stores point of page descriptor.
> This patch clean up the mess by union struct.
>
> changelog
> * from v1
> - none(new add in v2)
>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Not sure if the BUILD_BUG is completely needed since it's pretty well
assumed that sizeof(unsigned long) == sizeof(void *) but it does provide
some safety is someone tries to change the type of handle.
Acked-by: <sjenning@linux.vnet.ibm.com>
Thanks,
Seth
next prev parent reply other threads:[~2012-05-23 20:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 1:43 [PATCH 1/2 v2] zsmalloc: zsmalloc: use unsigned long instead of void * Minchan Kim
2012-05-23 1:43 ` Minchan Kim
2012-05-23 1:43 ` [PATCH 2/2 v2] zram: clean up handle Minchan Kim
2012-05-23 1:43 ` Minchan Kim
2012-05-23 20:09 ` Seth Jennings [this message]
2012-05-23 20:09 ` Seth Jennings
2012-05-31 0:46 ` Konrad Rzeszutek Wilk
2012-05-31 0:46 ` Konrad Rzeszutek Wilk
2012-05-23 19:15 ` [PATCH 1/2 v2] zsmalloc: zsmalloc: use unsigned long instead of void * Seth Jennings
2012-05-23 19:15 ` Seth Jennings
2012-05-23 20:46 ` Konrad Rzeszutek Wilk
2012-05-23 20:46 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBD4402.7060509@linux.vnet.ibm.com \
--to=sjenning@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.