All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: AnilKumar Ch <anilkumar@ti.com>
Cc: mkl@pengutronix.de, linux-can@vger.kernel.org, anantgole@ti.com,
	nsekhar@ti.com
Subject: Re: [RESEND PATCH v3 5/5] can: c_can: Add support for Bosch D_CAN controller
Date: Wed, 23 May 2012 22:35:52 +0200	[thread overview]
Message-ID: <4FBD4A28.1090905@grandegger.com> (raw)
In-Reply-To: <4FBD3F32.3080104@grandegger.com>

On 05/23/2012 09:49 PM, Wolfgang Grandegger wrote:
> Hi AnilKumar,
> 
> I have some more comments...

I also reviewed your other patches and did not find any obvious issues.
I just realized some expressions which now would fit on one line
(instead of two). But that are minor issues. You can add my

  Acked-by: Wolfgang Grandegger <wg@grandegger.com>

Wolfgang.


  reply	other threads:[~2012-05-23 20:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 12:15 [PATCH v4 0/5] can: c_can: Add support for Bosch D_CAN controller AnilKumar Ch
2012-05-23 12:15 ` [RESEND PATCH v3 1/5] can: c_can: fix "BUG! echo_skb is occupied!" during transmit AnilKumar Ch
2012-05-23 12:15 ` [RESEND PATCH v3 2/5] can: c_can: fix an interrupt thrash issue with c_can driver AnilKumar Ch
2012-05-23 12:15 ` [RESEND PATCH v3 3/5] can: c_can: fix race condition in c_can_open() AnilKumar Ch
2012-05-23 12:15 ` [PATCH v4 4/5] can: c_can: Move overlay structure to array with offset as index AnilKumar Ch
2012-05-23 12:15 ` [RESEND PATCH v3 5/5] can: c_can: Add support for Bosch D_CAN controller AnilKumar Ch
2012-05-23 19:49   ` Wolfgang Grandegger
2012-05-23 20:35     ` Wolfgang Grandegger [this message]
2012-05-23 20:39     ` Marc Kleine-Budde
2012-05-24  7:01       ` Wolfgang Grandegger
2012-05-24  7:18         ` Marc Kleine-Budde
2012-05-24  8:20 ` [PATCH v4 0/5] " Marc Kleine-Budde
2012-05-24  8:25   ` Wolfgang Grandegger
2012-05-24  8:28     ` Marc Kleine-Budde
2012-05-29  5:38     ` AnilKumar, Chimata
  -- strict thread matches above, loose matches on Subject: below --
2012-05-23  9:36 [RESEND PATCH v3 " AnilKumar Ch
2012-05-23  9:36 ` [RESEND PATCH v3 5/5] " AnilKumar Ch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBD4A28.1090905@grandegger.com \
    --to=wg@grandegger.com \
    --cc=anantgole@ti.com \
    --cc=anilkumar@ti.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.