Re: [PATCH v4 0/5] can: c_can: Add support for Bosch D_CAN controller

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 3646 bytes --]

Hello,

Oliver just poked me, what about these patches :)

On 05/23/2012 02:15 PM, AnilKumar Ch wrote:
> This patch series adds support for Bosch D_CAN controller to the
> existing C_CAN controller driver.
> 
> Bosch D_CAN controller is a full-CAN implementation compliant to CAN
> protocol version 2.0 part A and B. Bosch D_CAN user manual can be
> obtained from: http://www.semiconductors.bosch.de/media/
> en/pdf/ipmodules_1/can/d_can_users_manual_111.pdf
> 
> D_CAN device is used on many SoCs like AM335x, DM8148 and DM813x EVMs
> from TI, D_CAN details on AM335x can be accessed from:
> http://www.ti.com/lit/ug/spruh73c/spruh73c.pdf
> 
> This patch series also fixes some issues in the current c_can driver.
> These issues were found while integrating d_can driver to c_can driver.
> 
> These patches have been tested on AM335x EVM using some additional
> patches adding runtime PM support and some code to initialize the
> AM335x D_CAN RAM. I will submit these patches once these patches are
> accepted.
> 
> Due to lack of hardware I am not able to test c_can functionality.
> I appreciate if anyone can test C_CAN functionality with this patch
> series.
> 
> Changes from v3:
> 	- Incorporated all Marc's review comments on v3 (patch4)
> 	- Resending rest of the patches, because all the patches are
> 	  interdependent
> 
> Changes from v2:
>         - Dropped patch 1 (acc. to v2) because no update from v2. Can
>           be found at http://permalink.gmane.org/gmane.linux.can/1081
>         - Incorporated all Marc's review comments on v2
>           * Changed patch 2 (acc. to v2) subject line to "can: c_can:
>             fix race condition in c_can_open()"
>           * Moved "int reg" in patch 3 (acc. to v2) to "enum reg index"
>           * Device registration changed by using "platform_device:
>             id_table"
>         - Changed iface hard coded way to a macro implementation.
> 
> Changes form v1:
>         - Changed the Macro implementation to access registers via an
>           array with virtual register index.
>         - Dropped "can: c_can: fix "BUG! echo_skb is occupied!" during
>           transmit" patch because it's accepted.
>         - Reworked on second patch (acc. to v1) based on Marc's comments.
>         - Found one more issue and added as separate patch.
>         - Third patch (acc. to v1) is split into two patches, first
>           patch only do c_can modifications to incorporate the current
>           implementation and second one adds d_can support
> 
> AnilKumar Ch (5):
>   can: c_can: fix "BUG! echo_skb is occupied!" during transmit
>   can: c_can: fix an interrupt thrash issue with c_can driver
>   can: c_can: fix race condition in c_can_open()

I've added these three patches to the linux-can/master on gitorious [1].
I fixed a typo in the first patch's commit message, added Wolfgang's
Acked-by and stable to Cc. The series is compile tested only. I'm going
to write a pull request to David. Any objections?

>   can: c_can: Move overlay structure to array with offset as index
>   can: c_can: Add support for Bosch D_CAN controller

I'm going to add these patches to linux-can-next after we've sorted out
the outstanding minor things about the id_table.

cheers, Marc

[1] https://gitorious.org/linux-can/linux-can

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]