All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind
Date: Thu, 24 May 2012 08:51:40 +0200	[thread overview]
Message-ID: <4FBDDA7C.2010200@redhat.com> (raw)
In-Reply-To: <20120524064347.GI6105@garlic.tlv.redhat.com>

On 05/24/12 08:43, Alon Levy wrote:
> On Wed, May 23, 2012 at 08:59:22PM +0200, Gerd Hoffmann wrote:
>> On 05/22/12 17:29, Alon Levy wrote:
>>> We can't initialize QXLDevSurfaceCreate field by field because it has a
>>> pa hole, and so 4 bytes remain uninitialized when building on x86-64, so
>>> just memset.
>>
>> So you get valgrind warnings for the hole?  why?  nobody should ever
>> access the hole, so the missing initialization should not hurt in theory ...
> 
> Because we allocate this struct on the stack and then copy it over an fd
> to spice, through the dispatcher pipe.

Ah, yea, copying will make valgrind complain of course ...

I'll go queue it up.

cheers,
  Gerd

  reply	other threads:[~2012-05-24  6:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 15:29 [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind Alon Levy
2012-05-22 15:29 ` [Qemu-devel] [PATCHv2 2/3] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/ Alon Levy
2012-05-22 15:30 ` [Qemu-devel] [PATCHv2 3/3] hmp/qxl: info spice: add qxl info Alon Levy
2012-05-23 18:59 ` [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind Gerd Hoffmann
2012-05-24  6:43   ` Alon Levy
2012-05-24  6:51     ` Gerd Hoffmann [this message]
2012-05-24  8:50       ` Gerd Hoffmann
2012-05-24  9:38         ` [Qemu-devel] [PATCH 1/4] " Alon Levy
2012-05-24  9:38           ` [Qemu-devel] [PATCH 2/4] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/ Alon Levy
2012-05-24  9:38           ` [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info Alon Levy
2012-05-24 12:58             ` Gerd Hoffmann
2012-05-24 16:15               ` Alon Levy
2012-05-24 16:18               ` [Qemu-devel] [PATCH 1/2] qxl: stop dirty loging when not in vga mode Alon Levy
2012-05-24 16:18                 ` [Qemu-devel] [PATCH 2/2] hw/qxl: ignore guest from guestbug until reset Alon Levy
2012-05-24  9:38           ` [Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode Alon Levy
2012-05-24  9:47           ` [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBDDA7C.2010200@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.