From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info
Date: Thu, 24 May 2012 14:58:40 +0200 [thread overview]
Message-ID: <4FBE3080.9040201@redhat.com> (raw)
In-Reply-To: <1337852294-12224-3-git-send-email-alevy@redhat.com>
On 05/24/12 11:38, Alon Levy wrote:
> For all devices print id, mode and guest_bug status.
Queued up 1+2+4
For this one I wanna have an additional ack from qmp camp.
Also a nit:
> # @SpiceInfo
> #
> # Information about the SPICE session.
> @@ -683,12 +721,17 @@
> #
> # @channels: a list of @SpiceChannel for each active spice channel
> #
> +# @qxl0_mode: Mode of the primary qxl device.
> +#
> +# @qxl0_guest_bug: Guest bug status of primary qxl device.
> +#
Code changed, but docs didn't ...
Otherwise looks fine to me.
cheers,
Gerd
next prev parent reply other threads:[~2012-05-24 12:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 15:29 [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind Alon Levy
2012-05-22 15:29 ` [Qemu-devel] [PATCHv2 2/3] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/ Alon Levy
2012-05-22 15:30 ` [Qemu-devel] [PATCHv2 3/3] hmp/qxl: info spice: add qxl info Alon Levy
2012-05-23 18:59 ` [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind Gerd Hoffmann
2012-05-24 6:43 ` Alon Levy
2012-05-24 6:51 ` Gerd Hoffmann
2012-05-24 8:50 ` Gerd Hoffmann
2012-05-24 9:38 ` [Qemu-devel] [PATCH 1/4] " Alon Levy
2012-05-24 9:38 ` [Qemu-devel] [PATCH 2/4] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/ Alon Levy
2012-05-24 9:38 ` [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info Alon Levy
2012-05-24 12:58 ` Gerd Hoffmann [this message]
2012-05-24 16:15 ` Alon Levy
2012-05-24 16:18 ` [Qemu-devel] [PATCH 1/2] qxl: stop dirty loging when not in vga mode Alon Levy
2012-05-24 16:18 ` [Qemu-devel] [PATCH 2/2] hw/qxl: ignore guest from guestbug until reset Alon Levy
2012-05-24 9:38 ` [Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode Alon Levy
2012-05-24 9:47 ` [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE3080.9040201@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.