From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Add support for entering the firmware setup screen.
Date: Thu, 24 May 2012 17:40:43 +0200 [thread overview]
Message-ID: <4FBE567B.6090508@gmail.com> (raw)
In-Reply-To: <1337869896-3671-1-git-send-email-pjones@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
On 24.05.2012 16:31, Peter Jones wrote:
> + if (old_os_indications != NULL && oi_size == 8)
> + os_indications |= *old_os_indications;
> +
Could you make this 8 a sizeof ? Other than that the patch is good and
is approved post-2.0
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2012-05-24 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 14:31 [PATCH] Add support for entering the firmware setup screen Peter Jones
2012-05-24 15:40 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-05-24 16:41 ` Peter Jones
2012-09-08 10:09 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE567B.6090508@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.