All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Dunn <mikedunn@newsguy.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] mtd mxc_nand: move ecc strengh setup before nand_scan_tail
Date: Fri, 25 May 2012 09:29:24 -0700	[thread overview]
Message-ID: <4FBFB364.70601@newsguy.com> (raw)
In-Reply-To: <1337955762-19157-2-git-send-email-s.hauer@pengutronix.de>

On 05/25/2012 07:22 AM, Sascha Hauer wrote:
> Since this commit:
> 
>   commit 6a918bade9dab40aaef80559bd1169c69e8d69cb
>   Author: Mike Dunn <mikedunn@newsguy.com>
>   Date:   Sun Mar 11 14:21:11 2012 -0700
> 
>      mtd: flash drivers set ecc strength
> 
> The mxc_nand driver fails with:
> 
> Driver must set ecc.strength when using hardware ECC
> 
> This is because nand_scan_tail checks for correct ecc strength
> settings, so we must set them up before nand_scan_tail.


Oops, sorry Sascha.  This was compile-tested only, but I should have ensured
strength was set before call to nand_scan_tail().

Thanks,
Mike

WARNING: multiple messages have this Message-ID (diff)
From: mikedunn@newsguy.com (Mike Dunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mtd mxc_nand: move ecc strengh setup before nand_scan_tail
Date: Fri, 25 May 2012 09:29:24 -0700	[thread overview]
Message-ID: <4FBFB364.70601@newsguy.com> (raw)
In-Reply-To: <1337955762-19157-2-git-send-email-s.hauer@pengutronix.de>

On 05/25/2012 07:22 AM, Sascha Hauer wrote:
> Since this commit:
> 
>   commit 6a918bade9dab40aaef80559bd1169c69e8d69cb
>   Author: Mike Dunn <mikedunn@newsguy.com>
>   Date:   Sun Mar 11 14:21:11 2012 -0700
> 
>      mtd: flash drivers set ecc strength
> 
> The mxc_nand driver fails with:
> 
> Driver must set ecc.strength when using hardware ECC
> 
> This is because nand_scan_tail checks for correct ecc strength
> settings, so we must set them up before nand_scan_tail.


Oops, sorry Sascha.  This was compile-tested only, but I should have ensured
strength was set before call to nand_scan_tail().

Thanks,
Mike

  reply	other threads:[~2012-05-25 16:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25 14:22 [PATCH 1/2] mtd mxc_nand: use 32bit copy functions Sascha Hauer
2012-05-25 14:22 ` Sascha Hauer
2012-05-25 14:22 ` [PATCH 2/2] mtd mxc_nand: move ecc strengh setup before nand_scan_tail Sascha Hauer
2012-05-25 14:22   ` Sascha Hauer
2012-05-25 16:29   ` Mike Dunn [this message]
2012-05-25 16:29     ` Mike Dunn
2012-05-25 16:55   ` Artem Bityutskiy
2012-05-25 16:55     ` Artem Bityutskiy
2012-05-25 14:58 ` [PATCH 1/2] mtd mxc_nand: use 32bit copy functions Artem Bityutskiy
2012-05-25 14:58   ` Artem Bityutskiy
2012-05-25 14:59   ` Sascha Hauer
2012-05-25 14:59     ` Sascha Hauer
2012-06-29 11:34     ` Artem Bityutskiy
2012-06-29 11:34       ` Artem Bityutskiy
2012-06-27 17:52 ` Uwe Kleine-König
2012-06-27 17:52   ` Uwe Kleine-König
2012-06-29 11:25   ` Artem Bityutskiy
2012-06-29 11:25     ` Artem Bityutskiy
2012-06-29 11:28     ` Uwe Kleine-König
2012-06-29 11:28       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBFB364.70601@newsguy.com \
    --to=mikedunn@newsguy.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.