All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thavatchai Makphaibulcboke <thavatchai.makpahibulchoke@hp.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] lib/decompress_unxz.c: removing all memory helper functions
Date: Fri, 25 May 2012 17:05:55 +0000	[thread overview]
Message-ID: <4FBFBBF3.3090204@hp.com> (raw)
In-Reply-To: <4FBFB3F3.1000606@hp.com>

> We could do that.  But according to the comment in the original
> implementation, there seems to be a concern regarding its performance
> speed. If you believe all archs' memcpy would give comparable
> performance to the memmove. then I could do that.
> 

Also how about the case for overlapping buffer, especially when the
destination is at a higher address?  I do not believe memcpy guarantee
to work.

Thanks,
Mak.



WARNING: multiple messages have this Message-ID (diff)
From: thavatchai.makpahibulchoke@hp.com (Thavatchai Makphaibulcboke)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] lib/decompress_unxz.c: removing all memory helper functions
Date: Fri, 25 May 2012 11:05:55 -0600	[thread overview]
Message-ID: <4FBFBBF3.3090204@hp.com> (raw)
In-Reply-To: <4FBFB3F3.1000606@hp.com>

> We could do that.  But according to the comment in the original
> implementation, there seems to be a concern regarding its performance
> speed. If you believe all archs' memcpy would give comparable
> performance to the memmove. then I could do that.
> 

Also how about the case for overlapping buffer, especially when the
destination is at a higher address?  I do not believe memcpy guarantee
to work.

Thanks,
Mak.

WARNING: multiple messages have this Message-ID (diff)
From: Thavatchai Makphaibulcboke <thavatchai.makpahibulchoke@hp.com>
To: Lasse Collin <lasse.collin@tukaani.org>
Cc: "lethal@linux-sh.org" <lethal@linux-sh.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"kaloz@openwrt.org" <kaloz@openwrt.org>,
	"matt.fleming@intel.com" <matt.fleming@intel.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
	"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
	"linux390@de.ibm.com" <linux390@de.ibm.com>
Subject: Re: [PATCH] lib/decompress_unxz.c: removing all memory helper functions
Date: Fri, 25 May 2012 11:05:55 -0600	[thread overview]
Message-ID: <4FBFBBF3.3090204@hp.com> (raw)
In-Reply-To: <4FBFB3F3.1000606@hp.com>

> We could do that.  But according to the comment in the original
> implementation, there seems to be a concern regarding its performance
> speed. If you believe all archs' memcpy would give comparable
> performance to the memmove. then I could do that.
> 

Also how about the case for overlapping buffer, especially when the
destination is at a higher address?  I do not believe memcpy guarantee
to work.

Thanks,
Mak.



  reply	other threads:[~2012-05-25 17:05 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 16:03 [PATCH] lib/decompress_unxz.c: removing all memory helper functions T Makphaibulchoke
2012-05-24 16:03 ` T Makphaibulchoke
2012-05-24 16:03 ` T Makphaibulchoke
2012-05-24 17:26 ` Joe Perches
2012-05-24 17:26   ` Joe Perches
2012-05-24 17:26   ` Joe Perches
2012-05-24 17:29   ` H. Peter Anvin
2012-05-24 17:29     ` H. Peter Anvin
2012-05-24 17:29     ` H. Peter Anvin
2012-05-24 17:40     ` Joe Perches
2012-05-24 17:40       ` Joe Perches
2012-05-24 17:40       ` Joe Perches
2012-05-24 17:41       ` H. Peter Anvin
2012-05-24 17:41         ` H. Peter Anvin
2012-05-24 17:41         ` H. Peter Anvin
2012-05-24 17:50         ` Joe Perches
2012-05-24 17:50           ` Joe Perches
2012-05-24 17:50           ` Joe Perches
2012-05-24 17:56           ` H. Peter Anvin
2012-05-24 17:56             ` H. Peter Anvin
2012-05-24 17:56             ` H. Peter Anvin
2012-05-25  8:34 ` Lasse Collin
2012-05-25  8:34   ` Lasse Collin
2012-05-25  8:34   ` Lasse Collin
2012-05-25 16:31   ` Thavatchai Makphaibulcboke
2012-05-25 16:31     ` Thavatchai Makphaibulcboke
2012-05-25 16:31     ` Thavatchai Makphaibulcboke
2012-05-25 17:05     ` Thavatchai Makphaibulcboke [this message]
2012-05-25 17:05       ` Thavatchai Makphaibulcboke
2012-05-25 17:05       ` Thavatchai Makphaibulcboke
2012-05-25 17:13       ` H. Peter Anvin
2012-05-25 17:13         ` H. Peter Anvin
2012-05-25 17:13         ` H. Peter Anvin
2012-05-25 19:35     ` Lasse Collin
2012-05-25 19:35       ` Lasse Collin
2012-05-25 19:35       ` Lasse Collin
2012-05-28  7:03 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-28  7:03   ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-28  7:03   ` Jean-Christophe PLAGNIOL-VILLARD
2012-06-01  2:48   ` Thavatchai Makphaibulcboke
2012-06-01  2:48     ` Thavatchai Makphaibulcboke
2012-06-01  2:48     ` Thavatchai Makphaibulcboke
2012-06-01  2:54     ` Joe Perches
2012-06-01  2:54       ` Joe Perches
2012-06-01  2:54       ` Joe Perches
2012-06-01  3:38     ` H. Peter Anvin
2012-06-01  3:38       ` H. Peter Anvin
2012-06-01  3:38       ` H. Peter Anvin
2012-06-01 18:37       ` Thavatchai Makphaibulcboke
2012-06-01 18:37         ` Thavatchai Makphaibulcboke
2012-06-01 18:37         ` Thavatchai Makphaibulcboke
2012-06-01 18:46         ` H. Peter Anvin
2012-06-01 18:46           ` H. Peter Anvin
2012-06-01 18:46           ` H. Peter Anvin
2012-06-01 18:58           ` Thavatchai Makphaibulcboke
2012-06-01 18:58             ` Thavatchai Makphaibulcboke
2012-06-01 18:58             ` Thavatchai Makphaibulcboke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBFBBF3.3090204@hp.com \
    --to=thavatchai.makpahibulchoke@hp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.