From: Arend van Spriel <arend@broadcom.com>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: "Hauke Mehrtens" <hauke@hauke-m.de>,
linux-wireless@vger.kernel.org,
"Stefano Brivio" <stefano.brivio@polimi.it>,
"Rafał Miłecki" <zajec5@gmail.com>,
"b43-dev@lists.infradead.org" <b43-dev@lists.infradead.org>
Subject: BCM4331 tx failures after S3
Date: Fri, 25 May 2012 22:59:37 +0200 [thread overview]
Message-ID: <4FBFF2B9.1070107@broadcom.com> (raw)
In-Reply-To: <20120525204459.GE2895@thinkpad-t410>
On 05/25/2012 10:44 PM, Seth Forshee wrote:
> Before. I printed the value from bcma_host_pci_resume().
>
> I can easily make a patch that fixes the chipctl register up as needed
> during resume to fix my problem. But based on the fact that other fields
> in the register are also changing value, I'm wondering if more thorough
> handling is needed for the register.
Ok. I dived into b43 and it does disable the wireless core in the
.stop() callback. So I believe it does reinitialize the device when
.start() callback is being called after resume. So I think you should
check the chipctl register at the end of the .start() callback.
> And I'm also a little fuzzy on
> exactly who should be responsible for what in the relationship between
> b43 and the wireless drivers.
I assume you mean bcma instead of b43, right? I admit it is a bit shady,
because bcma is more than just a bus driver. It also contains drivers
for the chipcommon and pcie cores on the device.
Gr. AvS
WARNING: multiple messages have this Message-ID (diff)
From: "Arend van Spriel" <arend@broadcom.com>
To: "Seth Forshee" <seth.forshee@canonical.com>
Cc: "Hauke Mehrtens" <hauke@hauke-m.de>,
linux-wireless@vger.kernel.org,
"Stefano Brivio" <stefano.brivio@polimi.it>,
"Rafał Miłecki" <zajec5@gmail.com>,
"b43-dev@lists.infradead.org" <b43-dev@lists.infradead.org>
Subject: Re: BCM4331 tx failures after S3
Date: Fri, 25 May 2012 22:59:37 +0200 [thread overview]
Message-ID: <4FBFF2B9.1070107@broadcom.com> (raw)
In-Reply-To: <20120525204459.GE2895@thinkpad-t410>
On 05/25/2012 10:44 PM, Seth Forshee wrote:
> Before. I printed the value from bcma_host_pci_resume().
>
> I can easily make a patch that fixes the chipctl register up as needed
> during resume to fix my problem. But based on the fact that other fields
> in the register are also changing value, I'm wondering if more thorough
> handling is needed for the register.
Ok. I dived into b43 and it does disable the wireless core in the
.stop() callback. So I believe it does reinitialize the device when
.start() callback is being called after resume. So I think you should
check the chipctl register at the end of the .start() callback.
> And I'm also a little fuzzy on
> exactly who should be responsible for what in the relationship between
> b43 and the wireless drivers.
I assume you mean bcma instead of b43, right? I admit it is a bit shady,
because bcma is more than just a bus driver. It also contains drivers
for the chipcommon and pcie cores on the device.
Gr. AvS
next prev parent reply other threads:[~2012-05-25 20:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 16:52 BCM4331 tx failures after S3 Seth Forshee
2012-05-23 9:15 ` Hauke Mehrtens
2012-05-23 13:51 ` Seth Forshee
2012-05-23 9:30 ` Arend van Spriel
2012-05-23 13:55 ` Seth Forshee
2012-05-24 9:36 ` Arend van Spriel
2012-05-24 21:21 ` Seth Forshee
2012-05-24 21:34 ` Hauke Mehrtens
2012-05-25 10:16 ` Arend van Spriel
2012-05-25 14:13 ` Seth Forshee
2012-05-25 16:47 ` Arend van Spriel
2012-05-25 18:34 ` Seth Forshee
2012-05-25 20:19 ` Arend van Spriel
2012-05-25 20:19 ` Arend van Spriel
2012-05-25 20:44 ` Seth Forshee
2012-05-25 20:44 ` Seth Forshee
2012-05-25 20:59 ` Arend van Spriel [this message]
2012-05-25 20:59 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBFF2B9.1070107@broadcom.com \
--to=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=seth.forshee@canonical.com \
--cc=stefano.brivio@polimi.it \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.