* [PATCH 2/4] [media] s5p-fimc: Add missing static storage class in fimc-mdevice.c file
2012-05-25 17:38 [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file Sachin Kamat
@ 2012-05-25 17:38 ` Sachin Kamat
2012-05-25 17:38 ` [PATCH 3/4] [media] s5p-fimc: Add missing static storage class in fimc-core.c file Sachin Kamat
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Sachin Kamat @ 2012-05-25 17:38 UTC (permalink / raw)
To: linux-media; +Cc: s.nawrocki, mchehab, sachin.kamat, patches
Fixes the following sparse warnings:
drivers/media/video/s5p-fimc/fimc-mdevice.c:183:5: warning: symbol '__fimc_pipeline_shutdown' was not declared. Should it be static?
drivers/media/video/s5p-fimc/fimc-mdevice.c:1013:12: warning: symbol 'fimc_md_init' was not declared. Should it be static?
drivers/media/video/s5p-fimc/fimc-mdevice.c:1024:13: warning: symbol 'fimc_md_exit' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/media/video/s5p-fimc/fimc-mdevice.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/s5p-fimc/fimc-mdevice.c b/drivers/media/video/s5p-fimc/fimc-mdevice.c
index 52cef48..e65bb28 100644
--- a/drivers/media/video/s5p-fimc/fimc-mdevice.c
+++ b/drivers/media/video/s5p-fimc/fimc-mdevice.c
@@ -180,7 +180,7 @@ EXPORT_SYMBOL_GPL(fimc_pipeline_initialize);
* sensor clock.
* Called with the graph mutex held.
*/
-int __fimc_pipeline_shutdown(struct fimc_pipeline *p)
+static int __fimc_pipeline_shutdown(struct fimc_pipeline *p)
{
int ret = 0;
@@ -1010,7 +1010,7 @@ static struct platform_driver fimc_md_driver = {
}
};
-int __init fimc_md_init(void)
+static int __init fimc_md_init(void)
{
int ret;
@@ -1021,7 +1021,8 @@ int __init fimc_md_init(void)
return platform_driver_register(&fimc_md_driver);
}
-void __exit fimc_md_exit(void)
+
+static void __exit fimc_md_exit(void)
{
platform_driver_unregister(&fimc_md_driver);
fimc_unregister_driver();
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] [media] s5p-fimc: Add missing static storage class in fimc-core.c file
2012-05-25 17:38 [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file Sachin Kamat
2012-05-25 17:38 ` [PATCH 2/4] [media] s5p-fimc: Add missing static storage class in fimc-mdevice.c file Sachin Kamat
@ 2012-05-25 17:38 ` Sachin Kamat
2012-05-25 17:38 ` [PATCH 4/4] [media] s5p-fimc: Add missing static storage class in fimc-capture.c file Sachin Kamat
2012-05-26 8:39 ` [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file Sylwester Nawrocki
3 siblings, 0 replies; 6+ messages in thread
From: Sachin Kamat @ 2012-05-25 17:38 UTC (permalink / raw)
To: linux-media; +Cc: s.nawrocki, mchehab, sachin.kamat, patches
Fixes the following sparse warning:
drivers/media/video/s5p-fimc/fimc-core.c:466:5: warning: symbol 'fimc_set_color_effect' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/media/video/s5p-fimc/fimc-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/s5p-fimc/fimc-core.c b/drivers/media/video/s5p-fimc/fimc-core.c
index c2d621c..02c82c7 100644
--- a/drivers/media/video/s5p-fimc/fimc-core.c
+++ b/drivers/media/video/s5p-fimc/fimc-core.c
@@ -463,7 +463,7 @@ void fimc_prepare_dma_offset(struct fimc_ctx *ctx, struct fimc_frame *f)
f->fmt->color, f->dma_offset.y_h, f->dma_offset.y_v);
}
-int fimc_set_color_effect(struct fimc_ctx *ctx, enum v4l2_colorfx colorfx)
+static int fimc_set_color_effect(struct fimc_ctx *ctx, enum v4l2_colorfx colorfx)
{
struct fimc_effect *effect = &ctx->effect;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/4] [media] s5p-fimc: Add missing static storage class in fimc-capture.c file
2012-05-25 17:38 [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file Sachin Kamat
2012-05-25 17:38 ` [PATCH 2/4] [media] s5p-fimc: Add missing static storage class in fimc-mdevice.c file Sachin Kamat
2012-05-25 17:38 ` [PATCH 3/4] [media] s5p-fimc: Add missing static storage class in fimc-core.c file Sachin Kamat
@ 2012-05-25 17:38 ` Sachin Kamat
2012-05-26 8:39 ` [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file Sylwester Nawrocki
3 siblings, 0 replies; 6+ messages in thread
From: Sachin Kamat @ 2012-05-25 17:38 UTC (permalink / raw)
To: linux-media; +Cc: s.nawrocki, mchehab, sachin.kamat, patches
Fixes the following sparse warning:
drivers/media/video/s5p-fimc/fimc-capture.c:1163:5: warning: symbol 'enclosed_rectangle' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/media/video/s5p-fimc/fimc-capture.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/s5p-fimc/fimc-capture.c b/drivers/media/video/s5p-fimc/fimc-capture.c
index 516cd5b..b7caaf5 100644
--- a/drivers/media/video/s5p-fimc/fimc-capture.c
+++ b/drivers/media/video/s5p-fimc/fimc-capture.c
@@ -1160,7 +1160,7 @@ static int fimc_cap_g_selection(struct file *file, void *fh,
}
/* Return 1 if rectangle a is enclosed in rectangle b, or 0 otherwise. */
-int enclosed_rectangle(struct v4l2_rect *a, struct v4l2_rect *b)
+static int enclosed_rectangle(struct v4l2_rect *a, struct v4l2_rect *b)
{
if (a->left < b->left || a->top < b->top)
return 0;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file
2012-05-25 17:38 [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file Sachin Kamat
` (2 preceding siblings ...)
2012-05-25 17:38 ` [PATCH 4/4] [media] s5p-fimc: Add missing static storage class in fimc-capture.c file Sachin Kamat
@ 2012-05-26 8:39 ` Sylwester Nawrocki
2012-05-26 14:55 ` Sachin Kamat
3 siblings, 1 reply; 6+ messages in thread
From: Sylwester Nawrocki @ 2012-05-26 8:39 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-media, s.nawrocki, mchehab, patches
Hi Sachin,
On 05/25/2012 07:38 PM, Sachin Kamat wrote:
> Fixes the following sparse warning:
> drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
> 'flite_hw_set_out_order' was not declared. Should it be static?
Thanks for the patches. However I'm inclined to squash this whole
series into one patch, since it addresses same issue in one driver,
just in different. I don't see a good reason to split those changes
like this. Could you make it just one patch instead ?
Regards,
Sylwester
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file
2012-05-26 8:39 ` [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file Sylwester Nawrocki
@ 2012-05-26 14:55 ` Sachin Kamat
0 siblings, 0 replies; 6+ messages in thread
From: Sachin Kamat @ 2012-05-26 14:55 UTC (permalink / raw)
To: Sylwester Nawrocki; +Cc: linux-media, s.nawrocki, mchehab, patches
Hi Sylwester,
On 26 May 2012 14:09, Sylwester Nawrocki <snjw23@gmail.com> wrote:
> Hi Sachin,
>
>
> On 05/25/2012 07:38 PM, Sachin Kamat wrote:
>>
>> Fixes the following sparse warning:
>> drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
>> 'flite_hw_set_out_order' was not declared. Should it be static?
>
>
> Thanks for the patches. However I'm inclined to squash this whole
> series into one patch, since it addresses same issue in one driver,
> just in different. I don't see a good reason to split those changes
> like this. Could you make it just one patch instead ?
Sure. I will send it on Monday.
In fact I too wanted to send it as a single patch but wasn't quite
sure if it was OK to do so.
>
>
> Regards,
> Sylwester
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 6+ messages in thread