From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [bug #36532] boot in EFI mode (x86_64) fails on some systems
Date: Sat, 26 May 2012 12:18:17 +0200 [thread overview]
Message-ID: <4FC0ADE9.8000904@gmail.com> (raw)
In-Reply-To: <959D45574D89AF41A9DADF6F446A2E9A2AE52B06DA@AUSX7MCPS310.AMER.DELL.COM>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On 24.05.2012 19:27, Stuart_Hayes@Dell.com wrote:
> Hello…
>
>
>
> I just submitted a grub2 bug, along with a patch, at
> <http://savannah.gnu.org/bugs/?36532>.
>
>
>
> Is that the right place for a patch, or should I sent it to this mailing
> list?
This patch is for 1.99. Could you update it to 2.00~beta5 and post here
inline? Also problematic are:
- Huge copy-paste for determining load address. It should be something
like having a function for allocation of initrd-like chunk.
- No need to probe for mmap size if we don't use the size. It's
extremely unlikely that this call fails for any reason other than small
buffer.
- You allocate the exact size of mmap. This is wrong as allocating may
increase the size of mmap slightly. You need to allocate at least 4K more.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2012-05-26 10:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 17:27 [bug #36532] boot in EFI mode (x86_64) fails on some systems Stuart_Hayes
2012-05-26 10:18 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-05-27 14:52 ` Vladimir 'φ-coder/phcoder' Serbinenko
[not found] <20120523-193311.sv88235.49420@savannah.gnu.org>
[not found] ` <20120531-112908.sv72589.64321@savannah.gnu.org>
[not found] ` <959D45574D89AF41A9DADF6F446A2E9A2AE507A772@AUSX7MCPS310.AMER.DELL.COM>
[not found] ` <959D45574D89AF41A9DADF6F446A2E9A2AE55A707B@AUSX7MCPS310.AMER.DELL.COM>
[not found] ` <4FD1180B.8090709@gmail.com>
[not found] ` <959D45574D89AF41A9DADF6F446A2E9A2AE5668374@AUSX7MCPS310.AMER.DELL.COM>
[not found] ` <4FD646FE.4050301@gmail.com>
[not found] ` <959D45574D89AF41A9DADF6F446A2E9A2AE56AEA8E@AUSX7MCPS310.AMER.DELL.COM>
[not found] ` <4FD79D9E.6010702@gmail.com>
2012-06-27 19:59 ` Stuart_Hayes
2012-06-27 20:50 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-06-27 20:58 ` Stuart_Hayes
2012-06-28 21:39 ` Stuart_Hayes
2012-06-29 20:49 ` Stuart_Hayes
2012-06-29 21:14 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-07-02 17:49 ` Stuart_Hayes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC0ADE9.8000904@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.