From: "Jun'ichi Nomura" <j-nomura-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
To: Kent Overstreet <koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: device-mapper development
<dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
yehuda-L5o5AL9CYN0tUFlbccrkMA@public.gmane.org,
mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
sage-BnTBU8nroG7k1uMJSBkQmQ@public.gmane.org,
agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org
Subject: Re: [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info
Date: Mon, 28 May 2012 09:57:55 +0900 [thread overview]
Message-ID: <4FC2CD93.1080009@ce.jp.nec.com> (raw)
In-Reply-To: <1337977539-16977-3-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On 05/26/12 05:25, Kent Overstreet wrote:
> struct dm_rq_clone_bio_info {
> struct bio *orig;
> struct dm_rq_target_io *tio;
> + struct bio clone;
> };
...
> - pools->bs = bioset_create(pool_size, 0);
> + pools->bs = bioset_create(pool_size,
> + offsetof(struct dm_rq_clone_bio_info, orig));
> if (!pools->bs)
> goto free_tio_pool_and_out;
Did you mean offset of *clone*?
"offsetof(struct dm_rq_clone_bio_info, orig)" is zero.
And now _rq_bio_info_cache has no user and can be removed.
Otherwise, I think it's nicer than the previous version.
Thank you.
--
Jun'ichi Nomura, NEC Corporation
WARNING: multiple messages have this Message-ID (diff)
From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: Kent Overstreet <koverstreet@google.com>
Cc: axboe@kernel.dk, device-mapper development <dm-devel@redhat.com>,
linux-kernel@vger.kernel.org, tj@kernel.org,
linux-bcache@vger.kernel.org, mpatocka@redhat.com,
agk@redhat.com, bharrosh@panasas.com,
linux-fsdevel@vger.kernel.org, yehuda@hq.newdream.net,
drbd-dev@lists.linbit.com, vgoyal@redhat.com, sage@newdream.net
Subject: Re: [Drbd-dev] [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info
Date: Mon, 28 May 2012 09:57:55 +0900 [thread overview]
Message-ID: <4FC2CD93.1080009@ce.jp.nec.com> (raw)
In-Reply-To: <1337977539-16977-3-git-send-email-koverstreet@google.com>
On 05/26/12 05:25, Kent Overstreet wrote:
> struct dm_rq_clone_bio_info {
> struct bio *orig;
> struct dm_rq_target_io *tio;
> + struct bio clone;
> };
...
> - pools->bs = bioset_create(pool_size, 0);
> + pools->bs = bioset_create(pool_size,
> + offsetof(struct dm_rq_clone_bio_info, orig));
> if (!pools->bs)
> goto free_tio_pool_and_out;
Did you mean offset of *clone*?
"offsetof(struct dm_rq_clone_bio_info, orig)" is zero.
And now _rq_bio_info_cache has no user and can be removed.
Otherwise, I think it's nicer than the previous version.
Thank you.
--
Jun'ichi Nomura, NEC Corporation
WARNING: multiple messages have this Message-ID (diff)
From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: Kent Overstreet <koverstreet@google.com>
Cc: device-mapper development <dm-devel@redhat.com>,
linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org,
linux-fsdevel@vger.kernel.org, axboe@kernel.dk,
yehuda@hq.newdream.net, mpatocka@redhat.com, vgoyal@redhat.com,
bharrosh@panasas.com, tj@kernel.org, sage@newdream.net,
agk@redhat.com, drbd-dev@lists.linbit.com
Subject: Re: [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info
Date: Mon, 28 May 2012 09:57:55 +0900 [thread overview]
Message-ID: <4FC2CD93.1080009@ce.jp.nec.com> (raw)
In-Reply-To: <1337977539-16977-3-git-send-email-koverstreet@google.com>
On 05/26/12 05:25, Kent Overstreet wrote:
> struct dm_rq_clone_bio_info {
> struct bio *orig;
> struct dm_rq_target_io *tio;
> + struct bio clone;
> };
...
> - pools->bs = bioset_create(pool_size, 0);
> + pools->bs = bioset_create(pool_size,
> + offsetof(struct dm_rq_clone_bio_info, orig));
> if (!pools->bs)
> goto free_tio_pool_and_out;
Did you mean offset of *clone*?
"offsetof(struct dm_rq_clone_bio_info, orig)" is zero.
And now _rq_bio_info_cache has no user and can be removed.
Otherwise, I think it's nicer than the previous version.
Thank you.
--
Jun'ichi Nomura, NEC Corporation
next prev parent reply other threads:[~2012-05-28 0:57 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 20:25 [PATCH v3 00/16] Block cleanups Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
2012-05-25 20:25 ` [PATCH v3 01/16] block: Generalized bio pool freeing Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-2-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-28 1:15 ` Tejun Heo
2012-05-28 1:15 ` Tejun Heo
2012-05-28 1:15 ` [Drbd-dev] " Tejun Heo
2012-05-28 10:04 ` Boaz Harrosh
2012-05-28 10:04 ` Boaz Harrosh
2012-05-28 10:04 ` Boaz Harrosh
2012-05-28 10:04 ` [Drbd-dev] " Boaz Harrosh
2012-05-25 20:25 ` [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-3-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-28 0:57 ` Jun'ichi Nomura [this message]
2012-05-28 0:57 ` [dm-devel] " Jun'ichi Nomura
2012-05-28 0:57 ` [Drbd-dev] " Jun'ichi Nomura
[not found] ` <4FC2CD93.1080009-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
2012-05-28 11:41 ` Jun'ichi Nomura
2012-05-28 11:41 ` Jun'ichi Nomura
2012-05-28 11:41 ` [Drbd-dev] " Jun'ichi Nomura
2012-05-28 1:21 ` Tejun Heo
2012-05-28 1:21 ` Tejun Heo
2012-05-28 1:21 ` [Drbd-dev] " Tejun Heo
[not found] ` <1337977539-16977-1-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-25 20:25 ` [PATCH v3 03/16] block: Add bio_reset() Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-4-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-28 1:23 ` Tejun Heo
2012-05-28 1:23 ` Tejun Heo
2012-05-28 1:23 ` [Drbd-dev] " Tejun Heo
2012-05-28 10:02 ` Boaz Harrosh
2012-05-28 10:02 ` Boaz Harrosh
2012-05-28 10:02 ` [Drbd-dev] " Boaz Harrosh
2012-05-25 20:25 ` [PATCH v3 04/16] pktcdvd: Switch to bio_kmalloc() Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-5-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-28 1:30 ` Tejun Heo
2012-05-28 1:30 ` Tejun Heo
2012-05-28 1:30 ` [Drbd-dev] " Tejun Heo
2012-05-25 20:25 ` [PATCH v3 05/16] block: Kill bi_destructor Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-6-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-28 1:36 ` Tejun Heo
2012-05-28 1:36 ` Tejun Heo
2012-05-28 1:36 ` [Drbd-dev] " Tejun Heo
2012-05-29 2:10 ` Kent Overstreet
2012-05-29 2:10 ` [Drbd-dev] " Kent Overstreet
[not found] ` <20120529021042.GA6472-RcKxWJ4Cfj3IzGYXcIpNmNLIRw13R84JkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-05-29 2:20 ` Tejun Heo
2012-05-29 2:20 ` Tejun Heo
2012-05-29 2:20 ` [Drbd-dev] " Tejun Heo
2012-05-25 20:25 ` [PATCH v3 06/16] block: Add an explicit bio flag for bios that own their bvec Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-7-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-28 1:52 ` Tejun Heo
2012-05-28 1:52 ` Tejun Heo
2012-05-28 1:52 ` [Drbd-dev] " Tejun Heo
2012-05-25 20:25 ` [PATCH v3 07/16] block: Rename bio_split() -> bio_pair_split() Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-8-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-28 10:15 ` Boaz Harrosh
2012-05-28 10:15 ` Boaz Harrosh
2012-05-28 10:15 ` Boaz Harrosh
2012-05-28 10:15 ` [Drbd-dev] " Boaz Harrosh
[not found] ` <4FC3504B.7000903-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2012-05-29 2:15 ` Kent Overstreet
2012-05-29 2:15 ` Kent Overstreet
2012-05-29 2:15 ` [Drbd-dev] " Kent Overstreet
2012-05-25 20:25 ` [PATCH v3 08/16] block: Rework bio splitting Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-9-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-28 16:12 ` Mikulas Patocka
2012-05-28 16:12 ` Mikulas Patocka
2012-05-28 16:12 ` [Drbd-dev] " Mikulas Patocka
2012-05-25 20:25 ` [PATCH v3 09/16] block: Add bio_clone_kmalloc() Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
2012-05-25 20:25 ` [PATCH v3 10/16] block: Add bio_clone_bioset() Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
2012-05-25 20:25 ` [PATCH v3 11/16] block: Only clone bio vecs that are in use Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
2012-05-25 20:25 ` [PATCH v3 12/16] Closures Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-13-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-25 20:57 ` Joe Perches
2012-05-25 20:57 ` Joe Perches
2012-05-25 20:57 ` [Drbd-dev] " Joe Perches
2012-05-25 21:35 ` Kent Overstreet
2012-05-25 21:35 ` Kent Overstreet
2012-05-25 21:35 ` [Drbd-dev] " Kent Overstreet
2012-05-25 20:25 ` [PATCH v3 13/16] Make generic_make_request handle arbitrarily large bios Kent Overstreet
2012-05-25 20:25 ` Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-14-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-25 22:58 ` Alasdair G Kergon
2012-05-25 22:58 ` Alasdair G Kergon
2012-05-25 22:58 ` [Drbd-dev] " Alasdair G Kergon
[not found] ` <20120525225852.GG5761-FDJ95KluN3Z0klwcnFlA1dvLeJWuRmrY@public.gmane.org>
2012-05-25 23:12 ` Alasdair G Kergon
2012-05-25 23:12 ` Alasdair G Kergon
2012-05-25 23:12 ` [Drbd-dev] " Alasdair G Kergon
2012-05-26 0:18 ` Kent Overstreet
2012-05-26 0:18 ` [Drbd-dev] " Kent Overstreet
2012-05-25 20:25 ` [PATCH v3 14/16] Gut bio_add_page() Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
[not found] ` <1337977539-16977-15-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-25 20:46 ` Mike Snitzer
2012-05-25 20:46 ` Mike Snitzer
2012-05-25 20:46 ` [Drbd-dev] " Mike Snitzer
2012-05-25 21:09 ` Kent Overstreet
2012-05-25 21:09 ` [Drbd-dev] " Kent Overstreet
[not found] ` <20120525210944.GB14196-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-25 22:39 ` Alasdair G Kergon
2012-05-25 22:39 ` Alasdair G Kergon
2012-05-25 22:39 ` [Drbd-dev] " Alasdair G Kergon
[not found] ` <20120525223937.GF5761-FDJ95KluN3Z0klwcnFlA1dvLeJWuRmrY@public.gmane.org>
2012-05-28 16:07 ` Mikulas Patocka
2012-05-28 16:07 ` Mikulas Patocka
2012-05-28 16:07 ` [Drbd-dev] " Mikulas Patocka
[not found] ` <Pine.LNX.4.64.1205281129180.2227-e+HWlsje6Db1wF9wiOj0lkEOCMrvLtNR@public.gmane.org>
2012-05-28 20:28 ` Tejun Heo
2012-05-28 20:28 ` Tejun Heo
2012-05-28 20:28 ` [Drbd-dev] " Tejun Heo
[not found] ` <20120528202839.GA18537-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-05-28 21:27 ` Mikulas Patocka
2012-05-28 21:27 ` Mikulas Patocka
2012-05-28 21:27 ` [Drbd-dev] " Mikulas Patocka
2012-05-28 21:38 ` Tejun Heo
2012-05-28 21:38 ` [Drbd-dev] " Tejun Heo
[not found] ` <20120528213839.GB18537-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-05-28 23:02 ` Tejun Heo
2012-05-28 23:02 ` Tejun Heo
2012-05-28 23:02 ` [Drbd-dev] " Tejun Heo
[not found] ` <20120528230208.GA20954-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-05-29 2:08 ` Dave Chinner
2012-05-29 2:08 ` Dave Chinner
2012-05-29 2:08 ` [Drbd-dev] " Dave Chinner
2012-05-29 2:15 ` Tejun Heo
2012-05-29 2:15 ` Tejun Heo
2012-05-29 2:15 ` [Drbd-dev] " Tejun Heo
[not found] ` <20120529021558.GG20954-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-05-29 3:36 ` Kent Overstreet
2012-05-29 3:36 ` Kent Overstreet
2012-05-29 3:36 ` [Drbd-dev] " Kent Overstreet
2012-05-29 2:07 ` Dave Chinner
2012-05-29 2:07 ` Dave Chinner
2012-05-29 2:07 ` [Drbd-dev] " Dave Chinner
2012-05-29 1:54 ` Dave Chinner
2012-05-29 1:54 ` [Drbd-dev] " Dave Chinner
2012-05-29 3:34 ` Kent Overstreet
2012-05-29 3:34 ` [Drbd-dev] " Kent Overstreet
2012-06-05 0:33 ` Dave Chinner
2012-06-05 0:33 ` [Drbd-dev] " Dave Chinner
2012-05-25 20:25 ` [PATCH v3 15/16] md: Kill merge_bvec_fn()s Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
2012-05-25 20:25 ` [PATCH v3 16/16] dm: Kill merge_bvec_fn() Kent Overstreet
2012-05-25 20:25 ` [Drbd-dev] " Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC2CD93.1080009@ce.jp.nec.com \
--to=j-nomura-jhygz2tfv9j8ursed/g0lq@public.gmane.org \
--cc=agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org \
--cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org \
--cc=koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=sage-BnTBU8nroG7k1uMJSBkQmQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=yehuda-L5o5AL9CYN0tUFlbccrkMA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.