From: Jan Kiszka <jan.kiszka@web.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org,
Alex Graf <agraf@suse.de>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices
Date: Mon, 28 May 2012 14:48:10 +0200 [thread overview]
Message-ID: <4FC3740A.4060801@web.de> (raw)
In-Reply-To: <20120528124410.GC21778@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On 2012-05-28 14:44, Michael S. Tsirkin wrote:
> On Fri, May 25, 2012 at 05:35:03PM +1000, Alexey Kardashevskiy wrote:
>> Some adapters (like NEC PCI USB controller) do not flush their config
>> on a sioftware reset and remember DMA config, etc.
>>
>> If we use such an adapter with QEMU, then crash QEMU (stop it with
>> ctrl-A ctrl-X), and try to use it in QEMU again, it may start working
>> immediately with previous config when pci_enable_device() is called
>> on that PCI function.
>>
>> To eliminate such effect, some quirk should be called. The proposed
>> pci_fixup_final does its job well for mentioned NEC PCI USB but not
>> sure if it is 100% correct.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>
> Won't current kvm device assignment be affected by this?
Would be surprising if not.
> If yes need to address that not just vfio.
A reason to solve this at PCI level?
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org, Alex Graf <agraf@suse.de>,
Alex Williamson <alex.williamson@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [RFC PATCH] vfio: add fixup for broken PCI devices
Date: Mon, 28 May 2012 14:48:10 +0200 [thread overview]
Message-ID: <4FC3740A.4060801@web.de> (raw)
In-Reply-To: <20120528124410.GC21778@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On 2012-05-28 14:44, Michael S. Tsirkin wrote:
> On Fri, May 25, 2012 at 05:35:03PM +1000, Alexey Kardashevskiy wrote:
>> Some adapters (like NEC PCI USB controller) do not flush their config
>> on a sioftware reset and remember DMA config, etc.
>>
>> If we use such an adapter with QEMU, then crash QEMU (stop it with
>> ctrl-A ctrl-X), and try to use it in QEMU again, it may start working
>> immediately with previous config when pci_enable_device() is called
>> on that PCI function.
>>
>> To eliminate such effect, some quirk should be called. The proposed
>> pci_fixup_final does its job well for mentioned NEC PCI USB but not
>> sure if it is 100% correct.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>
> Won't current kvm device assignment be affected by this?
Would be surprising if not.
> If yes need to address that not just vfio.
A reason to solve this at PCI level?
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-05-28 12:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 7:35 [RFC PATCH] vfio: add fixup for broken PCI devices Alexey Kardashevskiy
2012-05-25 7:35 ` [Qemu-devel] " Alexey Kardashevskiy
2012-05-25 8:28 ` Benjamin Herrenschmidt
2012-05-25 8:28 ` [Qemu-devel] " Benjamin Herrenschmidt
2012-05-25 12:24 ` Alex Williamson
2012-05-25 12:24 ` [Qemu-devel] " Alex Williamson
2012-05-25 12:36 ` Benjamin Herrenschmidt
2012-05-25 12:36 ` [Qemu-devel] " Benjamin Herrenschmidt
2012-05-28 12:44 ` Michael S. Tsirkin
2012-05-28 12:44 ` Michael S. Tsirkin
2012-05-28 12:48 ` Jan Kiszka [this message]
2012-05-28 12:48 ` Jan Kiszka
2012-05-28 13:15 ` Michael S. Tsirkin
2012-05-28 13:15 ` Michael S. Tsirkin
2012-06-06 23:17 ` Alex Williamson
2012-06-06 23:17 ` [Qemu-devel] " Alex Williamson
2012-06-07 2:52 ` Benjamin Herrenschmidt
2012-06-07 2:52 ` [Qemu-devel] " Benjamin Herrenschmidt
2012-06-07 3:56 ` Alex Williamson
2012-06-07 3:56 ` Alex Williamson
2012-06-07 4:37 ` Benjamin Herrenschmidt
2012-06-07 4:37 ` [Qemu-devel] " Benjamin Herrenschmidt
2012-06-22 8:16 ` Alexey Kardashevskiy
2012-06-22 8:16 ` [Qemu-devel] " Alexey Kardashevskiy
2012-08-17 14:28 ` Alexey Kardashevskiy
2012-08-17 14:28 ` [Qemu-devel] " Alexey Kardashevskiy
2012-08-21 2:31 ` Alex Williamson
2012-08-21 2:31 ` [Qemu-devel] " Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC3740A.4060801@web.de \
--to=jan.kiszka@web.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.